[Geoserver-devel] [geoserver] GEOS-6245: implemented dynamic width and height calculation for Style LegendURL in WMS Capabilities (043af1c)

Hi Jody,
I’m moving the discussion about GEOS-6245 pull req to dev list.

···

2014-07-09 20:48 GMT+02:00 Jody Garnett <notifications@anonymised.com>:

Resource store has a delete, no need to unpack into a file.

Resource and ResourceStore is primarily intended for managing configuration files, rather than “cache” files of this nature. How do you expect these samples to be handled in a clustered environment? Do you want them stored in a database and unpacked onto each machine? Or do you want each machine to generate its own samples as needed?

Thinking about your comments, probably it is better to avoid using Resource / ResourceStore for samples reading / writing.

I was thinking to use GeoServerDataDirectory functionality instead, to store samples directly on a dedicated data_dir folder (legendsamples?) also if configuration is using, for example, jdbcconfig.

I would not add cluster support for now (each node will have its own copy of the samples cache).
Resource / ResourceStore will still be used to access sld resources (just to check samples freshness, without calling the file() method on the Resource).

What do you think?

Mauro

GeoServerDataDirectory is implemented using ResourceStore.

···

Jody Garnett

On Thu, Jul 10, 2014 at 3:58 AM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,
I’m moving the discussion about GEOS-6245 pull req to dev list.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


2014-07-09 20:48 GMT+02:00 Jody Garnett <notifications@anonymised.com>:

Resource store has a delete, no need to unpack into a file.

Resource and ResourceStore is primarily intended for managing configuration files, rather than “cache” files of this nature. How do you expect these samples to be handled in a clustered environment? Do you want them stored in a database and unpacked onto each machine? Or do you want each machine to generate its own samples as needed?

Thinking about your comments, probably it is better to avoid using Resource / ResourceStore for samples reading / writing.

I was thinking to use GeoServerDataDirectory functionality instead, to store samples directly on a dedicated data_dir folder (legendsamples?) also if configuration is using, for example, jdbcconfig.

I would not add cluster support for now (each node will have its own copy of the samples cache).
Resource / ResourceStore will still be used to access sld resources (just to check samples freshness, without calling the file() method on the Resource).

What do you think?

Mauro

Hi Jody,
but then, what is the standard way (if there is one) to store data locally in a “common” place?

Mauro

···

2014-07-10 18:30 GMT+02:00 Jody Garnett <jody.garnett@anonymised.com>:

GeoServerDataDirectory is implemented using ResourceStore.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Jody Garnett

On Thu, Jul 10, 2014 at 3:58 AM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,
I’m moving the discussion about GEOS-6245 pull req to dev list.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


2014-07-09 20:48 GMT+02:00 Jody Garnett <notifications@anonymised.com>:

Resource store has a delete, no need to unpack into a file.

Resource and ResourceStore is primarily intended for managing configuration files, rather than “cache” files of this nature. How do you expect these samples to be handled in a clustered environment? Do you want them stored in a database and unpacked onto each machine? Or do you want each machine to generate its own samples as needed?

Thinking about your comments, probably it is better to avoid using Resource / ResourceStore for samples reading / writing.

I was thinking to use GeoServerDataDirectory functionality instead, to store samples directly on a dedicated data_dir folder (legendsamples?) also if configuration is using, for example, jdbcconfig.

I would not add cluster support for now (each node will have its own copy of the samples cache).
Resource / ResourceStore will still be used to access sld resources (just to check samples freshness, without calling the file() method on the Resource).

What do you think?

Mauro

Hi,
I changed the pull request a bit to solve concerns about Resource usage: basically I switched to using Resource/ResourceStore only for styles.
For samples, I used a local disk based storage instead (a subfolder of the local data_dir), so in a cluster environment each node has its own local samples cache.

Let me know if this can be merged before freeze or needs more work.

Thank you.
Mauro

···

2014-07-10 18:57 GMT+02:00 Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com…>:

Hi Jody,
but then, what is the standard way (if there is one) to store data locally in a “common” place?

Mauro

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


2014-07-10 18:30 GMT+02:00 Jody Garnett <jody.garnett@anonymised.com>:

GeoServerDataDirectory is implemented using ResourceStore.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Jody Garnett

On Thu, Jul 10, 2014 at 3:58 AM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,
I’m moving the discussion about GEOS-6245 pull req to dev list.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


2014-07-09 20:48 GMT+02:00 Jody Garnett <notifications@anonymised.com>:

Resource store has a delete, no need to unpack into a file.

Resource and ResourceStore is primarily intended for managing configuration files, rather than “cache” files of this nature. How do you expect these samples to be handled in a clustered environment? Do you want them stored in a database and unpacked onto each machine? Or do you want each machine to generate its own samples as needed?

Thinking about your comments, probably it is better to avoid using Resource / ResourceStore for samples reading / writing.

I was thinking to use GeoServerDataDirectory functionality instead, to store samples directly on a dedicated data_dir folder (legendsamples?) also if configuration is using, for example, jdbcconfig.

I would not add cluster support for now (each node will have its own copy of the samples cache).
Resource / ResourceStore will still be used to access sld resources (just to check samples freshness, without calling the file() method on the Resource).

What do you think?

Mauro

To answer your question there is no standard way for “cache files” rather than “configuration files”. Until we had a few more examples (other than geowebcache) it was not worth introducing an API. I don’t see any issuing getting this merge in before the freeze, I will try and look it over again this afternoon.

···

Jody Garnett

On Fri, Jul 11, 2014 at 8:47 AM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi,
I changed the pull request a bit to solve concerns about Resource usage: basically I switched to using Resource/ResourceStore only for styles.
For samples, I used a local disk based storage instead (a subfolder of the local data_dir), so in a cluster environment each node has its own local samples cache.

Let me know if this can be merged before freeze or needs more work.

Thank you.
Mauro

2014-07-10 18:57 GMT+02:00 Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com…>:

Hi Jody,
but then, what is the standard way (if there is one) to store data locally in a “common” place?

Mauro

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


2014-07-10 18:30 GMT+02:00 Jody Garnett <jody.garnett@anonymised.com>:

GeoServerDataDirectory is implemented using ResourceStore.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Jody Garnett

On Thu, Jul 10, 2014 at 3:58 AM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,
I’m moving the discussion about GEOS-6245 pull req to dev list.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


2014-07-09 20:48 GMT+02:00 Jody Garnett <notifications@anonymised.com>:

Resource store has a delete, no need to unpack into a file.

Resource and ResourceStore is primarily intended for managing configuration files, rather than “cache” files of this nature. How do you expect these samples to be handled in a clustered environment? Do you want them stored in a database and unpacked onto each machine? Or do you want each machine to generate its own samples as needed?

Thinking about your comments, probably it is better to avoid using Resource / ResourceStore for samples reading / writing.

I was thinking to use GeoServerDataDirectory functionality instead, to store samples directly on a dedicated data_dir folder (legendsamples?) also if configuration is using, for example, jdbcconfig.

I would not add cluster support for now (each node will have its own copy of the samples cache).
Resource / ResourceStore will still be used to access sld resources (just to check samples freshness, without calling the file() method on the Resource).

What do you think?

Mauro

Hi Jody,

···

2014-07-11 19:24 GMT+02:00 Jody Garnett <jody.garnett@anonymised.com>:

To answer your question there is no standard way for “cache files” rather than “configuration files”. Until we had a few more examples (other than geowebcache) it was not worth introducing an API. I don’t see any issuing getting this merge in before the freeze, I will try and look it over again this afternoon.

Did you had a chance to have a further look at my updated pr?

Thank you.
Mauro

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Sadly I did not, got stuck reviewing the geometry work. I will look at it first thing this morning.

···

Jody Garnett

On Mon, Jul 14, 2014 at 6:33 AM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,

2014-07-11 19:24 GMT+02:00 Jody Garnett <jody.garnett@anonymised.com>:

To answer your question there is no standard way for “cache files” rather than “configuration files”. Until we had a few more examples (other than geowebcache) it was not worth introducing an API. I don’t see any issuing getting this merge in before the freeze, I will try and look it over again this afternoon.

Did you had a chance to have a further look at my updated pr?

Thank you.

Mauro

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Looks good Mauro, will merge (with a few minor javadoc fixes).

···

Jody Garnett

On Mon, Jul 14, 2014 at 6:33 AM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,

2014-07-11 19:24 GMT+02:00 Jody Garnett <jody.garnett@anonymised.com>:

To answer your question there is no standard way for “cache files” rather than “configuration files”. Until we had a few more examples (other than geowebcache) it was not worth introducing an API. I don’t see any issuing getting this merge in before the freeze, I will try and look it over again this afternoon.

Did you had a chance to have a further look at my updated pr?

Thank you.

Mauro

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it