Hi,
the build has been broken in WMS for 5 days now.
The pull request https://github.com/geoserver/geoserver/pull/605 might
fix the build, but as I noticed, it seems to me it will cause layer group security to regress
(a layer group whose contents are not fully visible must be reduced, not hidden,
see http://jira.codehaus.org/browse/GEOS-4982)..)…
Also, that class was not doing any check related to group contents before, so I guess
the regression that makes the test fail happened in the secured catalog itself.
Soo… any proper fix incoming? Or should we revert the GSIP-113 PR?
Cheers
Andrea
–
==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
On Wed, Jun 4, 2014 at 2:37 AM, Andrea Aime <andrea.aime@anonymised.com>
wrote:
Hi,
the build has been broken in WMS for 5 days now.
The pull request https://github.com/geoserver/geoserver/pull/605 might
fix the build, but as I noticed, it seems to me it will cause layer group
security to regress
(a layer group whose contents are not fully visible must be reduced, not
hidden,
see http://jira.codehaus.org/browse/GEOS-4982)…
Also, that class was not doing any check related to group contents before,
so I guess
the regression that makes the test fail happened in the secured catalog
itself.
Soo... any proper fix incoming? Or should we revert the GSIP-113 PR?
As far as I know Kevin is working non-stop on a fix. He can comment on
status but yesterday he mentioned that some other changes introduced
causing failures in the web module were holding him up. It looks like that
is fixed so my preference would be to give him some more time to sort out
the fix. If it doesn't look like there is going to be an end in sight then
I would say we should consider rolling it back.
0.02
Cheers
Andrea
--
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
*Justin Deoliveira*
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive <https://twitter.com/j_deolive>
On Wed, Jun 4, 2014 at 4:43 PM, Justin Deoliveira <jdeolive@anonymised.com
wrote:
As far as I know Kevin is working non-stop on a fix. He can comment on
status but yesterday he mentioned that some other changes introduced
causing failures in the web module were holding him up.
Yep, I told him he could revert that checking that was breaking the build
in web to get unstuck.
It looks like that is fixed so my preference would be to give him some
more time to sort out the fix. If it doesn't look like there is going to be
an end in sight then I would say we should consider rolling it back.
Cool
Cheers
Andrea
--
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
I’ve changed the behaviour of the filter, doing a test build now.
···
On 4 June 2014 07:48, Andrea Aime <andrea.aime@anonymised.com> wrote:
Learn Graph Databases - Download FREE O’Reilly Book
“Graph Databases” is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Kevin Smith
Junior Software Engineer | Boundless
ksmith@anonymised.com
+1-778-785-7459
@boundlessgeo
On Wed, Jun 4, 2014 at 4:43 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:
Yep, I told him he could revert that checking that was breaking the build in web to get unstuck.
Cool
Cheers
Andrea
–
==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
As far as I know Kevin is working non-stop on a fix. He can comment on status but yesterday he mentioned that some other changes introduced causing failures in the web module were holding him up.
It looks like that is fixed so my preference would be to give him some more time to sort out the fix. If it doesn’t look like there is going to be an end in sight then I would say we should consider rolling it back.
That didn’t work, but I think I’ve figured out what I need to do.
···
On 4 June 2014 09:25, Kevin Smith <ksmith@anonymised.com> wrote:
I’ve changed the behaviour of the filter, doing a test build now.
–
Kevin Smith
Junior Software Engineer | Boundless
ksmith@anonymised.com
+1-778-785-7459
@boundlessgeo
On 4 June 2014 07:48, Andrea Aime <andrea.aime@anonymised.com> wrote:
Learn Graph Databases - Download FREE O’Reilly Book
“Graph Databases” is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Kevin Smith
Junior Software Engineer | Boundless
ksmith@anonymised.com
+1-778-785-7459
@boundlessgeo
On Wed, Jun 4, 2014 at 4:43 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:
Yep, I told him he could revert that checking that was breaking the build in web to get unstuck.
Cool
Cheers
Andrea
–
==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
As far as I know Kevin is working non-stop on a fix. He can comment on status but yesterday he mentioned that some other changes introduced causing failures in the web module were holding him up.
It looks like that is fixed so my preference would be to give him some more time to sort out the fix. If it doesn’t look like there is going to be an end in sight then I would say we should consider rolling it back.