[Geoserver-devel] GeoServer publish-release failing

GeoServer GeoServer Developer
1

Error message is a little enigmatic:

./publish_release.sh: line 75: deploy: command not found



Anyone know how to fix this?



Ian
···

Ian Turton

2

That seems to be a case of someone using a line wrapping editor
and not noticing a hard warp introduced in the middle… the mvn parameter “deploy” is sitting on a line of its own:

https://github.com/geoserver/geoserver/blob/master/build/publish_release.sh#L73

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

3

Actually, I think that might be a comment. Trying that now

Ian

···

Ian Turton

4

Deploying the community modules was not done last time (line 78). Line 75 should be a comment …

···

–
Jody Garnett

5

Ahh, that might explain the new error:

Failed to execute goal on project gs-release: Could not resolve dependencies for project org.geoserver.community:gs-release:jar:2.14.5: The following artifacts could not be resolved: org.geoserver.script:gs-script-py:jar:2.14.5, org.geoserver.script:gs-script-js:jar:2.14.5, org.geoserver.script:gs-script-groovy:jar:2.14.5, org.geoserver.extension:gs-monitor-hibernate:jar:2.14.5: Could not find artifact org.geoserver.script:gs-script-py:jar:2.14.5 in boundless ([https://repo.boundlessgeo.com/main/](https://repo.boundlessgeo.com/main/))



I'll check locally, but I don't usually build the community modules.



Ian
···

Ian Turton

6

TLDR: gs-script-py is not being built right now and should be commended out of the release

  1. gs-script is not available, see community/pom.xml line 220. When this was commented out of the build I expect the release artifact was not commented out at the same time.
authkey dds spatialite jdbcconfig wms-eo
  1. To fix comment out community/release/pom.xml line 36:
org.geoserver.script gs-script-py ${project.version}
···

–
Jody Garnett

7

Hi Ian

Note that while you can edit the release scripts on master and have them affect any release, any changes to the pom must be in the commit you are releasing, so you’ll also need to rerun the geoserver-release job with the new commit id before doing the publish.

Also note that while gs-script-py is missing on the 2.14.x branch, it is working fine on master and 2.15.x, and should not be removed from those branches. The community modules build and were deployed without issue when I did the 2.15.2 release last month.

Torben

On Mon, Jul 22, 2019 at 10:37 AM Jody Garnett <jody.garnett@anonymised.com> wrote:

TLDR: gs-script-py is not being built right now and should be commended out of the release

  1. gs-script is not available, see community/pom.xml line 220. When this was commented out of the build I expect the release artifact was not commented out at the same time.
authkey dds spatialite jdbcconfig wms-eo
  1. To fix comment out community/release/pom.xml line 36:
org.geoserver.script gs-script-py ${project.version}

–
Jody Garnett

On Mon, 22 Jul 2019 at 08:26, Ian Turton <ijturton@anonymised.com> wrote:

Ahh, that might explain the new error:

Failed to execute goal on project gs-release: Could not resolve dependencies for project org.geoserver.community:gs-release:jar:2.14.5: The following artifacts could not be resolved: org.geoserver.script:gs-script-py:jar:2.14.5, org.geoserver.script:gs-script-js:jar:2.14.5, org.geoserver.script:gs-script-groovy:jar:2.14.5, org.geoserver.extension:gs-monitor-hibernate:jar:2.14.5: Could not find artifact org.geoserver.script:gs-script-py:jar:2.14.5 in boundless ([https://repo.boundlessgeo.com/main/](https://repo.boundlessgeo.com/main/))



I'll check locally, but I don't usually build the community modules.



Ian

On Mon, 22 Jul 2019 at 16:23, Jody Garnett <jody.garnett@anonymised.com> wrote:

Deploying the community modules was not done last time (line 78). Line 75 should be a comment …

On Mon, Jul 22, 2019 at 5:20 AM Ian Turton <ijturton@anonymised.com> wrote:

Actually, I think that might be a comment. Trying that now

Ian

On Mon, 22 Jul 2019 at 12:46, Andrea Aime <andrea.aime@anonymised.com> wrote:

That seems to be a case of someone using a line wrapping editor
and not noticing a hard warp introduced in the middle… the mvn parameter “deploy” is sitting on a line of its own:

https://github.com/geoserver/geoserver/blob/master/build/publish_release.sh#L73

Cheers
Andrea

On Mon, Jul 22, 2019 at 12:25 PM Ian Turton <ijturton@anonymised.com…403…> wrote:

Error message is a little enigmatic:

./publish_release.sh: line 75: deploy: command not found



Anyone know how to fix this?



Ian

–

Ian Turton

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

–

Ian Turton

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

–
Jody Garnett

–

Ian Turton

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

8

On Mon, 22 Jul 2019 at 20:03, Torben Barsballe <tbarsballe@anonymised.com.> wrote:

Hi Ian

Note that while you can edit the release scripts on master and have them affect any release, any changes to the pom must be in the commit you are releasing, so you’ll also need to rerun the geoserver-release job with the new commit id before doing the publish.

Also note that while gs-script-py is missing on the 2.14.x branch, it is working fine on master and 2.15.x, and should not be removed from those branches. The community modules build and were deployed without issue when I did the 2.15.2 release last month.

Thanks, that would explain why it worked locally, I’ll update 2.14 and restart the process

Ian

9

Sorry Ian - I reached out on gitter and did not see you online. The commit has been made here:

It picks up one back port from Andrea.

I also commented on https://github.com/geoserver/geoserver/commit/96c501fc05de78c0e36ca2b0cc538f071ae4bd90

The comment “# deploy released community modules” was expected and described the following:

pushd community > /dev/null
set +e
mvn clean install deploy -P communityRelease -DskipTests $MAVEN_FLAGS
set -e
popd > /dev/null

So the real question is why set +e is not ignoring any failures when deploying the community extensions?

···

–
Jody Garnett

10

Seems to be happier now, I’ll start the blog post tomorrow unless someone else wants to have a look this evening.

Ian

···

Ian Turton

11

I will fix the release script and try running.

···

–
Jody Garnett

12

Ian:

Torben and I sorted out a few remaining issues with the community release (community release was depending on org.geoserver.extension.gs-monitor-hibernate - which was moved to org.geoserver.community).

The build_release script now tries compiling community modules, and both scripts have a SKIP_COMMUNITY flag if needed.

···

–
Jody Garnett