[Geoserver-devel] geoserver-release failure in sec-cas, blocking 2.4.2

Justin,

geoserver-release is failing in sec-cas while releasing 2.4.2. I have not been able to figure out why:
http://ares.boundlessgeo.com/jenkins/job/geoserver-release/2/consoleText

This was backported earlier this week. I wonder if it has been building because old 2.4-SNAPSHOT artifacts were on the local repo? As soon as the version was rewritten, the problem was exposed.

I don't understand why security-web is missing as the dependency appears to be properly declared, and this module should be built first.

Ideas?

Kind regards,

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

I strongly suspect sec-cas <parent><relativePath>../../../security

I think it is broken for extensions/security/pom.xml to have a module cas as its child that does not have extensions/security as its parent.

On 18/10/13 09:49, Ben Caradoc-Davies wrote:

Justin,

geoserver-release is failing in sec-cas while releasing 2.4.2. I have
not been able to figure out why:
http://ares.boundlessgeo.com/jenkins/job/geoserver-release/2/consoleText

This was backported earlier this week. I wonder if it has been building
because old 2.4-SNAPSHOT artifacts were on the local repo? As soon as
the version was rewritten, the problem was exposed.

I don't understand why security-web is missing as the dependency appears
to be properly declared, and this module should be built first.

Ideas?

Kind regards,

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

I have reparented extension/security/cas and extension/security/we/web-cas so their parentage matches folder structure and added/removed dependencies so they do not need to obtain their test dependencies by inheritance.

If my local test succeeds I will commit these changes to 2.4.x and master and continue with the 2.4.2 release.

Kind regards,
Ben.

On 18/10/13 10:31, Ben Caradoc-Davies wrote:

I strongly suspect sec-cas <parent><relativePath>../../../security

I think it is broken for extensions/security/pom.xml to have a module
cas as its child that does not have extensions/security as its parent.

On 18/10/13 09:49, Ben Caradoc-Davies wrote:

Justin,

geoserver-release is failing in sec-cas while releasing 2.4.2. I have
not been able to figure out why:
http://ares.boundlessgeo.com/jenkins/job/geoserver-release/2/consoleText

This was backported earlier this week. I wonder if it has been building
because old 2.4-SNAPSHOT artifacts were on the local repo? As soon as
the version was rewritten, the problem was exposed.

I don't understand why security-web is missing as the dependency appears
to be properly declared, and this module should be built first.

Ideas?

Kind regards,

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Still not working. Reopened the thing that broke it:
https://jira.codehaus.org/browse/GEOS-5972

On 18/10/13 11:34, Ben Caradoc-Davies wrote:

I have reparented extension/security/cas and
extension/security/we/web-cas so their parentage matches folder
structure and added/removed dependencies so they do not need to obtain
their test dependencies by inheritance.

If my local test succeeds I will commit these changes to 2.4.x and
master and continue with the 2.4.2 release.

Kind regards,
Ben.

On 18/10/13 10:31, Ben Caradoc-Davies wrote:

I strongly suspect sec-cas <parent><relativePath>../../../security

I think it is broken for extensions/security/pom.xml to have a module
cas as its child that does not have extensions/security as its parent.

On 18/10/13 09:49, Ben Caradoc-Davies wrote:

Justin,

geoserver-release is failing in sec-cas while releasing 2.4.2. I have
not been able to figure out why:
http://ares.boundlessgeo.com/jenkins/job/geoserver-release/2/consoleText

This was backported earlier this week. I wonder if it has been building
because old 2.4-SNAPSHOT artifacts were on the local repo? As soon as
the version was rewritten, the problem was exposed.

I don't understand why security-web is missing as the dependency appears
to be properly declared, and this module should be built first.

Ideas?

Kind regards,

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Ouch. It had a dependency on a pom-only module org.geoserver.web:web-security; that is never going to work. Trying again (locally).

If I get it going I would like an urgent review by someone who knows security before I release it in 2.4.2.

On 18/10/13 12:03, Ben Caradoc-Davies wrote:

Still not working. Reopened the thing that broke it:
https://jira.codehaus.org/browse/GEOS-5972

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Oops. The current release is 2.4.1 not 2.4.2.

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Looks like I have a fix, but I think I found a new cas plugin packaging problem (also fixed). Looking for review from a security maintainer.
https://jira.codehaus.org/browse/GEOS-5972

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

I have an itchy trigger finger:
https://github.com/geoserver/geoserver/pull/365

If this is merged then 2.4.1 should be releasable from 8395176a3fcbd611c3b1efabea23e7c58449a292.

Or should we instead just start over next week? GeoTools 10.1 has been published but not yet announced.

On 18/10/13 13:14, Ben Caradoc-Davies wrote:

Looks like I have a fix, but I think I found a new cas plugin packaging
problem (also fixed). Looking for review from a security maintainer.
https://jira.codehaus.org/browse/GEOS-5972

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

My head is spinning try to follow your progress on this one Ben. Is there still an issue you need me to look into?

···

On Thu, Oct 17, 2013 at 10:20 PM, Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com> wrote:

Ouch. It had a dependency on a pom-only module org.geoserver.web:web-security; that is never going to work. Trying again (locally).

If I get it going I would like an urgent review by someone who knows security before I release it in 2.4.2.

On 18/10/13 12:03, Ben Caradoc-Davies wrote:

Still not working. Reopened the thing that broke it:
https://jira.codehaus.org/browse/GEOS-5972


Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive