[Geoserver-devel] [geoserver-scm] [15105] trunk/src/wms/src/main/java/org/geoserver/wms/map/RenderedImageMapOutputFormat.java: do not force component color model when image is indexed or the Mosaic operation fails due to different sample size with th

Ciao Gabriel,
when you make changes to the rendering chain or to the output format,
I would ask you to discuss that on the ML prior to commit, or at least
to open up a jira.
This has been common practice so far for modules like WFS or main
where just had judge. Given the complexity of the raster direct path
and the fact that
me, daniele and andrea are making it evolve slowly, I would like to
avoid stepping on each other toes.

That said, can you explain what the problem was?

Ciao,
Simone.
-------------------------------------------------------

Notice that our office phone number has recently changed!
Please, update your records!

Ing. Simone Giannecchini
GeoSolutions S.A.S.
Founder
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313
mob: +39 333 8128928

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/simonegiannecchini
http://twitter.com/simogeo

-------------------------------------------------------

---------- Forwarded message ----------
From: <groldan@anonymised.com>
Date: Thu, Nov 25, 2010 at 3:39 PM
Subject: [geoserver-scm] [15105]
trunk/src/wms/src/main/java/org/geoserver/wms/map/RenderedImageMapOutputFormat.java:
do not force component color model when image is indexed or the Mosaic
operation fails due to different sample size with the alpha mask
To: scm@anonymised.com

Revision 15105 Author groldan Date 2010-11-25 08:39:07 -0600 (Thu, 25 Nov 2010)

Log Message

do not force component color model when image is indexed or the Mosaic
operation fails due to different sample size with the alpha mask

Modified Paths

trunk/src/wms/src/main/java/org/geoserver/wms/map/RenderedImageMapOutputFormat.java

Diff

Modified: trunk/src/wms/src/main/java/org/geoserver/wms/map/RenderedImageMapOutputFormat.java
(15104 => 15105)

--- trunk/src/wms/src/main/java/org/geoserver/wms/map/RenderedImageMapOutputFormat.java 2010-11-25
12:11:55 UTC (rev 15104)
+++ trunk/src/wms/src/main/java/org/geoserver/wms/map/RenderedImageMapOutputFormat.java 2010-11-25
14:39:07 UTC (rev 15105)
@@ -806,7 +806,9 @@
             //collect alpha channels if we have them
             if (cm.hasAlpha()) {
                 final ImageWorker worker = new ImageWorker(image);
- worker.forceComponentColorModel();
+ // GR: Alpha images must have the same sample size as
the sources, otherwise the
+ // Mosaic operation bellow fails
+ // worker.forceComponentColorModel();155216950 nora ramirez
                 final RenderedImage alpha =
worker.retainLastBand().getRenderedImage();
                 alphaChannels = new PlanarImage {
PlanarImage.wrapRenderedImage(alpha) };
             }

________________________________

To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email