[Geoserver-devel] GeoServer Windows build: one module left failing

Hi,
yesterday I did some work to try and bring the Windows build of GeoServer in shape. I’m almost there, but there is app-schema-test that has still 4 failures related to namespaces:
http://office.geo-solutions.it/jenkins/job/GeoServer%20master%20+%20wcs20/org.geoserver.extension$app-schema-test/262/testReport/

The issue apparently cannot be reproduced in the IDE, on the same windows machine, nor with Maven… it seems Jenkins has some special Voodoo to make it fail… :frowning:
I saw something similar with other tests that took less time to GC stuff on the normal maven build…
Does any app-schema expert have time to chime in?

Cheers
Andrea

==
GeoServer training in Milan, 6th & 7th June 2013! Visit http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Looks like a disagreement between two code paths about whether "+" should be encoded in a file URL. This is clear in the last two failures, and I suspect the root cause of the first two (asserts on file schema locations).

Culprits look like FeatureChainingWfsTest.getExSchema{One,Two}Location() which perform File->URI->String conversion without using DataUtilities.fileToURL(), which converts "+" to "%2B" in case you are on a Mac. :stuck_out_tongue:

I just pushed a fix to master.

Kind regards,
Ben.

On 09/04/13 16:00, Andrea Aime wrote:

Hi,
yesterday I did some work to try and bring the Windows build of
GeoServer in shape. I'm almost there, but there is app-schema-test that
has still 4 failures related to namespaces:
http://office.geo-solutions.it/jenkins/job/GeoServer%20master%20+%20wcs20/org.geoserver.extension$app-schema-test/262/testReport/

The issue apparently cannot be reproduced in the IDE, on the same
windows machine, nor with Maven.. it seems Jenkins has some special
Voodoo to make it fail... :frowning:
I saw something similar with other tests that took less time to GC stuff
on the normal maven build...
Does any app-schema expert have time to chime in?

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it
<http://geoserver.geo-solutions.it/&gt; for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Andrea,

the new job failed on something else before it got to app-schema-test. Looks like a system problem.

Kind regards,
Ben.

On 09/04/13 16:49, Ben Caradoc-Davies wrote:

Looks like a disagreement between two code paths about whether "+"
should be encoded in a file URL. This is clear in the last two failures,
and I suspect the root cause of the first two (asserts on file schema
locations).

Culprits look like FeatureChainingWfsTest.getExSchema{One,Two}Location()
which perform File->URI->String conversion without using
DataUtilities.fileToURL(), which converts "+" to "%2B" in case you are
on a Mac. :stuck_out_tongue:

I just pushed a fix to master.

Kind regards,
Ben.

On 09/04/13 16:00, Andrea Aime wrote:

Hi,
yesterday I did some work to try and bring the Windows build of
GeoServer in shape. I'm almost there, but there is app-schema-test that
has still 4 failures related to namespaces:
http://office.geo-solutions.it/jenkins/job/GeoServer%20master%20+%20wcs20/org.geoserver.extension$app-schema-test/262/testReport/

The issue apparently cannot be reproduced in the IDE, on the same
windows machine, nor with Maven.. it seems Jenkins has some special
Voodoo to make it fail... :frowning:
I saw something similar with other tests that took less time to GC stuff
on the normal maven build...
Does any app-schema expert have time to chime in?

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it
<http://geoserver.geo-solutions.it/&gt; for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

On Tue, Apr 9, 2013 at 11:36 AM, Ben Caradoc-Davies <
Ben.Caradoc-Davies@anonymised.com> wrote:

Andrea,

the new job failed on something else before it got to app-schema-test.
Looks like a system problem.

Nah, it's a problem in the security subsystem, just like the one I fixed
yesterday, a input stream
that is opened and never closed.
I'm fixing it

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

On Tue, Apr 9, 2013 at 11:54 AM, Andrea Aime
<andrea.aime@anonymised.com>wrote:

On Tue, Apr 9, 2013 at 11:36 AM, Ben Caradoc-Davies <
Ben.Caradoc-Davies@anonymised.com> wrote:

Andrea,

the new job failed on something else before it got to app-schema-test.
Looks like a system problem.

Nah, it's a problem in the security subsystem, just like the one I fixed
yesterday, a input stream
that is opened and never closed.
I'm fixing it

Success, all good now, thanks Ben.
The monitoring hibernate tests are still occasionally failing
unfortunately, not sure what to do about them.
Testing wise, it would be the same if the database was an in memory one,
but I don't see a quick way
to force the code use that approach.

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------