[Geoserver-devel] GeoServerPersister design question

Quick question looking at GeoServerPersister source code (responsible for GEOS-6461). This class listens to catalog change events and writes them out to disk.

This class makes use of a GeoServerResourceLoader and a GeoServerDataDirectory - but ends up reproducing a lot of the “file logic” of GeoServerDataDirectory.

Is there any reason why GeoServerPersister is not trusting GeoServerDataDirectory? Or is it a case of one class being built before the other.

Jody Garnett

It is kind of incomplete I guess, org.geoserver.config.GeoServerDataDirectory actually came after GeoServerPersister I think, and I guess we didn’t port all methods over to it in order to replace resource loader. I would have to take a closer look to see if it’s totally replaceable.

Anyways, if we can move all the logic that GeoServerPersister needs into GeoServerDirectory I think that is great.

···

On Thu, Apr 24, 2014 at 1:24 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Quick question looking at GeoServerPersister source code (responsible for GEOS-6461). This class listens to catalog change events and writes them out to disk.

This class makes use of a GeoServerResourceLoader and a GeoServerDataDirectory - but ends up reproducing a lot of the “file logic” of GeoServerDataDirectory.

Is there any reason why GeoServerPersister is not trusting GeoServerDataDirectory? Or is it a case of one class being built before the other.

Jody Garnett


Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive