[Geoserver-devel] GeoServerTileLayer and "dynamic bounds" (which do not seem so dynamic after all)

Hi all,
working on this PR I stumbled into some integrated GWC behavior that seems confusing, if not wrong.
When configuring a new layer in GeoServer, with default tile caching, or when adding tile caching to a
a layer, the grid subset bonds for it as set to “dynamic”, as in, computed on the fly from the layer
own bounds (which can change over time):

image.png

Seems like a reasonable thing to do. GeoServerTileLayer can compute the bounds dynamically, while the configuration object backing it,
GeoServerTileLayerInfo, containing the XMLGridSubsets objects, has them with null bounds.

However, things can become less dynamic… let’s make a GetCapabilities run, the “dynamic” bounds will be computed so that they can be reported,
and then go back to the layer tile caching tab, you get this:

image.png

If the layer is not saved, and the configuration reloaded, the page goes back to dynamic bounds. But save the page, even for unrelated changes, and the
bounds are now carved in stone, and I know no way to make them go back to dynamic.

This seems wrong to me. The issue is happening in this line, updating the xml gridset bounds while computing the tile layer dynamic bounds:
https://github.com/geoserver/geoserver/blob/main/src/gwc/src/main/java/org/geoserver/gwc/layer/GeoServerTileLayer.java#L999

I tried to get rid of it, and to try and set the extends only for the time it takes to generate the GridSubset in the line below, but
that causes several tests to fail (report attached). Can anyone shed some light on this behavior?

Cheers
Andrea

(attachments)

gwc_failures.txt (11.6 KB)

···

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

Hello Andrea,
such behavior does not seem to be correct to me either.

Currently what I do in order to reset the gridset to dynamic is to push again the tiled-layer configuration via rest by removing completely the gridsets bounds. That seems to force the integrated GWC to put them to dynamic again.

(attachments)

image.png
image.png

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.