[Geoserver-devel] [Geotools-devel] Coverage speedup patch ready to be applied

Andrea Aime ha scritto:

Hi,
after quite a bit of testing on our own and a cross review
in person during the FOSS4G-IT 2009 conference in Lugano
me and Simone have agreed it's time to turn the patch
into committed status.

Oh, just noticed the GeoTools patch was incomplete.
Here is a better one.

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

(attachments)

gt-coverageSpeedup.patch (17.6 KB)

Started more extensive tests, found one bug with grayscale + alpha raster data.

Added some fixes/improvements to geotools trunk, modified a bit the
path for GeoServer (attached). The patch for geotools is untouched.
Andrea, can you check performance are not degraded? If so, I strongly
suggest to commit and start testing/improving before carrying these
patches around becomes too big as a burden.

Ciao,
Simone.
-------------------------------------------------------
Ing. Simone Giannecchini
GeoSolutions S.A.S.
Founder - Software Engineer
Via Carignoni 51
55041 Camaiore (LU)
Italy

phone: +39 0584983027
fax: +39 0584983027
mob: +39 333 8128928

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/simonegiannecchini
http://twitter.com/simogeo

-------------------------------------------------------

On Thu, Feb 18, 2010 at 7:18 PM, Andrea Aime <aaime@anonymised.com> wrote:

Andrea Aime ha scritto:

Hi,
after quite a bit of testing on our own and a cross review
in person during the FOSS4G-IT 2009 conference in Lugano
me and Simone have agreed it's time to turn the patch
into committed status.

Oh, just noticed the GeoTools patch was incomplete.
Here is a better one.

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

(attachments)

gsCoverageSpeedup.patch (40.5 KB)

Simone Giannecchini ha scritto:
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

Started more extensive tests, found one bug with grayscale + alpha raster data.

Added some fixes/improvements to geotools trunk, modified a bit the
path for GeoServer (attached). The patch for geotools is untouched.
Andrea, can you check performance are not degraded? If so, I strongly
suggest to commit and start testing/improving before carrying these
patches around becomes too big as a burden.

Agreed, they are a burden, and it's difficult to see what gets
changed from one version to the other.

I've made a test run and it seems performance went down 10 to 20%
compared to my previous runs but I can't figure out where/how exactly.
It seems it's doing more work, as even the single threaded case
slowed down (from 5.1 r/s to 4.4).

Anyways, we have time to improve the patch: I'm going to commit
it as is and we'll improve it over time

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.