Attending
Kevin Smith
Torben Barsballe
Andrea Aime
Jody Garnett
Actions from last meeting:- [DONE] Jody/Gabriel: Write up GSIP for GeoServer-Cloud project
-
[DONE] Torben: Try zhCN translation to see if it is published
-
Release blog post - Start a branch / pr to work on this
Agenda1. Meeting Time change for next meeting
-
Freemarker upgrade backport
-
Backporting 512px gridsets, backport
-
SortPom, third time’s the charm?
-
2.19.0 release in two days
-
Packaging/assemblies, how to make that better
-
Chit chat
Actions- Move meeting time discussion to mailing list
Meeting Time change for next meeting
Move it back one hour (To 16:30 UTC) as we usually do?
Andrea: +1
Torben: +1
Kevin: +1
Jody +1
Continue discussion/voting on list
Discussion: Should we try to switch to a different time zone with daylight savings time built-in?
-
No, several countries are proposing getting rid of DST, so anything we put in place would likely have to change soon anyway.
-
UTC is always clear anyways.
Freemarker upgrade backport
Some nice improvements, but some folks may need to update templates (for backwards compatibility).
-
Be sure to include update instructions in release announcements
-
Consider a separate blog post, and then link to it from release announcements?
-
List of freemarker changes: https://github.com/geoserver/geoserver/pull/4782
Backporting 512px gridsets, backport
Strictly additive change, not shown by defaults.
Jody +1
Kevin +1
SortPom, third time’s the charm?
See email for ongoing saga …
-
SortPom is specific to sorting pom.xml and does a good job
-
Predictable order (great for readability)
-
Preservers blank lines (well reduces to one blank lines)
-
Preservers comments etc…
Please do this just to fix tabs vs spaces
Q: Brad asks about 2 spaces vs 4 spaces
-
Since we use 4 spaces for java? Should we use for 2 spaces …
-
Maven has a style guide which uses 2 spaces: https://maven.apache.org/developers/conventions/code.html#xml-code-style
Sidebar for applicationContext.xml formatting:
-
Checking “spotless” to see if it works with parallel build?
-
Most applicationContext.xml files uses 4 spaces…
Andrea, Jody, Kevin, Torben → 2 spaces everywhere for XML files (all XML files)
2.19.0 release in two days
Q: Any last moment changes incoming?
- Not that we are aware of…
Q: Is any help needed?
- Blog post from last time should be good …
Q: Were all the packaging issues address?
- We think so, but worth checking pre-release artifacts
Discussion:
- Windows installer will show up later, using whatever the latest release is
Packaging/assemblies, how to make that better- Packaging side on GeoCat side improved
-
Markdown in HTML
-
Logo in SVG
-
GeoTools
-
Use JTS style ant script to run the quickstart in the release.
-
Extensions: recent extensions broke other extensions …
-
proposals: Move assemblies to the individual extensions to make things self contained
-
Multimodule extensions will need to determine which submodule to host the assembly descriptor(s) on a case-by-case basis
-
How to copy all the zips to release folder?
-
Use copy-resources maven build step to releases/pom.xml
-
Copy from extensions//target/<bundle.zip> to release/target/<bundle.zip>
-
Can we add integration testing? ← yes
-
Maven integration test step does this
-
Examples using jetty on how to do this (usually used to test multiple wars working together)
-
Reference pre-integration-test, integration-test, post-integration-test stages
-
Do this after extension makes package, to verify it works in a jetty integration test
-
Can we avoid transitive when functionality moves to core
-
For example when geopackage moved to core …
-
For example when jackson moved to core …
-
Difference between:
-
moduleSets - some ability to exclude modules here
-
dependencySets
-
fileSets
Chit chat- Cloud First GeoServer is now setup
-
Congrats Gabe and camptocamp
-
The github pages needs some theme to look pretty!
-
foss4G Presentations anyone?
-
Deadline the end of the month, who is up for some geotools / geoserver presentations?
-
State GeoServer
-
GeoServer Ecosystems ← some case studies for biz track
-
GeoServer Orientation
-
DGGS - discrete global grid system
-
OGC API Presentation
-
Cloud First GeoServer ← talk to Gabe
-
GeoPackage Improvments
-
AppSchema SMART ← community module Marco is working on
-
AssertJ discussion (just thinking out loud, no plan to actually do it in the short term)
-
Alternative to Hamcrest, which is no longer bundled with JUnit
-
AssertJ is a fun alternative that looks good
-
Nice fluent presentation with better output messages etc…
-
Some tools to migrate JUnit assert statements to AssertJ, no one found for Hamcrest
-
GeoServer 2.19.0 Docker?
-
Docker is setup, two pull requests active …
-
Any way to get this unstuck?
-
CITE Tests
-
Docker is setup, not sure what else is going on …
-
Jody / Juan available to help if more assistance is needed
-
M1 Rendering difference
-
Pattern along line is written in java code in geotools
-
So not java2d or opengl optimization …
-
Probably has to be with measurements
-
Code is deep in Java 2D Shape, trying to connect with prevision shape
-
Use git blame on failing test to locate the actual revision implementing