Attending
Andrea Aime
Torben Barsballe
Kevin Smith
Jody Garnett
Actions from last meeting:- [DONE] Test windows installer
Agenda1. i18n GSIP update
-
Backporting caching nearest matches fixes
-
High cognitive complexity clean up, first pass
-
geotools release bundle
Actions- Andrea: ask on list about backport of caching skip on nearest match or no match (and also on default value)
i18n GSIP update
https://github.com/geoserver/geoserver/wiki/GSIP-203
Status: done
UI and caps done
INSPIRE extension LANGUAGE KVP parameter implemented with translation, with property file to configure.
Added a function, called “language”, which reports the language chosen, along with recode allows to choose labels, or other things like symbols.
Possible to set default language at the service level too.
-
SLD
-
Docs: https://docs.geoserver.org/latest/en/user/styling/sld/language.html
-
Title and abstract
-
Docs: https://docs.geoserver.org/latest/en/user/services/internationalization/index.html
-
INSPIRE:
-
Docs: https://docs.geoserver.org/latest/en/user/extensions/inspire/using.html#internationalization-support
Backport, probably in a month, touched many files.
Backporting caching nearest matches fixes
Not caching on nearest match or mismatch. Landed on master a month ago, now we would like to backport to 2.19.x. GeoSolutins has servers on master that haven’t misbehaved, and we also deployed a 2.16.x with the same changes.
New behavior is configurable, no behavioral changes if not enabled. Andrea to send a formal request on the devel list.
High cognitive complexity clean up, first pass
https://www.sonarsource.com/docs/CognitiveComplexity.pdf
Discussed previously:
-
Alternative to method length check being explored by gabe
-
Thread on SourceForge archive: https://sourceforge.net/p/geotools/mailman/geotools-devel/thread/CA%2BnxMTuoMABSE%3D82VxShdpAgjbh%3DvuxPP7h2GBOw7AYfP8%2BcUQ%40mail.gmail.com/#msg37301552
-
The latest version of PMD has a check for this
-
Default is 15, we are well passed that
-
Andrea got some 200 methods down to 160, Ian merged:
geotools release bundle
The PR is here: https://github.com/geotools/geotools/pull/3569
-
First commit just adds markdown to html
-
Jody (with some encouragement from Andrea) had a go at removing jar-collector
-
moduleSet:
-
Only works during a complete package build to access live module list
-
Was hoping it could use module parent / child structure to direct
-
However very poor control over module by module dependencies
-
binaryDist.xml → gt-release-26-SNAPSHOT-bin.zip
-
dependencySet:
-
Some double handling, release/pom.xml needs dependency and then assembly
-
Has good control over what is packed where
-
binaryDist2.xml → gt-release-26-SNAPSHOT-bin.zip
Looking forward to Ian’s feedback on this one.
-
See release/README.md for testing instructions
-
unzip release/target/gt-release-26-SNAPSHOT-bin.zip
-
java -cp “gt-release-26-SNAPSHOT/lib/*” org.geotools.util.factory.GeoTools
Goal should be to be able to run the quickstart tutorials with just a bin download.