[Geoserver-devel] GeoWebCache API change breaking GeoServer build

Hi,
we currently have a GWC api change that is breaking the GeoServer build:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /var/lib/hudson/jobs/geoserver-2.3.x/workspace/src/gwc/src/main/java/org/geoserver/gwc/layer/GeoServerTileLayer.java:[75,7] org.geoserver.gwc.layer.GeoServerTileLayer is not abstract and does not override abstract method getInfoMimeTypes() in org.geowebcache.layer.TileLayer
[INFO] 1 error

The issue is related to this merge:

https://github.com/GeoWebCache/geowebcache/commit/efaaf71545abc19440cde633bee981195c3f769c

I believe that implementing that method so that it returns null may do the trick (the info mime types are new, so I guess there is some backwards compatibility layer that makes it behave like before if the list is not provided?)

The second worrysome thing is that there is no gwc-master build, and this resulted in a delay of 3 days before we discovered the problem.
I could setup one, and make it so that it triggers the GeoServer master build too, but the computing resources are not mine so I’d at least wait for some confirmation from OpenGeo.

Finally, the topic of releasing GWC. GWC trunk has been part of GeoServer releases and we had no new big issue reported, I also know it has been used in production without again much of an issue so… can we release it?
RC maybe?

What would be the procedure for a GWC release?
What kind of permissions are needed?
Do you think it’s feasible to setup release scripts like the gt/gs ones?

Cheers
Andrea

==
GeoServer training in Milan, 6th & 7th June 2013! Visit http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Should we collect a tag from before this API change (as a reference point for release?)


Jody Garnett

On Sunday, 12 May 2013 at 12:05 PM, Andrea Aime wrote:

Hi,
we currently have a GWC api change that is breaking the GeoServer build:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :  
[INFO] -------------------------------------------------------------
[ERROR] /var/lib/hudson/jobs/geoserver-2.3.x/workspace/src/gwc/src/main/java/org/geoserver/gwc/layer/GeoServerTileLayer.java:[75,7] org.geoserver.gwc.layer.GeoServerTileLayer is not abstract and does not override abstract method getInfoMimeTypes() in org.geowebcache.layer.TileLayer
[INFO] 1 error

The issue is related to this merge:

https://github.com/GeoWebCache/geowebcache/commit/efaaf71545abc19440cde633bee981195c3f769c

I believe that implementing that method so that it returns null may do the trick (the info mime types are new, so I guess there is some backwards compatibility layer that makes it behave like before if the list is not provided?)

The second worrysome thing is that there is no gwc-master build, and this resulted in a delay of 3 days before we discovered the problem.
I could setup one, and make it so that it triggers the GeoServer master build too, but the computing resources are not mine so I’d at least wait for some confirmation from OpenGeo.

Finally, the topic of releasing GWC. GWC trunk has been part of GeoServer releases and we had no new big issue reported, I also know it has been used in production without again much of an issue so… can we release it?
RC maybe?

What would be the procedure for a GWC release?
What kind of permissions are needed?
Do you think it’s feasible to setup release scripts like the gt/gs ones?

Cheers
Andrea

==
GeoServer training in Milan, 6th & 7th June 2013! Visit http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



Learn Graph Databases - Download FREE O’Reilly Book
“Graph Databases” is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

At the least (in my view) we should make milestone builds of GWC for stable and master to support GS stable and master.

I also notice that GWC master (1.4.x) has a dependency (via gwc-wms and gwc-georss) on GeoTools 9-SNAPSHOT. At the moment, GeoServer master, which depends on GeoTools 10-SNAPSHOT, survives this via dependency management, but it is going to break one day (e.g. a backwards-incompatible change in GT 10).

Kind regards,
Ben.

On 13/05/13 03:42, Jody Garnett wrote:

Should we collect a tag from before this API change (as a reference
point for release?)

--
Jody Garnett

On Sunday, 12 May 2013 at 12:05 PM, Andrea Aime wrote:

Hi,
we currently have a GWC api change that is breaking the GeoServer build:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /var/lib/hudson/jobs/geoserver-2.3.x/workspace/src/gwc/src/main/java/org/geoserver/gwc/layer/GeoServerTileLayer.java:[75,7] org.geoserver.gwc.layer.GeoServerTileLayer is not abstract and does not override abstract method getInfoMimeTypes() in org.geowebcache.layer.TileLayer
[INFO] 1 error

The issue is related to this merge:

https://github.com/GeoWebCache/geowebcache/commit/efaaf71545abc19440cde633bee981195c3f769c

I believe that implementing that method so that it returns null may do
the trick (the info mime types are new, so I guess there is some
backwards compatibility layer that makes it behave like before if the
list is not provided?)

The second worrysome thing is that there is no gwc-master build, and
this resulted in a delay of 3 days before we discovered the problem.
I could setup one, and make it so that it triggers the GeoServer
master build too, but the computing resources are not mine so I'd at
least wait for some confirmation from OpenGeo.

Finally, the topic of releasing GWC. GWC trunk has been part of
GeoServer releases and we had no new big issue reported, I also know
it has been used in production without again much of an issue so...
can we release it?
RC maybe?

What would be the procedure for a GWC release?
What kind of permissions are needed?
Do you think it's feasible to setup release scripts like the gt/gs ones?

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it/>
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
<mailto:Geoserver-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

As discussed at Monday's GeoTools / GeoServer Meeting, I will now make a GWC milestone with version 1.4-M20130509 and deploy it to the osgeo repo. This will allow me to fix the GeoServer 2.3.x and master builds and proceed with this week's release.

We know that the GWC devs are pretty busy right now; we are happy to review this dependency when their availability changes.

Kind regards,
Ben.

On 13/05/13 13:47, Ben Caradoc-Davies wrote:

At the least (in my view) we should make milestone builds of GWC for
stable and master to support GS stable and master.

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

I deployed a GeoWebCache milestone 1.4-M20130509a to the osgeo repo and updated GeoServer master and 2.3.x to use it.

(Second attempt was to get correct revision info in the manifests for the GeoServer About page. Yes, commit, *then* build. Doh!)

I have published the tag:
https://github.com/bencaradocdavies/geowebcache/tree/1.4-M20130509a
https://github.com/bencaradocdavies/geowebcache/commit/05467ecca1592aa9b2dafc1f4aa5845650feea21

Build and deployment notes attached. I deployed each artifact by itself to avoid publishing a modified distributionManagement, which would suggest osgeo is the main repo.

Kind regards,
Ben.

On 14/05/13 09:17, Ben Caradoc-Davies wrote:

As discussed at Monday's GeoTools / GeoServer Meeting, I will now make a
GWC milestone with version 1.4-M20130509 and deploy it to the osgeo
repo. This will allow me to fix the GeoServer 2.3.x and master builds
and proceed with this week's release.

We know that the GWC devs are pretty busy right now; we are happy to
review this dependency when their availability changes.

Kind regards,
Ben.

On 13/05/13 13:47, Ben Caradoc-Davies wrote:

At the least (in my view) we should make milestone builds of GWC for
stable and master to support GS stable and master.

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

(attachments)

geowebcache-milestone.txt (1.32 KB)

On Tue, May 14, 2013 at 10:20 AM, Ben Caradoc-Davies <
Ben.Caradoc-Davies@anonymised.com> wrote:

I deployed a GeoWebCache milestone 1.4-M20130509a to the osgeo repo and
updated GeoServer master and 2.3.x to use it.

(Second attempt was to get correct revision info in the manifests for the
GeoServer About page. Yes, commit, *then* build. Doh!)

I have published the tag:
https://github.com/**bencaradocdavies/geowebcache/**tree/1.4-M20130509a&lt;https://github.com/bencaradocdavies/geowebcache/tree/1.4-M20130509a&gt;
https://github.com/**bencaradocdavies/geowebcache/**commit/**
05467ecca1592aa9b2dafc1f4aa584**5650feea21<https://github.com/bencaradocdavies/geowebcache/commit/05467ecca1592aa9b2dafc1f4aa5845650feea21&gt;

Build and deployment notes attached. I deployed each artifact by itself to
avoid publishing a modified distributionManagement, which would suggest
osgeo is the main repo.

Thanks Ben!

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------