[Geoserver-devel] GetCapabilities document - bug fixing

There is a small bug in the WmsCapabilitiesResponseHandler class at line 81:
"wms/1.1.1/WMS_MS_Capabilities.dtd\"");
must be replaced by
"/wms/1.1.1/WMS_MS_Capabilities.dtd\"");
The first slash is necessary for a good path to the DTD.

Furthermore, I have done some change in this same class yesterday (sent to Gabriel in a zip file). I have forgotten to add this statement at line 336:
attrs.addAttribute("", "xmlns:xlink", "xmlns:xlink", "", "http://www.w3.org/1999/xlink"\);

Regards

Charles

Quoting Charles Kolbowicz <Charles.Kolbowicz@anonymised.com>:

There is a small bug in the WmsCapabilitiesResponseHandler class at
line
81:
"wms/1.1.1/WMS_MS_Capabilities.dtd\"");
must be replaced by
"/wms/1.1.1/WMS_MS_Capabilities.dtd\"");
The first slash is necessary for a good path to the DTD.

Fixed - http://jira.codehaus.org/browse/GEOS-223. Thanks for this
catch, this is a bad error, I should have done more testing before the
last couple of releases.

Furthermore, I have done some change in this same class yesterday
(sent
to Gabriel in a zip file). I have forgotten to add this statement at
line 336:
attrs.addAttribute("", "xmlns:xlink", "xmlns:xlink", "",
"http://www.w3.org/1999/xlink&quot;\);

Could you attach the files to the JIRA task I created for you?
http://jira.codehaus.org/browse/GEOS-222 I'm probably going to be the
one to roll them in, as Gabriel is still getting set up I believe. You
can attach files directly to the task, so that anyone can download
them.

thanks,

Chris

Regards

Charles

-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on
ITManagersJournal
Use IT products in your business? Tell us what you think of them.
Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find
out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/

That's done. I have attached the last archive to the JIRA task.

Best regards

Charles

cholmes@anonymised.com a écrit :

Could you attach the files to the JIRA task I created for you?
http://jira.codehaus.org/browse/GEOS-222 I'm probably going to be the
one to roll them in, as Gabriel is still getting set up I believe. You
can attach files directly to the task, so that anyone can download
them.

thanks,

Chris

Ok, we've rolled all the files into SVN. Gabriel got the initial ones,
and I just put in the fix. But it seems to me that some are missing?
Like the ones to read and write the xml file? I reviewed the code and
it all looks solid, but there is no point where the info.xml file gets
translated into the LegendURL object and DTO. At least not that I
could find (or test). If you haven't done the writer that's fine, I
can probably do it for you (it's important to have it so that the web
admin tool doesn't over write any changes you added by hand). But I
figure you must have done the reader and forgotten to include it? Some
modification to global/xml/XMLConfigReader?

thanks again,

Chris

Quoting Charles Kolbowicz <Charles.Kolbowicz@anonymised.com>:

That's done. I have attached the last archive to the JIRA task.

Best regards

Charles

cholmes@anonymised.com a écrit :

>Could you attach the files to the JIRA task I created for you?
>http://jira.codehaus.org/browse/GEOS-222 I'm probably going to be
the
>one to roll them in, as Gabriel is still getting set up I believe.
You
>can attach files directly to the task, so that anyone can download
>them.
>
>thanks,
>
>Chris
>
>

-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on
ITManagersJournal
Use IT products in your business? Tell us what you think of them.
Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find
out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/

Indeed, I forgot to provide the new XMLConfigReader. Hum... I repair this by attaching the new class at http://jira.codehaus.org/browse/GEOS-222 .

Sorry for this waste of time.

Charles

cholmes@anonymised.com a écrit :

Ok, we've rolled all the files into SVN. Gabriel got the initial ones,
and I just put in the fix. But it seems to me that some are missing? Like the ones to read and write the xml file? I reviewed the code and
it all looks solid, but there is no point where the info.xml file gets
translated into the LegendURL object and DTO. At least not that I
could find (or test). If you haven't done the writer that's fine, I
can probably do it for you (it's important to have it so that the web
admin tool doesn't over write any changes you added by hand). But I
figure you must have done the reader and forgotten to include it? Some
modification to global/xml/XMLConfigReader?

thanks again,

Chris