Hi,
following the last PSC meeting, and after attempting to use spotless,
I’ve realized we have a mix of line endings in our git checkouts, mostly
due to people forgetting to set the autocrlf setting in git.
This pull request tries to fix them, and adds a .gitattributes file that should
avoid having funny line endings in the repo, in the future.
https://github.com/geotools/geotools/pull/3702
Feedback I’m looking for:
- Are people ok with this?
- Can anyone on windows/osx try it out and see if anything strange happens? (I believe after checkout it out, a “git reset --hard” will be needed to fix files newlines
If I don’t get negative feedback, I plan to apply the PR to GeoTools and the backport on the stable and maintenance branches, and then apply the same process to GWC and GS as well.
I’ll do it over the Christmas break, hopefully less people are making changes that could be affected by the PRs then.
Cheers
Andrea
···
GeoServer Professional Services from the experts!
Visit http://bit.ly/gs-services-us for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions Group
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928
https://www.geosolutionsgroup.com/
http://twitter.com/geosolutions_it
Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail