GeoServerResourceLoader - search locations now removed
GeoServerExtensions.file( path ) - method added to access servletContext for web.xml
GeoServerResourceLoader - training wheels now removed, internals now only use Resource
GeoServerDataDirectory - file access methods now use Resource
GeoServerSecurityManager - file access methods now use Resource
After this first pull request (devoted to file access) there will be a gap as we update each module to use Resource.
Note: The internals of GeoServerResourceLoader, GeoServerDataDirectory and GeoServerSecurityManager are setup to allow “inline refactor” to quickly updated client.
+1 - it's taken me a while to get my head around this one but now I understand it, I like it. Would make management between development, test, and production instances of the servers a lot easier with JDBC config.
Notice: This email and any attachments are confidential.
If received in error please destroy and immediately notify us.
Do not copy or disclose the contents.
Even with out JDBC config I am seeing some benefits in simplifying the code, and having a chance for consistent file lock and file watch across our data directory. I suspect someone could have fun with a github backed implementation for example.
+1 - it’s taken me a while to get my head around this one but now I
understand it, I like it. Would make management between development,
test, and production instances of the servers a lot easier with JDBC config.
Notice: This email and any attachments are confidential.
If received in error please destroy and immediately notify us.
Do not copy or disclose the contents.
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
Some stupid questions, apologize but I do not have much time to see deeply the implementation proposal … basically if I understood correctly this resource store write the file into the data dir streamed out from the DB if it does not exist, is that right?
In that case I see that you already spoken and taken into account the locking mechanism.
Please correct me if I’m wrong, as I said I did not have the chance to study the examples.
Even with out JDBC config I am seeing some benefits in simplifying the code, and having a chance for consistent file lock and file watch across our data directory. I suspect someone could have fun with a github backed implementation for example.
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
+1 - it’s taken me a while to get my head around this one but now I
understand it, I like it. Would make management between development,
test, and production instances of the servers a lot easier with JDBC config.
Notice: This email and any attachments are confidential.
If received in error please destroy and immediately notify us.
Do not copy or disclose the contents.
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
Some stupid questions, apologize but I do not have much time to see deeply the implementation proposal … basically if I understood correctly this resource store write the file into the data dir streamed out from the DB if it does not exist, is that right?
The proposal is actually just focused on the introduction of the ResourceStore API (since this will involve an application wide refactor similar to when we updated FeatureCollection).
Separately the JDBC Config module is going to implement ResourceStore backed by a database - in the fashion you describe. If the code asks for a file it will be written out to the data directory. If the code only asks for an input stream we may be able to provide that right from the database.
···
In that case I see that you already spoken and taken into account the locking mechanism.
The email discussion has a resulted in a couple additions for the FileSystemResourceStore implementation: file watcher functionality, file lock and “atomic file write”.
Please correct me if I’m wrong, as I said I did not have the chance to study the examples.
I will be looking at file lock and file watching next, so you have not missed anything yet.
I am late to the party on this but +1 from me. I spent some time working with Jody on the approach and design so am familiar with it at a high level. Work is moving along great, good stuff Jody.
Some stupid questions, apologize but I do not have much time to see deeply the implementation proposal … basically if I understood correctly this resource store write the file into the data dir streamed out from the DB if it does not exist, is that right?
The proposal is actually just focused on the introduction of the ResourceStore API (since this will involve an application wide refactor similar to when we updated FeatureCollection).
Separately the JDBC Config module is going to implement ResourceStore backed by a database - in the fashion you describe. If the code asks for a file it will be written out to the data directory. If the code only asks for an input stream we may be able to provide that right from the database.
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
In that case I see that you already spoken and taken into account the locking mechanism.
The email discussion has a resulted in a couple additions for the FileSystemResourceStore implementation: file watcher functionality, file lock and “atomic file write”.
Please correct me if I’m wrong, as I said I did not have the chance to study the examples.
I will be looking at file lock and file watching next, so you have not missed anything yet.