[Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

GeoServer GeoServer Developer
1

Dear PSC,
recently I worked on making geofence modules stable and complete enough to be evaluated as official GeoServer extensions.

Currently I have updated the checklist here

https://github.com/geoserver/geoserver/wiki/GSIP-164

and pushed a set of PRs [1][2][3][4] resulting in the following code coverage results

image.png

image.png

[1] https://github.com/geoserver/geoserver/pull/3058
[2] https://github.com/geoserver/geoserver/pull/3052
[3] https://github.com/geoserver/geoserver/pull/3046
[4] https://github.com/geoserver/geoserver/pull/3024

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

2

Hi Alessio,

thanks for your work on the GSIP.
I will take a look to the PRs within today.

   Thanks,
   Emanuele

Alle 17:57:12 di Thursday 16 August 2018, Alessio Fabiani ha scritto:

Dear PSC,
recently I worked on making geofence modules stable and complete enough to
be evaluated as official GeoServer extensions.

Currently I have updated the checklist here

https://github.com/geoserver/geoserver/wiki/GSIP-164

and pushed a set of PRs [1][2][3][4] resulting in the following code
coverage results

[image: image.png]
[image: image.png]

[1] https://github.com/geoserver/geoserver/pull/3058
[2] https://github.com/geoserver/geoserver/pull/3052
[3] https://github.com/geoserver/geoserver/pull/3046
[4] https://github.com/geoserver/geoserver/pull/3024

--

Regards,
Emanuele Tajariol

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa
che ogni circostanza inerente alla presente email (il suo contenuto, gli
eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei
comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed
and may contain information that is privileged, confidential or otherwise
protected from disclosure. We remind that - as provided by European Regulation
2016/679 “GDPR” - copying, dissemination or use of this e-mail or the
information herein by anyone other than the intended recipient is prohibited.
If you have received this email by mistake, please notify us immediately by
telephone or e-mail.

3

The proposal wiki page still says 2.13. Are you targeting 2.14 or 2.15?

Also code coverage still seems pretty low for a security feature. Are you satisfied that the important parts have appropriate validation?

Brad

From: Alessio Fabiani <alessio.fabiani@anonymised.com…1268…>
Sent: Friday, 17 August 2018 1:57 AM
To: Geoserver-devel geoserver-devel@lists.sourceforge.net
Subject: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Dear PSC,

recently I worked on making geofence modules stable and complete enough to be evaluated as official GeoServer extensions.

Currently I have updated the checklist here

https://github.com/geoserver/geoserver/wiki/GSIP-164

and pushed a set of PRs [1][2][3][4] resulting in the following code coverage results

image.png

image.png

[1] https://github.com/geoserver/geoserver/pull/3058

[2] https://github.com/geoserver/geoserver/pull/3052

[3] https://github.com/geoserver/geoserver/pull/3046

[4] https://github.com/geoserver/geoserver/pull/3024

–

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

4

Hi Brad,
the test coverage requirements are indeed on the low side, maybe we should discuss a separate GSIP about increasing them.
But as far as rules go, Alessio’s proposal is within them.

Cheers
Andrea

(attachments)

image.png
image.png
image.png

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

5

I should have noted I already added my vote on the GSIP.

I was looking for Alessio’s opinion on the quality of the tests – test coverage (especially by line) isn’t the only thing that adds to value.

Brad

From: Andrea Aime andrea.aime@anonymised.com
Sent: Saturday, 25 August 2018 12:02 AM
To: Brad Hards bradh@anonymised.com
Cc: Alessio Fabiani alessio.fabiani@anonymised.com; Geoserver-devel geoserver-devel@anonymised.comsts.sourceforge.net
Subject: Re: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Hi Brad,

the test coverage requirements are indeed on the low side, maybe we should discuss a separate GSIP about increasing them.

But as far as rules go, Alessio’s proposal is within them.

Cheers

Andrea

On Sat, Aug 18, 2018 at 3:38 AM <bradh@anonymised.com> wrote:

The proposal wiki page still says 2.13. Are you targeting 2.14 or 2.15?

Also code coverage still seems pretty low for a security feature. Are you satisfied that the important parts have appropriate validation?

Brad

From: Alessio Fabiani <alessio.fabiani@anonymised.com>
Sent: Friday, 17 August 2018 1:57 AM
To: Geoserver-devel <geoserver-devel@lists.sourceforge.net>
Subject: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Dear PSC,

recently I worked on making geofence modules stable and complete enough to be evaluated as official GeoServer extensions.

Currently I have updated the checklist here

https://github.com/geoserver/geoserver/wiki/GSIP-164

and pushed a set of PRs [1][2][3][4] resulting in the following code coverage results

image.png

image.png

[1] https://github.com/geoserver/geoserver/pull/3058

[2] https://github.com/geoserver/geoserver/pull/3052

[3] https://github.com/geoserver/geoserver/pull/3046

[4] https://github.com/geoserver/geoserver/pull/3024

–

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

6

Dear all,
I agree that the test coverage might be indeed increased, nevertheless even if the percentage is not so high, notice that the core classes have a very good coverage.

As an instance the lower value (15%) on GeoFence module regards a package containing just POJOs used by the client to unmarshal instances through Spring Remoting. They are just plain classes representing some GeoFence objects ( org.geoserver.geofence.rest.xml).

On the other side most of the core classes have almost 100% coverage.

I would love (and for sure I will) add more tests on the rules and roles caching features and on the AuthenticationManager.

Until now the tests I have added should also cover:

  1. The load of the context from spring
  2. All the possible REST operations that can be done through the APIs
  3. Most of the operations that currently are possible via the WEB GUI

For sue something missing would be:

  1. More tests on the Limits filters by area
  2. Tests on the possibility of making specific attributes hidden/read-only/writable

Especially for those two, manual testing of course has been done successfully. Automatic testing should be added.

If you think that it would be better to add them at this stage, I can spend some more time before promoting the module, otherwise I can collect all those observations on some specific JIRAs.

Thoughts? Feedbacks?

Also @Emanuele Tajariol as the original author of the GSIP, what do you think about that?

Thanks everyone for dedicating time to this topic.

Alessio.

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

7

Alessio: thanks – that answers my question and allays my concerns. I am still +1 in any case.

Brad

From: Alessio Fabiani alessio.fabiani@anonymised.com
Sent: Friday, 31 August 2018 10:43 PM
To: Brad Hards bradh@anonymised.com; Emanuele Tajariol etj@anonymised.com
Cc: Andrea Aime andrea.aime@anonymised.com; Alessio Fabiani alessio.fabiani@anonymised.com; Geoserver-devel geoserver-devel@lists.sourceforge.net
Subject: Re: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Dear all,

I agree that the test coverage might be indeed increased, nevertheless even if the percentage is not so high, notice that the core classes have a very good coverage.

As an instance the lower value (15%) on GeoFence module regards a package containing just POJOs used by the client to unmarshal instances through Spring Remoting. They are just plain classes representing some GeoFence objects ( org.geoserver.geofence.rest.xml).

On the other side most of the core classes have almost 100% coverage.

I would love (and for sure I will) add more tests on the rules and roles caching features and on the AuthenticationManager.

Until now the tests I have added should also cover:

  1. The load of the context from spring

  2. All the possible REST operations that can be done through the APIs

  3. Most of the operations that currently are possible via the WEB GUI

For sue something missing would be:

  1. More tests on the Limits filters by area

  2. Tests on the possibility of making specific attributes hidden/read-only/writable

Especially for those two, manual testing of course has been done successfully. Automatic testing should be added.

If you think that it would be better to add them at this stage, I can spend some more time before promoting the module, otherwise I can collect all those observations on some specific JIRAs.

Thoughts? Feedbacks?

Also @Emanuele Tajariol as the original author of the GSIP, what do you think about that?

Thanks everyone for dedicating time to this topic.

Alessio.

Il giorno sab 25 ago 2018 alle ore 01:21 <bradh@anonymised.com> ha scritto:

I should have noted I already added my vote on the GSIP.

I was looking for Alessio’s opinion on the quality of the tests – test coverage (especially by line) isn’t the only thing that adds to value.

Brad

From: Andrea Aime <andrea.aime@anonymised.com>
Sent: Saturday, 25 August 2018 12:02 AM
To: Brad Hards <bradh@anonymised.com>
Cc: Alessio Fabiani <alessio.fabiani@anonymised.com>; Geoserver-devel <geoserver-devel@anonymised.comforge.net>
Subject: Re: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Hi Brad,

the test coverage requirements are indeed on the low side, maybe we should discuss a separate GSIP about increasing them.

But as far as rules go, Alessio’s proposal is within them.

Cheers

Andrea

On Sat, Aug 18, 2018 at 3:38 AM <bradh@anonymised.com> wrote:

The proposal wiki page still says 2.13. Are you targeting 2.14 or 2.15?

Also code coverage still seems pretty low for a security feature. Are you satisfied that the important parts have appropriate validation?

Brad

From: Alessio Fabiani <alessio.fabiani@anonymised.com>
Sent: Friday, 17 August 2018 1:57 AM
To: Geoserver-devel <geoserver-devel@lists.sourceforge.net>
Subject: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Dear PSC,

recently I worked on making geofence modules stable and complete enough to be evaluated as official GeoServer extensions.

Currently I have updated the checklist here

https://github.com/geoserver/geoserver/wiki/GSIP-164

and pushed a set of PRs [1][2][3][4] resulting in the following code coverage results

[1] https://github.com/geoserver/geoserver/pull/3058

[2] https://github.com/geoserver/geoserver/pull/3052

[3] https://github.com/geoserver/geoserver/pull/3046

[4] https://github.com/geoserver/geoserver/pull/3024

–

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@anonymised.comurceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

–

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

8

+1 with a gentle requirement to bump coverage to 60%

Regards,
Simone Giannecchini

GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
Con riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati
“GDPR”), si precisa che ogni circostanza inerente alla presente email
(il suo contenuto, gli eventuali allegati, etc.) è un dato la cui
conoscenza è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a
cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato
se potesse darmene notizia.

This email is intended only for the person or entity to which it is
addressed and may contain information that is privileged, confidential
or otherwise protected from disclosure. We remind that - as provided
by European Regulation 2016/679 “GDPR” - copying, dissemination or use
of this e-mail or the information herein by anyone other than the
intended recipient is prohibited. If you have received this email by
mistake, please notify us immediately by telephone or e-mail.

On Fri, Aug 31, 2018 at 11:44 PM <bradh@anonymised.com> wrote:

Alessio: thanks – that answers my question and allays my concerns. I am still +1 in any case.

Brad

From: Alessio Fabiani <alessio.fabiani@anonymised.com>
Sent: Friday, 31 August 2018 10:43 PM
To: Brad Hards <bradh@anonymised.com>; Emanuele Tajariol <etj@anonymised.com>
Cc: Andrea Aime <andrea.aime@anonymised.com>; Alessio Fabiani <alessio.fabiani@anonymised.com>; Geoserver-devel <geoserver-devel@lists.sourceforge.net>
Subject: Re: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Dear all,

I agree that the test coverage might be indeed increased, nevertheless even if the percentage is not so high, notice that the core classes have a very good coverage.

As an instance the lower value (15%) on GeoFence module regards a package containing just POJOs used by the client to unmarshal instances through Spring Remoting. They are just plain classes representing some GeoFence objects ( org.geoserver.geofence.rest.xml).

On the other side most of the core classes have almost 100% coverage.

I would love (and for sure I will) add more tests on the rules and roles caching features and on the AuthenticationManager.

Until now the tests I have added should also cover:

1. The load of the context from spring

2. All the possible REST operations that can be done through the APIs

3. Most of the operations that currently are possible via the WEB GUI

For sue something missing would be:

1. More tests on the Limits filters by area

2. Tests on the possibility of making specific attributes hidden/read-only/writable

Especially for those two, manual testing of course has been done successfully. Automatic testing should be added.

If you think that it would be better to add them at this stage, I can spend some more time before promoting the module, otherwise I can collect all those observations on some specific JIRAs.

Thoughts? Feedbacks?

Also @Emanuele Tajariol as the original author of the GSIP, what do you think about that?

Thanks everyone for dedicating time to this topic.

Alessio.

Il giorno sab 25 ago 2018 alle ore 01:21 <bradh@anonymised.com> ha scritto:

I should have noted I already added my vote on the GSIP.

I was looking for Alessio’s opinion on the quality of the tests – test coverage (especially by line) isn’t the only thing that adds to value.

Brad

From: Andrea Aime <andrea.aime@anonymised.com>
Sent: Saturday, 25 August 2018 12:02 AM
To: Brad Hards <bradh@anonymised.com>
Cc: Alessio Fabiani <alessio.fabiani@anonymised.com>; Geoserver-devel <geoserver-devel@lists.sourceforge.net>
Subject: Re: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Hi Brad,

the test coverage requirements are indeed on the low side, maybe we should discuss a separate GSIP about increasing them.

But as far as rules go, Alessio's proposal is within them.

Cheers

Andrea

On Sat, Aug 18, 2018 at 3:38 AM <bradh@anonymised.com> wrote:

The proposal wiki page still says 2.13. Are you targeting 2.14 or 2.15?

Also code coverage still seems pretty low for a security feature. Are you satisfied that the important parts have appropriate validation?

Brad

From: Alessio Fabiani <alessio.fabiani@anonymised.com>
Sent: Friday, 17 August 2018 1:57 AM
To: Geoserver-devel <geoserver-devel@lists.sourceforge.net>
Subject: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

Dear PSC,

recently I worked on making geofence modules stable and complete enough to be evaluated as official GeoServer extensions.

Currently I have updated the checklist here

https://github.com/geoserver/geoserver/wiki/GSIP-164

and pushed a set of PRs [1][2][3][4] resulting in the following code coverage results

[1] https://github.com/geoserver/geoserver/pull/3058

[2] https://github.com/geoserver/geoserver/pull/3052

[3] https://github.com/geoserver/geoserver/pull/3046

[4] https://github.com/geoserver/geoserver/pull/3024

--

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

--

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

9

Thanks Simone,
I opened a JIRA specific for that

https://osgeo-org.atlassian.net/browse/GEOS-8917

we have now 3 +1 and 1 +0 on this. Are those sufficient to proceed?

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

10

Errata corrige: 4 +1 and 1 +0

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

11

According to the rules at: http://docs.geoserver.org/latest/en/developer/policies/gsip.html#voting-on-a-gsip

  • At least 30% +1 votes (4 > 10 / 3, check)
  • A quorum of at least 50% +1”/”+0”/”0”/”-0” (5 is 50%, check)
  • No -1 votes (check)
    So yes, it’s passed

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

12

Thanks everyone,

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

13

just asking, did you update the doc as well?

Regards,
Simone Giannecchini

GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
Con riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati
“GDPR”), si precisa che ogni circostanza inerente alla presente email
(il suo contenuto, gli eventuali allegati, etc.) è un dato la cui
conoscenza è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a
cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato
se potesse darmene notizia.

This email is intended only for the person or entity to which it is
addressed and may contain information that is privileged, confidential
or otherwise protected from disclosure. We remind that - as provided
by European Regulation 2016/679 “GDPR” - copying, dissemination or use
of this e-mail or the information herein by anyone other than the
intended recipient is prohibited. If you have received this email by
mistake, please notify us immediately by telephone or e-mail.

On Wed, Sep 5, 2018 at 10:18 AM Alessio Fabiani
<alessio.fabiani@anonymised.com> wrote:

Thanks everyone,

* merged the related PR https://github.com/geoserver/geoserver/pull/3058
* updated the wiki page https://github.com/geoserver/geoserver/wiki/GSIP-164
* updated the proposal page https://github.com/geoserver/geoserver/wiki/Proposals

Il giorno mer 5 set 2018 alle ore 10:09 Andrea Aime <andrea.aime@anonymised.com..> ha scritto:

According to the rules at: http://docs.geoserver.org/latest/en/developer/policies/gsip.html#voting-on-a-gsip

At least 30% +1 votes (4 > 10 / 3, check)
A quorum of at least 50% +1”/”+0”/”0”/”-0” (5 is 50%, check)
No -1 votes (check)

So yes, it's passed

Cheers
Andrea

On Wed, Sep 5, 2018 at 10:05 AM Alessio Fabiani <alessio.fabiani@anonymised.com...> wrote:

Errata corrige: 4 +1 and 1 +0

Il giorno mer 5 set 2018 alle ore 10:03 Alessio Fabiani <alessio.fabiani@anonymised.com> ha scritto:

Thanks Simone,
I opened a JIRA specific for that

https://osgeo-org.atlassian.net/browse/GEOS-8917

we have now 3 +1 and 1 +0 on this. Are those sufficient to proceed?

Il giorno mer 5 set 2018 alle ore 09:59 Simone Giannecchini <simone.giannecchini@anonymised.com> ha scritto:

+1 with a gentle requirement to bump coverage to 60%

Regards,
Simone Giannecchini

GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
Con riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati
“GDPR”), si precisa che ogni circostanza inerente alla presente email
(il suo contenuto, gli eventuali allegati, etc.) è un dato la cui
conoscenza è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a
cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato
se potesse darmene notizia.

This email is intended only for the person or entity to which it is
addressed and may contain information that is privileged, confidential
or otherwise protected from disclosure. We remind that - as provided
by European Regulation 2016/679 “GDPR” - copying, dissemination or use
of this e-mail or the information herein by anyone other than the
intended recipient is prohibited. If you have received this email by
mistake, please notify us immediately by telephone or e-mail.

On Fri, Aug 31, 2018 at 11:44 PM <bradh@anonymised.com> wrote:
>
> Alessio: thanks – that answers my question and allays my concerns. I am still +1 in any case.
>
>
>
> Brad
>
>
>
> From: Alessio Fabiani <alessio.fabiani@anonymised.com>
> Sent: Friday, 31 August 2018 10:43 PM
> To: Brad Hards <bradh@anonymised.com>; Emanuele Tajariol <etj@anonymised.com.>
> Cc: Andrea Aime <andrea.aime@anonymised.com>; Alessio Fabiani <alessio.fabiani@anonymised.com>; Geoserver-devel <geoserver-devel@lists.sourceforge.net>
> Subject: Re: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules
>
>
>
> Dear all,
>
> I agree that the test coverage might be indeed increased, nevertheless even if the percentage is not so high, notice that the core classes have a very good coverage.
>
>
>
> As an instance the lower value (15%) on GeoFence module regards a package containing just POJOs used by the client to unmarshal instances through Spring Remoting. They are just plain classes representing some GeoFence objects ( org.geoserver.geofence.rest.xml).
>
>
>
> On the other side most of the core classes have almost 100% coverage.
>
>
>
> I would love (and for sure I will) add more tests on the rules and roles caching features and on the AuthenticationManager.
>
>
>
> Until now the tests I have added should also cover:
>
>
>
> 1. The load of the context from spring
>
> 2. All the possible REST operations that can be done through the APIs
>
> 3. Most of the operations that currently are possible via the WEB GUI
>
>
>
> For sue something missing would be:
>
>
>
> 1. More tests on the Limits filters by area
>
> 2. Tests on the possibility of making specific attributes hidden/read-only/writable
>
>
>
> Especially for those two, manual testing of course has been done successfully. Automatic testing should be added.
>
>
>
> If you think that it would be better to add them at this stage, I can spend some more time before promoting the module, otherwise I can collect all those observations on some specific JIRAs.
>
>
>
> Thoughts? Feedbacks?
>
>
>
> Also @Emanuele Tajariol as the original author of the GSIP, what do you think about that?
>
>
>
> Thanks everyone for dedicating time to this topic.
>
>
>
> Alessio.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Il giorno sab 25 ago 2018 alle ore 01:21 <bradh@anonymised.com> ha scritto:
>
> I should have noted I already added my vote on the GSIP.
>
>
>
> I was looking for Alessio’s opinion on the quality of the tests – test coverage (especially by line) isn’t the only thing that adds to value.
>
>
>
> Brad
>
>
>
> From: Andrea Aime <andrea.aime@anonymised.com>
> Sent: Saturday, 25 August 2018 12:02 AM
> To: Brad Hards <bradh@anonymised.com>
> Cc: Alessio Fabiani <alessio.fabiani@anonymised.com>; Geoserver-devel <geoserver-devel@lists.sourceforge.net>
> Subject: Re: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules
>
>
>
> Hi Brad,
>
> the test coverage requirements are indeed on the low side, maybe we should discuss a separate GSIP about increasing them.
>
> But as far as rules go, Alessio's proposal is within them.
>
>
>
> Cheers
>
> Andrea
>
>
>
> On Sat, Aug 18, 2018 at 3:38 AM <bradh@anonymised.com> wrote:
>
> The proposal wiki page still says 2.13. Are you targeting 2.14 or 2.15?
>
>
>
> Also code coverage still seems pretty low for a security feature. Are you satisfied that the important parts have appropriate validation?
>
>
>
> Brad
>
>
>
> From: Alessio Fabiani <alessio.fabiani@anonymised.com>
> Sent: Friday, 17 August 2018 1:57 AM
> To: Geoserver-devel <geoserver-devel@lists.sourceforge.net>
> Subject: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules
>
>
>
> Dear PSC,
>
> recently I worked on making geofence modules stable and complete enough to be evaluated as official GeoServer extensions.
>
>
>
> Currently I have updated the checklist here
>
>
>
> https://github.com/geoserver/geoserver/wiki/GSIP-164
>
>
>
> and pushed a set of PRs [1][2][3][4] resulting in the following code coverage results
>
>
>
>
>
> [1] https://github.com/geoserver/geoserver/pull/3058
>
> [2] https://github.com/geoserver/geoserver/pull/3052
>
> [3] https://github.com/geoserver/geoserver/pull/3046
>
> [4] https://github.com/geoserver/geoserver/pull/3024
>
>
>
> --
>
> ==
>
> GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.
> ==
> Ing. Alessio Fabiani
>
> @alfa7691
> Founder/Technical Lead
>
>
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 331 6233686
>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
> -------------------------------------------------------
>
> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>
>
> This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
>
>
> --
>
> Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
>
>
>
>
> --
>
> ==
>
> GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.
> ==
> Ing. Alessio Fabiani
>
> @alfa7691
> Founder/Technical Lead
>
>
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 331 6233686
>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
> -------------------------------------------------------
>
> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>
>
> This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

--

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

--

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

--

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

14

Yeps

https://github.com/geoserver/geoserver/pull/3087

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

15

It seems like we have a blocker.

The PR [1] that physically moves the geofence modules to extensions fails on AppVeyor since it is not able to delete the geofence .db files.

I will need to figure out how to fix this somehow. If someone has some hints on this, please send to me.

Thanks,
Alessio.

[1] - https://github.com/geoserver/geoserver/pull/3087

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

16

Hi Alessio,
are those H2 databases? Please make sure that they are all properly closed before the test enters shutdown.

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.