[Geoserver-devel] GSIP 175 - Promote status monitoring module from Community to Extension

GeoServer GeoServer Developer
1

Dear all, Project Steering Committee,

I would like to promote the Status Monitoring community to an official extension, I wrote a GSIP here:
https://github.com/geoserver/geoserver/wiki/GSIP-175

Please let me know if I missed something.

Kind regards,
Nuno Oliveira

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the
experts! 
Visit http://goo.gl/it488V for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati 
personali (Reg. UE 2016/679 - Regolamento generale sulla 
protezione dei dati “GDPR”), si precisa che ogni 
circostanza inerente alla presente email (il suo contenuto, 
gli eventuali allegati, etc.) è un dato la cui conoscenza 
è riservata al/i solo/i destinatario/i indicati dallo 
scrivente. Se il messaggio Le è giunto per errore, è 
tenuta/o a cancellarlo, ogni altra operazione è illecita. 
Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to 
which it is addressed and may contain information that 
is privileged, confidential or otherwise protected from 
disclosure. We remind that - as provided by European 
Regulation 2016/679 “GDPR” - copying, dissemination or 
use of this e-mail or the information herein by anyone 
other than the intended recipient is prohibited. If you 
have received this email by mistake, please notify 
us immediately by telephone or e-mail.
2

That looks useful, tab for “module” status was intended to capture some of this information as well but was never followed up on.

  1. status monitoring extension
  • I find the “service monitoring” name a bit confusing given the monitoring extension, would it be more appropriate to call it “environment” or “system environment” extension?
  • could consider taking this functionality into core rather than as an extension?
  • does the REST API just provide a snapshot? Or access prior history (would it be appropriate to integrate this into the existing monitoring extension)

  1. usage/stability
    Yeah it is hard to show production use, let’s take its creation in 2017 and continued development as evidence of stability :slight_smile:

  2. active/maintainer
    thanks

  3. stable
    I have no direct experience, module has not broken the build…

  4. coverage

  5. no ip violations

  • we need to reword this to be a check of dependencies/headers/code donation.
  • pom.xml does not list you as maintainer / contact point (aside: will need to set up jira component for this as a new extension)
  • license of OSHI changed from EPL (copyleft) to MIT (permissive) recently - what version are we using?
  • very limited internationalization, think this needs to be fixed up? We do not have a checklist for coding standards …
  • no surprises going through the rest of it …
  1. page in user manual
  1. contributor agreement
···

–
Jody Garnett

3

Hi Jody,
thank you for the detailed and complete feedback, I will get back to it in the upcoming days.

Thank you!

···

–
Jody Garnett

4

Hi Jody,
my apologies for the feedback delay, please find my answers bellow:

That looks useful, tab for “module” status was intended to capture some of this information as well but was never followed up on.

  1. status monitoring extension
  • I find the “service monitoring” name a bit confusing given the monitoring extension, would it be more appropriate to call it “environment” or “system environment” extension?

The name of the module is ‘status-monitoring’, but I’m all open to new ideas, but I think the term monitoring should be part of the name, since it allow us to monitor the system status, well if its become core this should not be a problem anymore.

  • could consider taking this functionality into core rather than as an extension?

Works for me, this module doesn’t do anything unless the ‘Monitoring’ tab is accessed, in the future if the functionality is extend to include a small historic \ graphs then we will to give the option to the admin to deactivate the metrics collectors.

Is true that this module is frequently (always?) installed in most GeoServer I have installed recently, I will reword the proposal to make it core, unless someone objects.

  • does the REST API just provide a snapshot? Or access prior history (would it be appropriate to integrate this into the existing monitoring extension)+

Currently only snapshot, but history \ graphs is nice future that we may have in the future :slight_smile:

Regarding the monitoring extension, IMHO that extension should have been named ‘Auditing’, since it registers only the calls (unless I miss something) that hit the system and doesn’t record internal execution details. But yes, adding system information to the requests auditing information could be interesting.

  1. usage/stability
    Yeah it is hard to show production use, let’s take its creation in 2017 and continued development as evidence of stability :slight_smile:

:slight_smile:

  1. active/maintainer
    thanks

  2. stable
    I have no direct experience, module has not broken the build…

  3. coverage

  4. no ip violations

  • we need to reword this to be a check of dependencies/headers/code donation.
  • pom.xml does not list you as maintainer / contact point (aside: will need to set up jira component for this as a new extension)

I will fix that in my next update.

  • license of OSHI changed from EPL (copyleft) to MIT (permissive) recently - what version are we using?

The PR has been updated to upgrade to the very last version, which is released under MTI License.

  • very limited internationalization, think this needs to be fixed up? We do not have a checklist for coding standards …

Implementation of internationalization support in progress, PR already updated with a first attempt.

  • no surprises going through the rest of it …
  1. page in user manual

Good point, it will be fixed.

  1. contributor agreement

I will check this with my employer, I don’t think it will be against it :stuck_out_tongue:

···

Regards,
Nuno Oliveira

GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati
personali (Reg. UE 2016/679 - Regolamento generale sulla
protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto,
gli eventuali allegati, etc.) è un dato la cui conoscenza
è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è
tenuta/o a cancellarlo, ogni altra operazione è illecita.
Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to
which it is addressed and may contain information that
is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European
Regulation 2016/679 “GDPR” - copying, dissemination or
use of this e-mail or the information herein by anyone
other than the intended recipient is prohibited. If you
have received this email by mistake, please notify
us immediately by telephone or e-mail.

5

Btw my +1 no this. We are successfully using this module since a long time on the GeoNode project too.

···

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

6

Hum… core directly? I did not see that coming.
But If that’s the case, a simple way to solve the naming problem, is not to name it, and spread its classes
in gs-main, gs-restconfig and gs-web-core instead

Just thinking out loud :smiley:

Of course, there is a downside of going this direction… it makes proposing a backport harder, I think it’s the
first time a module goes straight from community to core (actually, the first time anything in extension or community
goes in core, in a very long long time).
That said, the module is really a handful of classes and I know first hand it has been added to a lot of
installations so far so… no objection.

Cheers
Andrea

···

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

7

Thank you all for the feedback, answering the open points:

  • regarding the naming:

  • what do you think about renaming it to system-status?

  • regarding the promotion to core, I would suggest the following steps:

  • promote to extension in 2.15.x

  • promote to core in master (2.16.x)

Do we have a enough information to start a vote? if yes I will kindly ask you to vote on this GISP :slight_smile:

···

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

8

+1

Regards,
Simone Giannecchini

GeoServer Professional Services from the experts!
Visit http://bit.ly/gs-services for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
Con riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati
“GDPR”), si precisa che ogni circostanza inerente alla presente email
(il suo contenuto, gli eventuali allegati, etc.) è un dato la cui
conoscenza è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a
cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato
se potesse darmene notizia.

This email is intended only for the person or entity to which it is
addressed and may contain information that is privileged, confidential
or otherwise protected from disclosure. We remind that - as provided
by European Regulation 2016/679 “GDPR” - copying, dissemination or use
of this e-mail or the information herein by anyone other than the
intended recipient is prohibited. If you have received this email by
mistake, please notify us immediately by telephone or e-mail.

On Wed, Jul 10, 2019 at 10:53 AM Nuno Oliveira
<nuno.oliveira@anonymised.com> wrote:

Thank you all for the feedback, answering the open points:

regarding the naming:

what do you think about renaming it to system-status?

regarding the promotion to core, I would suggest the following steps:

promote to extension in 2.15.x
promote to core in master (2.16.x)

Do we have a enough information to start a vote? if yes I will kindly ask you to vote on this GISP :slight_smile:

On Wed, 2019-07-10 at 10:00 +0200, Andrea Aime wrote:

On Wed, Jul 10, 2019 at 1:23 AM Nuno Oliveira GeoSolutions <nuno.oliveira@anonymised.com> wrote:

- could consider taking this functionality into core rather than as an extension?

Works for me, this module doesn't do anything unless the 'Monitoring' tab is accessed, in the future if the functionality is extend to include a small historic \ graphs then we will to give the option to the admin to deactivate the metrics collectors.

Hum... core directly? I did not see that coming.
But If that's the case, a simple way to solve the naming problem, is not to name it, and spread its classes
in gs-main, gs-restconfig and gs-web-core instead

Just thinking out loud :smiley:

Of course, there is a downside of going this direction... it makes proposing a backport harder, I think it's the
first time a module goes straight from community to core (actually, the first time anything in extension or community
goes in core, in a very long long time).
That said, the module is really a handful of classes and I know first hand it has been added to a lot of
installations so far so... no objection.

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

--
Regards,
Nuno Oliveira

GeoServer Professional Services from the
experts!
Visit http://goo.gl/it488V for more information.

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati
personali (Reg. UE 2016/679 - Regolamento generale sulla
protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto,
gli eventuali allegati, etc.) è un dato la cui conoscenza
è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è
tenuta/o a cancellarlo, ogni altra operazione è illecita.
Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to
which it is addressed and may contain information that
is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European
Regulation 2016/679 “GDPR” - copying, dissemination or
use of this e-mail or the information herein by anyone
other than the intended recipient is prohibited. If you
have received this email by mistake, please notify
us immediately by telephone or e-mail.

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

9

+1 and thanks for the legwork on this :slight_smile:

···

–
Jody Garnett

10

Hi all,

I have a proposal for integrate promoted system-status module code into Geoserver core on master:

Relocate System status logic classes:
Rename package org.geoserver.status.monitoring.collector to org.geoserger.systemstatus
Put it in gs-main module.

Relocate Web classes:
Rename package org.geoserver.status.monitoring.web to org.geoserver.web.systemstatus
Put it in gs-web-core module.

Relocate Rest classes:
rename package org.geoserver.status.monitoring.rest to org.geoserver.rest.systemstatus
Put it in gs-restconfig module.

What do you think about?

Regards,

Fernando Mino

···

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

11

Those activities sound fine, may also need to move some documentation around also?

I have made sure to add my +1 to the proposal.

···

–
Jody Garnett

12

Dear all, Jody,
thank you for the feedback!

We have implemented the feedback we got in this two PRs:

Summarizing the feedback that was applied:

  • migrated to the latest version of OSHI, MIT License
  • renamed the module to system-status
  • added internationalization support
  • added swagger documentation for the REST API
  • make it core in 2.16.x
  • documentation moved to configuration status [1]- make it an extension to 2.15.x

Please let’s us know if we missed anything.

Kind regards,
Nuno Oliveira

[1] https://docs.geoserver.org/stable/en/user/configuration/status.html

···

–
Jody Garnett

13

Dear PSC,

I would kindly ask you if you can vote on this one, proposal link for reference:
https://github.com/geoserver/geoserver/wiki/GSIP-175

Thank you!

···

–
Jody Garnett

14

+1

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

15

+1

Regards,
Simone Giannecchini

GeoServer Professional Services from the experts!
Visit http://bit.ly/gs-services for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

On Mon, Aug 5, 2019 at 11:35 AM Nuno Oliveira <nuno.oliveira@anonymised.com> wrote:

Dear PSC,

I would kindly ask you if you can vote on this one, proposal link for reference:
https://github.com/geoserver/geoserver/wiki/GSIP-175

Thank you!

On Wed, 2019-07-31 at 09:03 +0100, Nuno Oliveira wrote:

Dear all, Jody,
thank you for the feedback!

We have implemented the feedback we got in this two PRs:

Summarizing the feedback that was applied:

  • migrated to the latest version of OSHI, MIT License
  • renamed the module to system-status
  • added internationalization support
  • added swagger documentation for the REST API
  • make it core in 2.16.x
  • documentation moved to configuration status [1]- make it an extension to 2.15.x

Please let’s us know if we missed anything.

Kind regards,
Nuno Oliveira

[1] https://docs.geoserver.org/stable/en/user/configuration/status.html

On Thu, 2019-07-25 at 17:27 -0700, Jody Garnett wrote:

Those activities sound fine, may also need to move some documentation around also?

I have made sure to add my +1 to the proposal.

–
Jody Garnett

On Thu, 25 Jul 2019 at 11:04, fernando.mino@anonymised.com <fernando.mino@anonymised.com> wrote:

Hi all,

I have a proposal for integrate promoted system-status module code into Geoserver core on master:

Relocate System status logic classes:
Rename package org.geoserver.status.monitoring.collector to org.geoserger.systemstatus
Put it in gs-main module.

Relocate Web classes:
Rename package org.geoserver.status.monitoring.web to org.geoserver.web.systemstatus
Put it in gs-web-core module.

Relocate Rest classes:
rename package org.geoserver.status.monitoring.rest to org.geoserver.rest.systemstatus
Put it in gs-restconfig module.

What do you think about?

Regards,

Fernando Mino

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

==

Fernando Mino

Software Engineer

GeoSolutions S.A.S.

Via di Montramito 3/A

55054 Massarosa (LU)

Italy

phone: +39 0584 962313

fax: +39 0584 1660272

http://www.geo-solutions.it

http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

From “Nuno Oliveira” nuno.oliveira@anonymised.com
To andrea.aime@anonymised.com
Cc “geoserver-devel” geoserver-devel@anonymised.comeforge.net
Date Wed, 10 Jul 2019 09:53:02 +0100
Subject Re: [Geoserver-devel] GSIP 175 - Promote status monitoring module from Community to Extension


Thank you all for the feedback, answering the open points:


- regarding the naming:
- what do you think about renaming it to system-status?


- regarding the promotion to core, I would suggest the following steps:
- promote to extension in 2.15.x
- promote to core in master (2.16.x)


Do we have a enough information to start a vote? if yes I will kindly ask you to vote on this GISP :slight_smile:


On Wed, 2019-07-10 at 10:00 +0200, Andrea Aime wrote:


> On Wed, Jul 10, 2019 at 1:23 AM Nuno Oliveira GeoSolutions <nuno.oliveira@anonymised.com> wrote:
>
> > > - could consider taking this functionality into core rather than as an extension?
> >
> > Works for me, this module doesn’t do anything unless the ‘Monitoring’ tab is accessed, in the future if the functionality is extend to include a small historic \ graphs then we will to give the option to the admin to deactivate the metrics collectors.
>
> Hum… core directly? I did not see that coming.
> But If that’s the case, a simple way to solve the naming problem, is not to name it, and spread its classes
> in gs-main, gs-restconfig and gs-web-core instead
>
> Just thinking out loud :smiley:
>
> Of course, there is a downside of going this direction… it makes proposing a backport harder, I think it’s the
> first time a module goes straight from community to core (actually, the first time anything in extension or community
> goes in core, in a very long long time).
> That said, the module is really a handful of classes and I know first hand it has been added to a lot of
> installations so far so… no objection.
>
> Cheers
> Andrea
>
> ==
>
> GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.



<br>-- <br>Regards,<br>Nuno Oliveira<br>==<br>GeoServer Professional Services from the<br>experts! <br>Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.<br>==<br><br>Nuno Miguel Carvalho Oliveira<br>@nmcoliveira<br>Software Engineer<br><br>GeoSolutions S.A.S.<br>Via di Montramito 3/A<br>55054 Massarosa (LU)<br>Italy<br>phone: +39 0584 962313<br>fax: +39 0584 1660272<br><br>[http://www.geo-solutions.it](http://www.geo-solutions.it)<br>[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)<br><br>-------------------------------------------------------<br><br>Con riferimento alla normativa sul trattamento dei dati <br>personali (Reg. UE 2016/679 - Regolamento generale sulla <br>protezione dei dati “GDPR”), si precisa che ogni <br>circostanza inerente alla presente email (il suo contenuto, <br>gli eventuali allegati, etc.) è un dato la cui conoscenza <br>è riservata al/i solo/i destinatario/i indicati dallo <br>scrivente. Se il messaggio Le è giunto per errore, è <br>tenuta/o a cancellarlo, ogni altra operazione è illecita. <br>Le sarei comunque grato se potesse darmene notizia.<br><br>This email is intended only for the person or entity to <br>which it is addressed and may contain information that <br>is privileged, confidential or otherwise protected from <br>disclosure. We remind that - as provided by European <br>Regulation 2016/679 “GDPR” - copying, dissemination or <br>use of this e-mail or the information herein by anyone <br>other than the intended recipient is prohibited. If you <br>have received this email by mistake, please notify <br>us immediately by telephone or e-mail.<br>

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the
experts! 
Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati 
personali (Reg. UE 2016/679 - Regolamento generale sulla 
protezione dei dati “GDPR”), si precisa che ogni 
circostanza inerente alla presente email (il suo contenuto, 
gli eventuali allegati, etc.) è un dato la cui conoscenza 
è riservata al/i solo/i destinatario/i indicati dallo 
scrivente. Se il messaggio Le è giunto per errore, è 
tenuta/o a cancellarlo, ogni altra operazione è illecita. 
Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to 
which it is addressed and may contain information that 
is privileged, confidential or otherwise protected from 
disclosure. We remind that - as provided by European 
Regulation 2016/679 “GDPR” - copying, dissemination or 
use of this e-mail or the information herein by anyone 
other than the intended recipient is prohibited. If you 
have received this email by mistake, please notify 
us immediately by telephone or e-mail.

_______________________________________________
Geoserver-devel mailing list
[Geoserver-devel@lists.sourceforge.net](mailto:Geoserver-devel@lists.sourceforge.net)
[https://lists.sourceforge.net/lists/listinfo/geoserver-devel](https://lists.sourceforge.net/lists/listinfo/geoserver-devel)


-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the
experts! 
Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati 
personali (Reg. UE 2016/679 - Regolamento generale sulla 
protezione dei dati “GDPR”), si precisa che ogni 
circostanza inerente alla presente email (il suo contenuto, 
gli eventuali allegati, etc.) è un dato la cui conoscenza 
è riservata al/i solo/i destinatario/i indicati dallo 
scrivente. Se il messaggio Le è giunto per errore, è 
tenuta/o a cancellarlo, ogni altra operazione è illecita. 
Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to 
which it is addressed and may contain information that 
is privileged, confidential or otherwise protected from 
disclosure. We remind that - as provided by European 
Regulation 2016/679 “GDPR” - copying, dissemination or 
use of this e-mail or the information herein by anyone 
other than the intended recipient is prohibited. If you 
have received this email by mistake, please notify 
us immediately by telephone or e-mail.

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

16

+1

Ian

···

Ian Turton