So the background motivation is that “this sometimes limits contributions the project can accept” and the price to pay is possibly opening a can of worms in terms of revisions and acceptance of pull requests.
I don’t see the can of worms, just a minor annoyance. The modules without CLA would be few and well marked (moving classes between extensions/community is not very common,
they tend to migrate to the center, towards core, but that’s easy to spot).
Wonder, are there any precedents for contributions that couldn’t be accepted due to lack of a singed CLA? How were they resolved?
Easy, PRs were closed, code did not make it in. GeoTools has two PRs blocked on that too, ElasticSearch and the ArcGIS TPK format reader.
The former is likely going to just die if we don’t relax rules, the latter has already been stuck for months with no sign of going forward.
GeoServer wise, the old GSR module would be a candidate for integration under the relaxed rules, we have been waiting Planet to sign a CLA for it for well over six months (and bit rotting in the meantime).
I’m under the impression, and this might be just me, that the project is already too permissive to incorporate content to its codebase under the community modules space. That might have been nice in the svn days, but with git anyone can have their unsupported geoserver plugins elsewhere and still publicly accessible and ready to merge. Or maybe a separate repository could be used for “community” modules? This is just a thought from the perspective that sometimes less is more, and I personally would like the codebase to be as succinct as possible maybe with just the stuff that is “ok”, and think about other alternatives for pure RnD, possibly drop and forget contributions.
Strongly disagree on having separate repos, that is a recipe for disaster. Just look at the recent module graduations, and the ones in process, like MBStyles, web resource, SLDService, authkey.
Had they been kept in separate repositories, they would have bit rotten to the point of making recovery a difficult task (they all have been in the codebase several years before graduation).
Keeping in here ensures that at least they compile and receive the basic automated refactors during large code sprints.
Others might think differently, but not having a community space would increase both friction for those interested in donating code and those trying to contribute small improvements to it.
Without it, donating and keeping new code that I’m not sure would going to make into extensions or core would become just too hard… and it’s something we do on a regular basis, an important part of our activity in the project.
Some modules stick, other die, that’s life, but the community space makes its handling manageable.
Regards,
···
Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.