[Geoserver-devel] GSIP-213 CSS Cleanup - Checking status ahead of 2.22-RC

Michel:

I took an action item in today’s meeting to check in with you on GSIP-213. We saw that there has been some progress made recently and wished to ask if we can get this in for the 2.22.0 release? Or if there is still too much work to be done?

My understanding is you are done with the core application and are working on extensions and community modules - so really close and not the kind of pull-request that wants to sit on a shelf for fear of rework.

Checking https://github.com/geoserver/geoserver/pull/5984

  • src/community/backup-restore

  • src/community/feature-templating

  • src/community/ogcapi/ogcapi-maps

  • src/extensions/authkey

  • src/extensions/geofence-server

  • src/extensions/geofense

  • src/extensions/importer

  • src/extensions/inspire

  • src/extensions/mapml

  • src/extensions/metadata

  • src/extensions/monitor

  • src/extensions/netcdf

  • src/extensions/params-extractor

  • src/extensions/web-resource

  • src/extensions/wps/web-wps

  • src/web/core

  • src/web/demo

  • src/web/gwc

  • src/web/security/core

  • src/web/security/jdbc

  • src/web/security/ldap

  • src/web/wcs

  • src/web/wfs

  • src/web/wms

  • src/wms - OpenLayers2MapTemplate.ftl

From today’s meeting/discussion:

  1. required: src/web/* - some of the GeoServerHomePage.html will be in conflict; but since you helped me troubleshoot css here I trust it will not be such a problem.
  2. required: src/extensions/* -
  3. optional: src/community/* - this is a nice to have, as long as the existing content is not terribly broken we should be okay. Community module authors have your PR and soon a developer’s guide page as a migration guide.
  4. optional: doc/en/developer - Update wicket guide with some css guidance as a separate PR for the 2.22.0 release?

I am willing to make a 2.22-RC2 with the geoserver.css change if you are close to completing the above?


Jody Garnett

Hi All,

A small message on the progress of the CSS cleanup:

• All files in ‘web’ have been checked and cleaned
• All layouting with list elements (`<ul>` and `<li>`) has been changed
• Last push contained the cleanup of all extensions

In progress:

• Writing of documentation

Still todo:

• Rebase in order to get the changes to the homepage
• Cleanup of community models (at a later stage?)

I don’t know if it’s up to me to decide if it good enough for the `2.22.0` release, but I cleaned everything as best as I could and I think it’s ready (for testing).

Kind regards,
Michel Gabriël
On 27 Sep 2022, 21:48 +0200, Jody Garnett <jody.garnett@anonymised.com>, wrote:

Michel:

I took an action item in today's meeting to check in with you on GSIP-213. We saw that there has been some progress made recently and wished to ask if we can get this in for the 2.22.0 release? Or if there is still too much work to be done?

My understanding is you are done with the core application and are working on extensions and community modules - so really close and not the kind of pull-request that wants to sit on a shelf for fear of rework.

Checking https://github.com/geoserver/geoserver/pull/5984

- src/community/backup-restore
- src/community/feature-templating
- src/community/ogcapi/ogcapi-maps
- src/extensions/authkey
- src/extensions/geofence-server
- src/extensions/geofense
- src/extensions/importer
- src/extensions/inspire
- src/extensions/mapml
- src/extensions/metadata
- src/extensions/monitor
- src/extensions/netcdf
- src/extensions/params-extractor
- src/extensions/web-resource
- src/extensions/wps/web-wps
- src/web/core
- src/web/demo
- src/web/gwc
- src/web/security/core
- src/web/security/jdbc
- src/web/security/ldap
- src/web/wcs
- src/web/wfs
- src/web/wms
- src/wms - OpenLayers2MapTemplate.ftl

From today's meeting/discussion:

1. required: src/web/* - some of the GeoServerHomePage.html will be in conflict; but since you helped me troubleshoot css here I trust it will not be such a problem.
2. required: src/extensions/* -
3. optional: src/community/* - this is a nice to have, as long as the existing content is not terribly broken we should be okay. Community module authors have your PR and soon a developer's guide page as a migration guide.
4. optional: doc/en/developer - Update wicket guide with some css guidance as a separate PR for the 2.22.0 release?

I am willing to make a 2.22-RC2 with the geoserver.css change if you are close to completing the above?
--
Jody Garnett

On Wed, Sep 28, 2022 at 12:50 PM Michel Gabriel via Geoserver-devel <
geoserver-devel@lists.sourceforge.net> wrote:

   - Rebase in order to get the changes to the homepage
   - Cleanup of community models (at a later stage?)

I don’t know if it’s up to me to decide if it good enough for the `2.22.0`
release, but I cleaned everything as best as I could and I think it’s ready
(for testing).

The PR is currently still marked as "draft" and has conflicts that predate
the home page landing.
So if you want some tests and checks in the PRt the first thing would be to
address the conflicts and switch the PR status to "ready for review"

Cheers
Andrea

==

GeoServer Professional Services from the experts!

Visit http://bit.ly/gs-services-us for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions Group
phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 339 8844549

https://www.geosolutionsgroup.com/

http://twitter.com/geosolutions_it

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
precisa che ogni circostanza inerente alla presente email (il suo
contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is
addressed and may contain information that is privileged, confidential or
otherwise protected from disclosure. We remind that - as provided by
European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
e-mail or the information herein by anyone other than the intended
recipient is prohibited. If you have received this email by mistake, please
notify us immediately by telephone or e-mail