[Geoserver-devel] GSIP 49, WMS module cleanup and refactoring

Hi all,

I have been working on the long awaited WMS module clean up in an effort
to finally port it to the Dispatcher architecture, and during the FOSS4G
code sprint we (Andrea, Justin and myself) have been through a code
review.

Here's the proposal: <http://geoserver.org/display/GEOS/GSIP+49+-+WMS
+module+cleanup+and+refactoring>

And here where the work is taking place:
<http://github.com/groldan/geoserver_trunk/tree/wmscleanup&gt;

Please feel free to comment out on any issue/concern you might find with
it. The pending issues we identified during the code review are already
listed on the proposal. I would like to commit to trunk once all those
concerns are taken care of.

Best regards,
Gabriel

--
Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers

Looks like a great idea. Looking at the review they look like issues
worth addressing - particularly CITE testing and docs :slight_smile:

So, you can have a preliminary +1 once those issues are addressed.

One other question - and I may be behind the times here and its
already there - is there a hook in the architecture to cache
responses? - if we have a WFS service backending a WMS it would be
relatively expensive to fetch and render, and especially in a tiled
environment a high degree of opportunity to cache.

Rob

On Thu, Sep 16, 2010 at 8:57 AM, Gabriel Roldán <groldan@anonymised.com> wrote:

Hi all,

I have been working on the long awaited WMS module clean up in an effort
to finally port it to the Dispatcher architecture, and during the FOSS4G
code sprint we (Andrea, Justin and myself) have been through a code
review.

Here's the proposal: <http://geoserver.org/display/GEOS/GSIP+49+-+WMS
+module+cleanup+and+refactoring>

And here where the work is taking place:
<http://github.com/groldan/geoserver_trunk/tree/wmscleanup&gt;

Please feel free to comment out on any issue/concern you might find with
it. The pending issues we identified during the code review are already
listed on the proposal. I would like to commit to trunk once all those
concerns are taken care of.

Best regards,
Gabriel

--
Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

A community +1. Andrea and I reviewed the work in detail and it was a very nice cleanup. Very clean. Nice work gabriel.

On Wed, Sep 15, 2010 at 4:57 PM, Gabriel Roldán <groldan@anonymised.com> wrote:

Hi all,

I have been working on the long awaited WMS module clean up in an effort
to finally port it to the Dispatcher architecture, and during the FOSS4G
code sprint we (Andrea, Justin and myself) have been through a code
review.

Here’s the proposal: <http://geoserver.org/display/GEOS/GSIP+49±+WMS
+module+cleanup+and+refactoring>

And here where the work is taking place:
<http://github.com/groldan/geoserver_trunk/tree/wmscleanup>

Please feel free to comment out on any issue/concern you might find with
it. The pending issues we identified during the code review are already
listed on the proposal. I would like to commit to trunk once all those
concerns are taken care of.

Best regards,
Gabriel


Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers


Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

On 16/09/2010 00:57, Gabriel Roldán wrote:

Hi all,

I have been working on the long awaited WMS module clean up in an effort
to finally port it to the Dispatcher architecture, and during the FOSS4G
code sprint we (Andrea, Justin and myself) have been through a code
review.

Here's the proposal:<http://geoserver.org/display/GEOS/GSIP+49+-+WMS
+module+cleanup+and+refactoring>

And here where the work is taking place:
<http://github.com/groldan/geoserver_trunk/tree/wmscleanup&gt;

Please feel free to comment out on any issue/concern you might find with
it. The pending issues we identified during the code review are already
listed on the proposal. I would like to commit to trunk once all those
concerns are taken care of.

Yup, very much looking forward to this one :slight_smile:
+1

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

Hello again,

all the concerns in the proposal have been addressed, including CITE
testing, and hence I would like to call for review and voting as
appropriate.

Already updated the page with the votes given in the mailing list.
Here's the proposal page again: <http://geoserver.org/display/GEOS/GSIP
+49+-+WMS+module+cleanup+and+refactoring>

I would specially like to hear from Simone/Alessio as they might be
doing some WMS related development so this would be the time to raise
any further concern.

Waiting for your feedback,

Gabriel.

On Thu, 2010-09-16 at 19:56 +0200, Andrea Aime wrote:

On 16/09/2010 00:57, Gabriel Roldán wrote:
> Hi all,
>
> I have been working on the long awaited WMS module clean up in an effort
> to finally port it to the Dispatcher architecture, and during the FOSS4G
> code sprint we (Andrea, Justin and myself) have been through a code
> review.
>
> Here's the proposal:<http://geoserver.org/display/GEOS/GSIP+49+-+WMS
> +module+cleanup+and+refactoring>
>
> And here where the work is taking place:
> <http://github.com/groldan/geoserver_trunk/tree/wmscleanup&gt;
>
> Please feel free to comment out on any issue/concern you might find with
> it. The pending issues we identified during the code review are already
> listed on the proposal. I would like to commit to trunk once all those
> concerns are taken care of.

Yup, very much looking forward to this one :slight_smile:
+1

Cheers
Andrea

--
Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers

A solid +1 from me.

On 19/09/10 09:28, Gabriel Roldán wrote:

Hello again,

all the concerns in the proposal have been addressed, including CITE
testing, and hence I would like to call for review and voting as
appropriate.

Already updated the page with the votes given in the mailing list.
Here's the proposal page again:<http://geoserver.org/display/GEOS/GSIP
+49+-+WMS+module+cleanup+and+refactoring>

I would specially like to hear from Simone/Alessio as they might be
doing some WMS related development so this would be the time to raise
any further concern.

Waiting for your feedback,

Gabriel.

On Thu, 2010-09-16 at 19:56 +0200, Andrea Aime wrote:

On 16/09/2010 00:57, Gabriel Roldán wrote:

Hi all,

I have been working on the long awaited WMS module clean up in an effort
to finally port it to the Dispatcher architecture, and during the FOSS4G
code sprint we (Andrea, Justin and myself) have been through a code
review.

Here's the proposal:<http://geoserver.org/display/GEOS/GSIP+49+-+WMS
+module+cleanup+and+refactoring>

And here where the work is taking place:
<http://github.com/groldan/geoserver_trunk/tree/wmscleanup&gt;

Please feel free to comment out on any issue/concern you might find with
it. The pending issues we identified during the code review are already
listed on the proposal. I would like to commit to trunk once all those
concerns are taken care of.

Yup, very much looking forward to this one :slight_smile:
+1

Cheers
Andrea

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineering Team Leader
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Thanks Gabriel; and thanks to those who reviewed at the code sprint.
Added my vote to the wiki page.
Jody
On 19/09/2010, at 11:28 AM, Gabriel Roldán wrote:

Hello again,

all the concerns in the proposal have been addressed, including CITE
testing, and hence I would like to call for review and voting as
appropriate.

Already updated the page with the votes given in the mailing list.
Here's the proposal page again: <http://geoserver.org/display/GEOS/GSIP
+49+-+WMS+module+cleanup+and+refactoring>

I would specially like to hear from Simone/Alessio as they might be
doing some WMS related development so this would be the time to raise
any further concern.

Waiting for your feedback,

Gabriel.

On Thu, 2010-09-16 at 19:56 +0200, Andrea Aime wrote:

On 16/09/2010 00:57, Gabriel Roldán wrote:

Hi all,

I have been working on the long awaited WMS module clean up in an effort
to finally port it to the Dispatcher architecture, and during the FOSS4G
code sprint we (Andrea, Justin and myself) have been through a code
review.

Here's the proposal:<http://geoserver.org/display/GEOS/GSIP+49+-+WMS
+module+cleanup+and+refactoring>

And here where the work is taking place:
<http://github.com/groldan/geoserver_trunk/tree/wmscleanup&gt;

Please feel free to comment out on any issue/concern you might find with
it. The pending issues we identified during the code review are already
listed on the proposal. I would like to commit to trunk once all those
concerns are taken care of.

Yup, very much looking forward to this one :slight_smile:
+1

Cheers
Andrea

--
Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Thanks everyone for the quick turn around on this proposal.

I'm planning on committing this to trunk later today when most of you
should be out of office hours, so that I can make sure nothing breaks
meanwhile.

If there's any impediment to do so that you can think of please speak
asap.

Thanks again,
Gabriel

On Tue, 2010-09-21 at 12:05 +1000, Jody Garnett wrote:

Thanks Gabriel; and thanks to those who reviewed at the code sprint.
Added my vote to the wiki page.
Jody
On 19/09/2010, at 11:28 AM, Gabriel Roldán wrote:

> Hello again,
>
> all the concerns in the proposal have been addressed, including CITE
> testing, and hence I would like to call for review and voting as
> appropriate.
>
> Already updated the page with the votes given in the mailing list.
> Here's the proposal page again: <http://geoserver.org/display/GEOS/GSIP
> +49+-+WMS+module+cleanup+and+refactoring>
>
> I would specially like to hear from Simone/Alessio as they might be
> doing some WMS related development so this would be the time to raise
> any further concern.
>
> Waiting for your feedback,
>
> Gabriel.
>
> On Thu, 2010-09-16 at 19:56 +0200, Andrea Aime wrote:
>> On 16/09/2010 00:57, Gabriel Roldán wrote:
>>> Hi all,
>>>
>>> I have been working on the long awaited WMS module clean up in an effort
>>> to finally port it to the Dispatcher architecture, and during the FOSS4G
>>> code sprint we (Andrea, Justin and myself) have been through a code
>>> review.
>>>
>>> Here's the proposal:<http://geoserver.org/display/GEOS/GSIP+49+-+WMS
>>> +module+cleanup+and+refactoring>
>>>
>>> And here where the work is taking place:
>>> <http://github.com/groldan/geoserver_trunk/tree/wmscleanup&gt;
>>>
>>> Please feel free to comment out on any issue/concern you might find with
>>> it. The pending issues we identified during the code review are already
>>> listed on the proposal. I would like to commit to trunk once all those
>>> concerns are taken care of.
>>
>> Yup, very much looking forward to this one :slight_smile:
>> +1
>>
>> Cheers
>> Andrea
>>
>
> --
> Gabriel Roldan
> groldan@anonymised.com
> Expert service straight from the developers
>
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers

The commits for GSIP 49 went through svn and the wms module looks
healthier than ever (if you're subscribed to the geoserver-commits
mailing list you surely noticed already).

Thanks to all of you that provided feedback, votes and review time.

Gabriel

On Tue, 2010-09-21 at 14:31 -0300, Gabriel Roldán wrote:

Thanks everyone for the quick turn around on this proposal.

I'm planning on committing this to trunk later today when most of you
should be out of office hours, so that I can make sure nothing breaks
meanwhile.

If there's any impediment to do so that you can think of please speak
asap.

Thanks again,
Gabriel

On Tue, 2010-09-21 at 12:05 +1000, Jody Garnett wrote:
> Thanks Gabriel; and thanks to those who reviewed at the code sprint.
> Added my vote to the wiki page.
> Jody
> On 19/09/2010, at 11:28 AM, Gabriel Roldán wrote:
>
> > Hello again,
> >
> > all the concerns in the proposal have been addressed, including CITE
> > testing, and hence I would like to call for review and voting as
> > appropriate.
> >
> > Already updated the page with the votes given in the mailing list.
> > Here's the proposal page again: <http://geoserver.org/display/GEOS/GSIP
> > +49+-+WMS+module+cleanup+and+refactoring>
> >
> > I would specially like to hear from Simone/Alessio as they might be
> > doing some WMS related development so this would be the time to raise
> > any further concern.
> >
> > Waiting for your feedback,
> >
> > Gabriel.
> >
> > On Thu, 2010-09-16 at 19:56 +0200, Andrea Aime wrote:
> >> On 16/09/2010 00:57, Gabriel Roldán wrote:
> >>> Hi all,
> >>>
> >>> I have been working on the long awaited WMS module clean up in an effort
> >>> to finally port it to the Dispatcher architecture, and during the FOSS4G
> >>> code sprint we (Andrea, Justin and myself) have been through a code
> >>> review.
> >>>
> >>> Here's the proposal:<http://geoserver.org/display/GEOS/GSIP+49+-+WMS
> >>> +module+cleanup+and+refactoring>
> >>>
> >>> And here where the work is taking place:
> >>> <http://github.com/groldan/geoserver_trunk/tree/wmscleanup&gt;
> >>>
> >>> Please feel free to comment out on any issue/concern you might find with
> >>> it. The pending issues we identified during the code review are already
> >>> listed on the proposal. I would like to commit to trunk once all those
> >>> concerns are taken care of.
> >>
> >> Yup, very much looking forward to this one :slight_smile:
> >> +1
> >>
> >> Cheers
> >> Andrea
> >>
> >
> > --
> > Gabriel Roldan
> > groldan@anonymised.com
> > Expert service straight from the developers
> >
> >
> > ------------------------------------------------------------------------------
> > Start uncovering the many advantages of virtual appliances
> > and start using them to simplify application deployment and
> > accelerate your shift to cloud computing.
> > http://p.sf.net/sfu/novell-sfdev2dev
> > _______________________________________________
> > Geoserver-devel mailing list
> > Geoserver-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>

--
Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers

Great work Gabriel! Thanks for seeing this through. The wms module is not a shining beacon for the rest of us :slight_smile:

On Wed, Sep 22, 2010 at 12:18 AM, Gabriel Roldán <groldan@anonymised.com> wrote:

The commits for GSIP 49 went through svn and the wms module looks
healthier than ever (if you’re subscribed to the geoserver-commits
mailing list you surely noticed already).

Thanks to all of you that provided feedback, votes and review time.

Gabriel

On Tue, 2010-09-21 at 14:31 -0300, Gabriel Roldán wrote:

Thanks everyone for the quick turn around on this proposal.

I’m planning on committing this to trunk later today when most of you
should be out of office hours, so that I can make sure nothing breaks
meanwhile.

If there’s any impediment to do so that you can think of please speak
asap.

Thanks again,
Gabriel

On Tue, 2010-09-21 at 12:05 +1000, Jody Garnett wrote:

Thanks Gabriel; and thanks to those who reviewed at the code sprint.
Added my vote to the wiki page.
Jody
On 19/09/2010, at 11:28 AM, Gabriel Roldán wrote:

Hello again,

all the concerns in the proposal have been addressed, including CITE
testing, and hence I would like to call for review and voting as
appropriate.

Already updated the page with the votes given in the mailing list.
Here’s the proposal page again: <http://geoserver.org/display/GEOS/GSIP
+49±+WMS+module+cleanup+and+refactoring>

I would specially like to hear from Simone/Alessio as they might be
doing some WMS related development so this would be the time to raise
any further concern.

Waiting for your feedback,

Gabriel.

On Thu, 2010-09-16 at 19:56 +0200, Andrea Aime wrote:

On 16/09/2010 00:57, Gabriel Roldán wrote:

Hi all,

I have been working on the long awaited WMS module clean up in an effort
to finally port it to the Dispatcher architecture, and during the FOSS4G
code sprint we (Andrea, Justin and myself) have been through a code
review.

Here’s the proposal:<http://geoserver.org/display/GEOS/GSIP+49±+WMS
+module+cleanup+and+refactoring>

And here where the work is taking place:
<http://github.com/groldan/geoserver_trunk/tree/wmscleanup>

Please feel free to comment out on any issue/concern you might find with
it. The pending issues we identified during the code review are already
listed on the proposal. I would like to commit to trunk once all those
concerns are taken care of.

Yup, very much looking forward to this one :slight_smile:
+1

Cheers
Andrea


Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers


Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Gabriel Roldan
groldan@anonymised.com
Expert service straight from the developers


Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.