[Geoserver-devel] GSIP 56 - WMS 1.3 support

GeoServer GeoServer Developer
1

Hi all,

Chris sent out a link to the proposal the other day. Here it is again now that it is ready for formal discussion.

http://geoserver.org/display/GEOS/GSIP+56±+WMS+1.3+Support

Feedback much appreciated.

-Justin

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

2

On Wed, Dec 15, 2010 at 5:13 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hi all,
Chris sent out a link to the proposal the other day. Here it is again now
that it is ready for formal discussion.
http://geoserver.org/display/GEOS/GSIP+56+-+WMS+1.3+Support
Feedback much appreciated.

Hi,
I already did a code review on this one and it looks mostly good, you have my
detailed feedback on it.

Things that came to mind by reading the GSIP:
- axis order wise, is the spec mandating any geographic system to be lat/lon or
  just talking about EPSG:4326? The latter would be pretty messy but
better to be sure
- SE wise, some of the functions we already suppport. Btw, do we
support the concept of
  default value in a function call? If so, how?
- is GetMap POST optional in WMS 1.3? How is the relationship between
the POST in
  WMS 1.3 and SLD 1.1?
- the proposal does not talk about the desktop client testing in which
it appears that
  WMS 1.3 clients still insist to make WMS 1.3 GetFeatureInfo calls
using X,Y instead
  of I,J (both GAIA and QGis). Some description on how to handle that
would be probably good

And oh, +1 on the proposal :slight_smile:

Cheers
Andrea

-Justin
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
-----------------------------------------------------
Ing. Andrea Aime
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-----------------------------------------------------

3

Thanks for the feedback Andrea.

On Wed, Dec 15, 2010 at 2:35 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, Dec 15, 2010 at 5:13 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hi all,
Chris sent out a link to the proposal the other day. Here it is again now
that it is ready for formal discussion.
http://geoserver.org/display/GEOS/GSIP+56±+WMS+1.3+Support
Feedback much appreciated.

Hi,
I already did a code review on this one and it looks mostly good, you have my
detailed feedback on it.

Things that came to mind by reading the GSIP:

  • axis order wise, is the spec mandating any geographic system to be lat/lon or
    just talking about EPSG:4326? The latter would be pretty messy but
    better to be sure

Good question. The spec only mentions EPSG:4326 as an example and does not state anything explicit from what I can see. I will try to send an email to the cite group to get clarification. Or is there a specific wms-dev that anyone knows of like list like there is for wfs?

  • SE wise, some of the functions we already suppport. Btw, do we
    support the concept of
    default value in a function call? If so, how?

Yeah I still have a bit of work to do there to link up the functions we do support. As for default value are you talking default value for a parameter? I guess there might be some function implementations that do this but most that i have seen don’t. Which function from SE are you referring to?

  • is GetMap POST optional in WMS 1.3? How is the relationship between
    the POST in WMS 1.3 and SLD 1.1?

While I did not find any exact statement saying it is optional it is defined as part of the SLD 1.1 spec so I guess optional in term of straight wms 1.3 but mandatory if you say you support SLD 1.1.

  • the proposal does not talk about the desktop client testing in which
    it appears that
    WMS 1.3 clients still insist to make WMS 1.3 GetFeatureInfo calls
    using X,Y instead
    of I,J (both GAIA and QGis). Some description on how to handle that
    would be probably good

Right, will update the proposal about that.

And oh, +1 on the proposal :slight_smile:

Cheers
Andrea

-Justin

Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Ing. Andrea Aime
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

4

+1 here

On Wed, Dec 15, 2010 at 4:35 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, Dec 15, 2010 at 5:13 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hi all,
Chris sent out a link to the proposal the other day. Here it is again now
that it is ready for formal discussion.
http://geoserver.org/display/GEOS/GSIP+56±+WMS+1.3+Support
Feedback much appreciated.

Hi,
I already did a code review on this one and it looks mostly good, you have my
detailed feedback on it.

Things that came to mind by reading the GSIP:

  • axis order wise, is the spec mandating any geographic system to be lat/lon or
    just talking about EPSG:4326? The latter would be pretty messy but
    better to be sure
  • SE wise, some of the functions we already suppport. Btw, do we
    support the concept of
    default value in a function call? If so, how?
  • is GetMap POST optional in WMS 1.3? How is the relationship between
    the POST in
    WMS 1.3 and SLD 1.1?
  • the proposal does not talk about the desktop client testing in which
    it appears that
    WMS 1.3 clients still insist to make WMS 1.3 GetFeatureInfo calls
    using X,Y instead
    of I,J (both GAIA and QGis). Some description on how to handle that
    would be probably good

And oh, +1 on the proposal :slight_smile:

Cheers
Andrea

-Justin

Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Ing. Andrea Aime
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

5

On Wed, Dec 15, 2010 at 4:36 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

- SE wise, some of the functions we already suppport. Btw, do we
support the concept of
default value in a function call? If so, how?

Yeah I still have a bit of work to do there to link up the functions we do
support. As for default value are you talking default value for a parameter?
I guess there might be some function implementations that do this but most
that i have seen don't. Which function from SE are you referring to?

Afaik in SE there is this concept of default value to be applied in case the
function is not implemented in the server. Maybe it's called fallback value.

- is GetMap POST optional in WMS 1.3? How is the relationship between
the POST in WMS 1.3 and SLD 1.1?

While I did not find any exact statement saying it is optional it is defined
as part of the SLD 1.1 spec so I guess optional in term of straight wms 1.3
but mandatory if you say you support SLD 1.1.

Cool

Cheers
Andrea

-----------------------------------------------------
Ing. Andrea Aime
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-----------------------------------------------------

6

+1 from me. This is a well-considered proposal for functionality that will be much in demand. Even if support for SLD 1.1 was not optional, partial support would be a step in the right direction, so extra credit for this one. :slight_smile:

SLDs for complex features use XPaths. Does SLD 1.1 allow the GML application schema to which these relate to be specified? Or should we just put it in the schemaLocation? This would allow the information model to be more clearly associated with the SLD. (I don't know much about SLDs of any sort.)

On 15/12/10 12:13, Justin Deoliveira wrote:

Hi all,

Chris sent out a link to the proposal the other day. Here it is again now that it is ready for formal discussion.

http://geoserver.org/display/GEOS/GSIP+56+-+WMS+1.3+Support

Feedback much appreciated.

-Justin

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineering Team Leader
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

7

On 16/12/2010, at 1:36 AM, Justin Deoliveira wrote:

  • SE wise, some of the functions we already suppport. Btw, do we
    support the concept of
    default value in a function call? If so, how?

Yeah I still have a bit of work to do there to link up the functions we do support. As for default value are you talking default value for a parameter? I guess there might be some function implementations that do this but most that i have seen don’t. Which function from SE are you referring to?

It is an extension for SE 1.1. We do support it at the geotools level; FunctionFinder will try its best to look up a good implementation; if none is found a placeholder is returned that always returns the default value.

  • the proposal does not talk about the desktop client testing in which
    it appears that
    WMS 1.3 clients still insist to make WMS 1.3 GetFeatureInfo calls
    using X,Y instead
    of I,J (both GAIA and QGis). Some description on how to handle that
    would be probably good

Right, will update the proposal about that.

And oh, +1 on the proposal :slight_smile:

+1 (and great work)

Jody

8

Sorry for the delay … I was not in office these days.

+1 here!

Ing. Alessio Fabiani
Founder / CTO GeoSolutions S.A.S.

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: (+39) 0584 96.23.13
fax: (+39) 0584 96.23.13
mobile:(+39) 349 82.27.000

http://www.geo-solutions.it
http://geo-solutions.blogspot.com
http://www.linkedin.com/in/alessiofabiani
http://twitter.com/simogeo

On Thu, Dec 16, 2010 at 7:21 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

On 16/12/2010, at 1:36 AM, Justin Deoliveira wrote:

  • SE wise, some of the functions we already suppport. Btw, do we
    support the concept of
    default value in a function call? If so, how?

Yeah I still have a bit of work to do there to link up the functions we do support. As for default value are you talking default value for a parameter? I guess there might be some function implementations that do this but most that i have seen don’t. Which function from SE are you referring to?

It is an extension for SE 1.1. We do support it at the geotools level; FunctionFinder will try its best to look up a good implementation; if none is found a placeholder is returned that always returns the default value.

  • the proposal does not talk about the desktop client testing in which
    it appears that
    WMS 1.3 clients still insist to make WMS 1.3 GetFeatureInfo calls
    using X,Y instead
    of I,J (both GAIA and QGis). Some description on how to handle that
    would be probably good

Right, will update the proposal about that.

And oh, +1 on the proposal :slight_smile:

+1 (and great work)

Jody

Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

9

Thanks for all the feedback and voting for this one everyone. Looks like we have enough positive votes to move forward :slight_smile:

On Thu, Dec 16, 2010 at 11:05 AM, Alessio Fabiani <alessio.fabiani@anonymised.com> wrote:

Sorry for the delay … I was not in office these days.

+1 here!

Ing. Alessio Fabiani
Founder / CTO GeoSolutions S.A.S.

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: (+39) 0584 96.23.13
fax: (+39) 0584 96.23.13
mobile:(+39) 349 82.27.000

http://www.geo-solutions.it
http://geo-solutions.blogspot.com

http://www.linkedin.com/in/alessiofabiani
http://twitter.com/simogeo

On Thu, Dec 16, 2010 at 7:21 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

On 16/12/2010, at 1:36 AM, Justin Deoliveira wrote:

  • SE wise, some of the functions we already suppport. Btw, do we
    support the concept of
    default value in a function call? If so, how?

Yeah I still have a bit of work to do there to link up the functions we do support. As for default value are you talking default value for a parameter? I guess there might be some function implementations that do this but most that i have seen don’t. Which function from SE are you referring to?

It is an extension for SE 1.1. We do support it at the geotools level; FunctionFinder will try its best to look up a good implementation; if none is found a placeholder is returned that always returns the default value.

  • the proposal does not talk about the desktop client testing in which
    it appears that
    WMS 1.3 clients still insist to make WMS 1.3 GetFeatureInfo calls
    using X,Y instead
    of I,J (both GAIA and QGis). Some description on how to handle that
    would be probably good

Right, will update the proposal about that.

And oh, +1 on the proposal :slight_smile:

+1 (and great work)

Jody

Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

10

+1
It's taken me ages to sift through this and think, sorry about that.
It's thorough and clear enough even for me to follow, thanks for that
:slight_smile:

--
Mark

On 15 December 2010 15:13, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hi all,
Chris sent out a link to the proposal the other day. Here it is again now
that it is ready for formal discussion.
http://geoserver.org/display/GEOS/GSIP+56+-+WMS+1.3+Support
Feedback much appreciated.
-Justin
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel