[Geoserver-devel] GSIP 98 pull request ready

GeoServer GeoServer Developer
1

Hi,
the GSIP 98 seems to have enough votes, so I prepared the pull request that
swaps kml and kml2 here:
https://github.com/geoserver/geoserver/pull/265

To stay on the safe side I’ve kept the old kml module in community as kml-old, and plan to remove it permanently once 2.4.0 is out

By the way, this morning I went through the kml jira tickets and could close 12 of them because they have been addressed by the new kml module (and/or cannot be reproduced with it)

Plan to merge the pull request towards the end of the day unless I hear objections.

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

2

+1 here!

···

On Fri, Jul 5, 2013 at 3:57 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
the GSIP 98 seems to have enough votes, so I prepared the pull request that
swaps kml and kml2 here:
https://github.com/geoserver/geoserver/pull/265

To stay on the safe side I’ve kept the old kml module in community as kml-old, and plan to remove it permanently once 2.4.0 is out

By the way, this morning I went through the kml jira tickets and could close 12 of them because they have been addressed by the new kml module (and/or cannot be reproduced with it)

Plan to merge the pull request towards the end of the day unless I hear objections.

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

3

On Fri, Jul 5, 2013 at 4:54 PM, Justin Deoliveira <jdeolive@anonymised.com>wrote:

+1 here!

Merged

The build just failed on the main module, however my patch did not touch
it, and actually,
nothing has modified it since 10 days ago... except that we have a commit
from Kevin
dated April that is at the top of the git log list:

---------------------------------

commit 104987744450768e39de42ea749eda4de5df7a34
Author: Kevin Smith <ksmith@anonymised.com>
Date: Tue Apr 23 12:06:37 2013 -0700

    Allow styles to be added to specific workspaces in SystemTestData

commit d3422169a73542f861353f10bf7793718aba5891
Merge: 7590baa 3c0dbb3
Author: Andrea Aime <andrea.aime@anonymised.com>
Date: Thu Jun 27 06:44:29 2013 -0700

    Merge pull request #256 from aaime/geos-5865

    [GEOS-5865] Make GeoServer leverage the GeoTools multicoverage raster
AP...

commit 78815e3e96a4b80f716f09a911b2dc65bb4d6493
Author: Andrea Aime <andrea.aime@anonymised.com>
Date: Tue Jun 25 19:38:58 2013 +0200

    Avoid dispose warnings when feature type infos are getting disposed
with the new keys taking into account projection policy

---------------------------------

and the failure is:

Tests in error:
  testRemoveUserInGroup(org.geoserver.security.GroupAdminServiceTest)
  testCreateNewUser(org.geoserver.security.GroupAdminServiceTest)

Hum... what's going on?? :slight_smile:

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

4

On Fri, Jul 5, 2013 at 6:54 PM, Andrea Aime <andrea.aime@anonymised.com>wrote:

and the failure is:

Tests in error:
  testRemoveUserInGroup(org.geoserver.security.GroupAdminServiceTest)
  testCreateNewUser(org.geoserver.security.GroupAdminServiceTest)

Hum... what's going on?? :slight_smile:

Hmm... nope, cannot reproduce locally... has this test being failing
randomly in the past?
Can't remember...

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

5

n Fri, Jul 5, 2013 at 7:10 PM, Andrea Aime <andrea.aime@anonymised.com>wrote:

On Fri, Jul 5, 2013 at 6:54 PM, Andrea Aime <andrea.aime@anonymised.com>wrote:

and the failure is:

Tests in error:
  testRemoveUserInGroup(org.geoserver.security.GroupAdminServiceTest)
  testCreateNewUser(org.geoserver.security.GroupAdminServiceTest)

Hum... what's going on?? :slight_smile:

Hmm... nope, cannot reproduce locally... has this test being failing
randomly in the past?
Can't remember...

And it's back to building normally, without any change committed.
Random failure it seems...

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------