[Geoserver-devel] GSIP 98: replace the kml module with KML2

Hi PSC members,
I’ve just finished manual testing of the kml2 module against the GS documentation, all works as expected (and actually, better than in the current kml module), so I’ve prepared a proposal to swap the two and make kml2 the new official kml module.

http://geoserver.org/display/GEOS/GSIP+98±+replace+old+KML+module+with+new+one

Personally I’d just remove the old kml module, do you see a reason to move it back to community instead?

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Mon, Jul 1, 2013 at 12:31 PM, Andrea Aime
<andrea.aime@anonymised.com>wrote:

Hi PSC members,
I've just finished manual testing of the kml2 module against the GS
documentation, all works as expected (and actually, better than in the
current kml module), so I've prepared a proposal to swap the two and make
kml2 the new official kml module.

http://geoserver.org/display/GEOS/GSIP+98+-+replace+old+KML+module+with+new+one

Personally I'd just remove the old kml module, do you see a reason to move
it back to community instead?

Ah, in case you still haven't tried it out yet, you can setup the eclipse
projects to have kml2 instead of kml as a dependency like this:
mvn eclipse:eclipse -P\!kml,kml2 -o -T2C

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

My +1 here … KML module was abandoned for a long time and this work is absolutely welcomed on my opinion. Also the code refactoring to a better object oriented model is a great improvement.

···

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for
more information.

Ing. Alessio Fabiani
@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Mon, Jul 1, 2013 at 12:32 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Jul 1, 2013 at 12:31 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:


This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Hi PSC members,
I’ve just finished manual testing of the kml2 module against the GS documentation, all works as expected (and actually, better than in the current kml module), so I’ve prepared a proposal to swap the two and make kml2 the new official kml module.

http://geoserver.org/display/GEOS/GSIP+98±+replace+old+KML+module+with+new+one

Personally I’d just remove the old kml module, do you see a reason to move it back to community instead?

Ah, in case you still haven’t tried it out yet, you can setup the eclipse projects to have kml2 instead of kml as a dependency like this:

mvn eclipse:eclipse -P!kml,kml2 -o -T2C

Cheers

Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Mon, Jul 1, 2013 at 6:32 AM, Andrea Aime <andrea.aime@anonymised.com>wrote:

On Mon, Jul 1, 2013 at 12:31 PM, Andrea Aime <andrea.aime@anonymised.com
> wrote:

Hi PSC members,
I've just finished manual testing of the kml2 module against the GS
documentation, all works as expected (and actually, better than in the
current kml module), so I've prepared a proposal to swap the two and make
kml2 the new official kml module.

http://geoserver.org/display/GEOS/GSIP+98+-+replace+old+KML+module+with+new+one

Personally I'd just remove the old kml module, do you see a reason to
move it back to community instead?

Ah, in case you still haven't tried it out yet, you can setup the eclipse
projects to have kml2 instead of kml as a dependency like this:
mvn eclipse:eclipse -P\!kml,kml2 -o -T2C

If it's easy for someone to make a build for me (preferably the binary one,
can also do a .war) I'd be psyched to check it out and do a bit of testing
on it. I'm unfortunately too far from development days to build it myself -
the nightlies have spoiled me since I can test most everything there. But
I'm probably still +1 even if I can't try it out before, I'll just be sure
to test on master.

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

On Mon, Jul 1, 2013 at 4:30 PM, Chris Holmes <cholmes@anonymised.com> wrote:

If it's easy for someone to make a build for me (preferably the binary

one, can also do a .war) I'd be psyched to check it out and do a bit of
testing on it. I'm unfortunately too far from development days to build it
myself - the nightlies have spoiled me since I can test most everything
there. But I'm probably still +1 even if I can't try it out before, I'll
just be sure to test on master.

Sure, I'm uploading a ready made bin package. It will take some time as my
upload speed is (quite) limited,
going to provide the link as soon as I have it ready for download

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

On Mon, Jul 1, 2013 at 4:58 PM, Andrea Aime <andrea.aime@anonymised.com>wrote:

On Mon, Jul 1, 2013 at 4:30 PM, Chris Holmes <cholmes@anonymised.com> wrote:

If it's easy for someone to make a build for me (preferably the binary

one, can also do a .war) I'd be psyched to check it out and do a bit of
testing on it. I'm unfortunately too far from development days to build it
myself - the nightlies have spoiled me since I can test most everything
there. But I'm probably still +1 even if I can't try it out before, I'll
just be sure to test on master.

Here we go, for your testing pleasure, a -bin style geoserver ready to roll
:slight_smile:

http://demo.geo-solutions.it/share/kml2.zip

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

+1 here. Overdue even.

Notice: This email and any attachments are confidential.
If received in error please destroy and immediately notify us.
Do not copy or disclose the contents.

+1. Great work, Andrea.

Because the change targets a new stable release and is not being backported, I think this is an opportunity to remove the old kml module. If anyone wants the old one, they can get it from git, revive it as a community module, and in effect volunteer as maintainer. :slight_smile:

Kind regards,
Ben.

On 01/07/13 18:31, Andrea Aime wrote:

Hi PSC members,
I've just finished manual testing of the kml2 module against the GS
documentation, all works as expected (and actually, better than in the
current kml module), so I've prepared a proposal to swap the two and
make kml2 the new official kml module.

http://geoserver.org/display/GEOS/GSIP+98+-+replace+old+KML+module+with+new+one

Personally I'd just remove the old kml module, do you see a reason to
move it back to community instead?

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for
more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Thanks! Trying it out now.

···

On Mon, Jul 1, 2013 at 11:40 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Jul 1, 2013 at 4:58 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Jul 1, 2013 at 4:30 PM, Chris Holmes <cholmes@anonymised.com> wrote:

Here we go, for your testing pleasure, a -bin style geoserver ready to roll :slight_smile:

http://demo.geo-solutions.it/share/kml2.zip

Cheers

Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


If it’s easy for someone to make a build for me (preferably the binary one, can also do a .war) I’d be psyched to check it out and do a bit of testing on it. I’m unfortunately too far from development days to build it myself - the nightlies have spoiled me since I can test most everything there. But I’m probably still +1 even if I can’t try it out before, I’ll just be sure to test on master.

Related to this work are some of the pending changes we have coming down the pipe. Unfortunately Kevin is out this week but my understanding is this.

  1. We did some stuff for kml symbols that was done against the old code. It is currently sitting on a branch here.

https://github.com/smithkm/geoserver/tree/kml-dynamic-icons-squashed

  1. We want to push that in and forward port it to the new kml work so that the work is not lost going forward. We want to have this make the deadline for the 2.4 feature cutoff. Any objections to getting that work in the new kml module in the short term given that it doesn’t destabilize any of the work done to date?
···

On Tue, Jul 2, 2013 at 8:33 AM, Chris Holmes <cholmes@anonymised.com> wrote:

Thanks! Trying it out now.


This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

On Mon, Jul 1, 2013 at 11:40 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Jul 1, 2013 at 4:58 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Jul 1, 2013 at 4:30 PM, Chris Holmes <cholmes@anonymised.com> wrote:

Here we go, for your testing pleasure, a -bin style geoserver ready to roll :slight_smile:

http://demo.geo-solutions.it/share/kml2.zip

Cheers

Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


If it’s easy for someone to make a build for me (preferably the binary one, can also do a .war) I’d be psyched to check it out and do a bit of testing on it. I’m unfortunately too far from development days to build it myself - the nightlies have spoiled me since I can test most everything there. But I’m probably still +1 even if I can’t try it out before, I’ll just be sure to test on master.

On Tue, Jul 2, 2013 at 7:41 PM, Justin Deoliveira <jdeolive@anonymised.com>wrote:

Related to this work are some of the pending changes we have coming down
the pipe. Unfortunately Kevin is out this week but my understanding is this.

1. We did some stuff for kml symbols that was done against the old code.
It is currently sitting on a branch here.

  https://github.com/smithkm/geoserver/tree/kml-dynamic-icons-squashed

So, it is some sort of dynamic icon server, right?

2. We want to push that in and forward port it to the new kml work so that
the work is not lost going forward. We want to have this make the deadline
for the 2.4 feature cutoff. Any objections to getting that work in the new
kml module in the short term given that it doesn't destabilize any of the
work done to date?

It should not be too hard to merge, the icon server code stays the same,
and in kml2 you need to modify the
placemark style decorator, making it generate the icon links, or add the
kmz icons to the context in order to keep
them into the generated kmz.
Should not be too hard, and as far as I can tell, not much invasive, if
everything goes like I believe it should,
you might just have to modify one class in kml2.
So, no objections here.

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

On Tue, Jul 2, 2013 at 12:12 PM, Andrea Aime
<andrea.aime@anonymised.com>wrote:

On Tue, Jul 2, 2013 at 7:41 PM, Justin Deoliveira <jdeolive@anonymised.com>wrote:

Related to this work are some of the pending changes we have coming down
the pipe. Unfortunately Kevin is out this week but my understanding is this.

1. We did some stuff for kml symbols that was done against the old code.
It is currently sitting on a branch here.

  https://github.com/smithkm/geoserver/tree/kml-dynamic-icons-squashed

So, it is some sort of dynamic icon server, right?

Yup. That's the one.

2. We want to push that in and forward port it to the new kml work so
that the work is not lost going forward. We want to have this make the
deadline for the 2.4 feature cutoff. Any objections to getting that work in
the new kml module in the short term given that it doesn't destabilize any
of the work done to date?

It should not be too hard to merge, the icon server code stays the same,
and in kml2 you need to modify the
placemark style decorator, making it generate the icon links, or add the
kmz icons to the context in order to keep
them into the generated kmz.
Should not be too hard, and as far as I can tell, not much invasive, if
everything goes like I believe it should,
you might just have to modify one class in kml2.
So, no objections here.

Awesome. I am just looking at the code now. For now can we avoid moving or
removing the old kml module that would be appreciated, will make it easier
to analyze the diff of the old code, etc...

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

On Tue, Jul 2, 2013 at 8:14 PM, Justin Deoliveira <jdeolive@anonymised.com>wrote:

Awesome. I am just looking at the code now. For now can we avoid moving or
removing the old kml module that would be appreciated, will make it easier
to analyze the diff of the old code, etc...

Sure. However, next week I'm in vacation, do you think you'll be done by
Friday? :-p
I can do the swap later of course, and we are still missing votes in the
proposal anyways, just checking
the lay of the land.

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

On Tue, Jul 2, 2013 at 12:19 PM, Andrea Aime
<andrea.aime@anonymised.com>wrote:

On Tue, Jul 2, 2013 at 8:14 PM, Justin Deoliveira <jdeolive@anonymised.com>wrote:

Awesome. I am just looking at the code now. For now can we avoid moving
or removing the old kml module that would be appreciated, will make it
easier to analyze the diff of the old code, etc...

Sure. However, next week I'm in vacation, do you think you'll be done by
Friday? :-p
I can do the swap later of course, and we are still missing votes in the
proposal anyways, just checking
the lay of the land.

Yeah, my plan is actually to have it done asap, today ideally :slight_smile: But yeah
basically this is the top of my list right now.

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.