Hey Andrea,
The change of org.geotools.renderer.lite.LiteFeatureTypeStyle from public to package private breaks the vectortiles geoserver community module.
The geoserver-master build doesn’t notice but geoserver-nightly will fail.
I’m all for keeping things as private as possible so I’m ready to follow your advise here. We either make it back public, or I can move the utility class that uses it in vectortiles to the same package. The later looks hackier, but whatever.
Cheers,
Gabriel
On Tue, Sep 1, 2015 at 9:21 PM, Gabriel Roldan <groldan@anonymised.com>
wrote:
Hey Andrea,
The change of org.geotools.renderer.lite.LiteFeatureTypeStyle from public
to package private breaks the vectortiles geoserver community module.The geoserver-master build doesn't notice but geoserver-nightly will fail.
I'm all for keeping things as private as possible so I'm ready to follow
your advise here. We either make it back public, or I can move the utility
class that uses it in vectortiles to the same package. The later looks
hackier, but whatever.
Urg... that class was never meant to be public in the first place, it's
tied guts and bones to the
StreamingRenderer, it's just that people tend to keep classes public out of
laziness (because it's
their IDE default).
What are you using it for?
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
On Tue, Sep 1, 2015 at 9:55 PM, Andrea Aime <andrea.aime@anonymised.com>
wrote:
Urg... that class was never meant to be public in the first place, it's
tied guts and bones to the
StreamingRenderer, it's just that people tend to keep classes public out
of laziness (because it's
their IDE default).What are you using it for?
Oh, I see, you basically copy/pasted several bits of the streaming renderer
into the vector tiles
module.
We can do two short term things:
* You also copy over LiteFeatureTypeStyle, it's a really small class, just
a data holder:
https://github.com/geotools/geotools/blob/master/modules/library/render/src/main/java/org/geotools/renderer/lite/LiteFeatureTypeStyle.java
* I can push back LiteFeatureTypeStyle to public, mark it as deprecated,
and hide it back in the next cycle
Longer term it would probably be best to have whatever code you need
factored out of the streaming renderer.
When I worked on the KML module I had a similar problem, and I've written a
few classes that do a similar job,
see
https://github.com/geoserver/geoserver/tree/master/src/kml/src/main/java/org/geoserver/kml/utils
,
in particular:
https://github.com/geoserver/geoserver/blob/master/src/kml/src/main/java/org/geoserver/kml/utils/KMLFeatureAccessor.java
https://github.com/geoserver/geoserver/blob/master/src/kml/src/main/java/org/geoserver/kml/utils/ScaleStyleVisitor.java
The issue with the streaming renderer is that it does not have enough tests
covering it, so I'm always quite cautious
when it comes to doing any non automated refactor to it
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
On Tue, Sep 1, 2015 at 4:55 PM, Andrea Aime <andrea.aime@anonymised.com>
wrote:
On Tue, Sep 1, 2015 at 9:21 PM, Gabriel Roldan <groldan@anonymised.com>
wrote:Hey Andrea,
The change of org.geotools.renderer.lite.LiteFeatureTypeStyle from public
to package private breaks the vectortiles geoserver community module.The geoserver-master build doesn't notice but geoserver-nightly will fail.
I'm all for keeping things as private as possible so I'm ready to follow
your advise here. We either make it back public, or I can move the utility
class that uses it in vectortiles to the same package. The later looks
hackier, but whatever.Urg... that class was never meant to be public in the first place, it's
tied guts and bones to the
StreamingRenderer, it's just that people tend to keep classes public out
of laziness (because it's
their IDE default).What are you using it for?
To create the "style query" just like the renderer does, with a couple
modifications.
The best course of action would be to rely on RenderListener like for
GetFeatureInfo, just that we don't always need the resulting geometry to be
in "screen coordinates". It's format dependent, some require screen coords,
other target CRS coords. I'm guessing one could tweak the the request
arguments for the case where target CRS coords are required?
Cheers
Andrea--
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.Ing. Andrea Aime
@geowolf
Technical LeadGeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549http://www.geo-solutions.it
http://twitter.com/geosolutions_it*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.-------------------------------------------------------
--
Gabriel Roldán
Software Developer | Boundless <http://boundlessgeo.com/>
groldan@anonymised.com
@boundlessgeo <http://twitter.com/boundlessgeo/>
On Wed, Sep 2, 2015 at 8:45 PM, Gabriel Roldan <groldan@anonymised.com>
wrote:
What are you using it for?
To create the "style query" just like the renderer does, with a couple
modifications.
The best course of action would be to rely on RenderListener like for
GetFeatureInfo, just that we don't always need the resulting geometry to be
in "screen coordinates". It's format dependent, some require screen coords,
other target CRS coords. I'm guessing one could tweak the the request
arguments for the case where target CRS coords are required?
Err... not sure. You would have to disable geometry simplification (doable),
and then see if calling the paint method:
public void paint(Graphics2D graphics, Rectangle paintArea,
ReferencedEnvelope mapArea, AffineTransform worldToScreen) {
with a paintArea that is an integer version of the mapArea, and a
worldToScreen
that is the identy, gets you back the original geometries.
Tricky to make it work, and tricky to maintain imho
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
