On Tue, Dec 30, 2014 at 1:48 AM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:
After converting geoserver to use gt-property-ng, I am getting a couple of
UI-related test failures that appear to have nothing to do with my changes.
When I test on master, these tests run fine.
In gs-web-core NewDataPageTest.testClickLink(): NullPointerException:
60 Label label = (Label)
findComponentByContent(tester.getLastRenderedPage(), "Properties",
Label.class);
61 // getPath() will start with 0: which indicates the page
62 tester.clickLink(label.getParent().getPath().substring(2));
The label returned on line 60 is null, throwing a NullPointerException on
line 62. (It seems that the label is not found on the last rendered page)
Making a quick guess here, the labels in the new data page tests are based
on the store names returned by the factory, maybe it has changed in
property-ng?
In gs-kml KmlTest.testRelativeLinks():
junit.framework.ComparisonFailure: expected:<[2]> but was:<[1]>
at junit.framework.Assert.assertEquals(Assert.java:100)
at junit.framework.Assert.assertEquals(Assert.java:107)
at
org.custommonkey.xmlunit.XMLAssert.assertXpathEvaluatesTo(XMLAssert.java:858)
at org.geoserver.kml.KMLTest.testRelativeLinks(KMLTest.java:391)
391 assertXpathEvaluatesTo("2", "count(//kml:Folder/kml:NetworkLink)",
dom);
It looks like two links are expected (A "next" and a "previous" )but only
one is found. Looking at the dom, it seems that this is a "previous" link,
suggesting that we are on the last page.
This issue at least seems like it might be related to the number of
results returned (Which could in turn be related to the PropertyDataStore
implementation), but it is a bit odd that similar problems haven't shown up
elswhere if this is the case.
I don't remember by heart, but yeah, it seems it is count-dependent. By the
way, this is not a UI tests, gs-kml it's the KML output format module
Cheers
Andrea
--
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
Please, notice that GeoSolutions will be closed for seasonal holidays
from December the 24th to January the 6th
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------