[Geoserver-devel] gt-property-ng migration: WFS GetFeatureCurvesTest failure

I am currently migrating geotools and geoserver to use the new ContentDataStore based gt-propery-ng module. During testing on geoserver, I am getting a test failure that I can’t seem to figgure out:
The test GetFeatureCurvesTest.testLinearizeWFS10() fails at line 105:

assertTrue(coordCount100m > coordCountDefault);

From what I can determine, the test queries the feature source, then sets a Linearization tolerance and queries it again. Line 105 suggests that it expects to get more coordinates returned form the second query.

I am mostly wondering why it is expected that the Linearized geometry has mote coordinated than the default geometry, but if anyone has any insights into how changing the behaviour of PropertyDataStore could affect this result that would also be helpfull.

Thanks,

Torben Barsballe

Curve support is handled by parsing curves into LineStrings on the fly. The linearization tolerance helps decide how many segments are needed when a curve is converted into a LineString (so changing this value should change the number of coordinates available).

Is it possible that we accidentally switched from the GeoTools WKTParser (which handles this stuff) to the JTS WKTParser which is unaware? We played some silly games to make the GeoTools one extend the JTS implementation (even though they do not share much code due to the design of JTS).

Jody

···

On 29 December 2014 at 13:14, Torben Barsballe <tbarsballe@anonymised.com> wrote:

I am currently migrating geotools and geoserver to use the new ContentDataStore based gt-propery-ng module. During testing on geoserver, I am getting a test failure that I can’t seem to figgure out:
The test GetFeatureCurvesTest.testLinearizeWFS10() fails at line 105:

assertTrue(coordCount100m > coordCountDefault);

From what I can determine, the test queries the feature source, then sets a Linearization tolerance and queries it again. Line 105 suggests that it expects to get more coordinates returned form the second query.

I am mostly wondering why it is expected that the Linearized geometry has mote coordinated than the default geometry, but if anyone has any insights into how changing the behaviour of PropertyDataStore could affect this result that would also be helpfull.

Thanks,

Torben Barsballe


Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Jody Garnett

On Mon, Dec 29, 2014 at 10:14 PM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:

I am currently migrating geotools and geoserver to use the new
ContentDataStore based gt-propery-ng module. During testing on geoserver, I
am getting a test failure that I can't seem to figgure out:
The test GetFeatureCurvesTest.testLinearizeWFS10() fails at line 105:

        assertTrue(coordCount100m > coordCountDefault);

From what I can determine, the test queries the feature source, then sets
a Linearization tolerance and queries it again. Line 105 suggests that it
expects to get more coordinates returned form the second query.

I am mostly wondering why it is expected that the Linearized geometry has
mote coordinated than the default geometry, but if anyone has any insights
into how changing the behaviour of PropertyDataStore could affect this
result that would also be helpfull.

If the geometry is curved it will inearize itself on demand,normally by
using a default lineaziation tolerance.
However, if we change it by using the query hints, we can get back a
different (larger) set of coordinates.

PropertyDataStore uses a WKTReader2, which is setup by checking the query
hints for the desired tolerance:

@Override
    protected FeatureReader<SimpleFeatureType, SimpleFeature>
getFeatureReader(
    String typeName, Query query) throws IOException {
    PropertyFeatureReader reader = new PropertyFeatureReader(directory,
typeName);
    Object toleranceHint =
query.getHints().get(Hints.LINEARIZATION_TOLERANCE);
if(toleranceHint instanceof Double) {
double tolerance = (double) toleranceHint;
reader.setWKTReader(new WKTReader2(tolerance));
}
return reader;
    }

Is the new store doing the same?

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Please, notice that GeoSolutions will be closed for seasonal holidays
from December the 24th to January the 6th

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

It looks like the new store was completely missing the WKT reader. I have added the reader (and test cases for curves/linearization) following the design of gt-property here: https://github.com/geotools/geotools/pull/663

The WFS GetFeatureCurvesTest now passes with these changes.

Torben

···

On Wed, Dec 31, 2014 at 1:38 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Dec 29, 2014 at 10:14 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

I am currently migrating geotools and geoserver to use the new ContentDataStore based gt-propery-ng module. During testing on geoserver, I am getting a test failure that I can’t seem to figgure out:
The test GetFeatureCurvesTest.testLinearizeWFS10() fails at line 105:

assertTrue(coordCount100m > coordCountDefault);

From what I can determine, the test queries the feature source, then sets a Linearization tolerance and queries it again. Line 105 suggests that it expects to get more coordinates returned form the second query.

I am mostly wondering why it is expected that the Linearized geometry has mote coordinated than the default geometry, but if anyone has any insights into how changing the behaviour of PropertyDataStore could affect this result that would also be helpfull.

If the geometry is curved it will inearize itself on demand,normally by using a default lineaziation tolerance.
However, if we change it by using the query hints, we can get back a different (larger) set of coordinates.

PropertyDataStore uses a WKTReader2, which is setup by checking the query hints for the desired tolerance:

@Override
protected FeatureReader<SimpleFeatureType, SimpleFeature> getFeatureReader(
String typeName, Query query) throws IOException {
PropertyFeatureReader reader = new PropertyFeatureReader(directory, typeName);
Object toleranceHint = query.getHints().get(Hints.LINEARIZATION_TOLERANCE);
if(toleranceHint instanceof Double) {
double tolerance = (double) toleranceHint;
reader.setWKTReader(new WKTReader2(tolerance));
}

return reader;
}

Is the new store doing the same?

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Please, notice that GeoSolutions will be closed for seasonal holidays
from December the 24th to January the 6th

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.