Hello everybody,
I just reviewed some pull requests and I’m a bit unsure how to handle these.
Is there a doc/description out there how to handle contributions (here pull requests) created by others. Does the committer has to sign a CLA or is it possible to accept requests with a few (e.g. up to 1000) line changes. How we can find out who did the paperwork already and is a List ofContributors published somewhere?
Thanks a lot
Seems that I found what I was looking for : https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md
2015-09-08 22:59 GMT+02:00 Frank Gasdorf <fgdrf@anonymised.com>:
Hello everybody,
I just reviewed some pull requests and I’m a bit unsure how to handle these.
Is there a doc/description out there how to handle contributions (here pull requests) created by others. Does the committer has to sign a CLA or is it possible to accept requests with a few (e.g. up to 1000) line changes. How we can find out who did the paperwork already and is a List ofContributors published somewhere?
Thanks a lot
- Frank
Did you find out how to access the list of signed agreements? I am not sure it is public. Andrea (project officer), any ideas?
On 09/09/15 09:13, Frank Gasdorf wrote:
How we can find out who did the paperwork already and is a List
of Contributors published somewhere?
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Ben, not yet 
But I created a pull to update (C)CLA links to OSGeo wiki pages. Seems GeoTools needs an update as well.
2015-09-08 23:17 GMT+02:00 Ben Caradoc-Davies <ben@anonymised.com>:
Did you find out how to access the list of signed agreements? I am not sure it is public. Andrea (project officer), any ideas?
On 09/09/15 09:13, Frank Gasdorf wrote:
How we can find out who did the paperwork already and is a List
of Contributors published somewhere?–
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Found a hint that there should be a dropbox or shared folder where the recieved aggreements are copied to
Sadly the final links is missing …
2015-09-08 23:25 GMT+02:00 Frank Gasdorf <fgdrf@anonymised.com>:
Ben, not yet
- Frank
2015-09-08 23:17 GMT+02:00 Ben Caradoc-Davies <ben@anonymised.com>:
Did you find out how to access the list of signed agreements? I am not sure it is public. Andrea (project officer), any ideas?
On 09/09/15 09:13, Frank Gasdorf wrote:
How we can find out who did the paperwork already and is a List
of Contributors published somewhere?–
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
On Tue, Sep 8, 2015 at 11:17 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:
Did you find out how to access the list of signed agreements? I am not
sure it is public. Andrea (project officer), any ideas?
Jody is right, they are available only to those who can access that svn
repository...
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
On Tue, Sep 8, 2015 at 11:13 PM, Frank Gasdorf <fgdrf@anonymised.com>
wrote:
Seems that I found what I was looking for :
https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md
Well... yes, it's a starting point. The reviewer should also check if the
pull request is improvement proposal
worthy (large change, or is it changing core public API), and in case of
public API, if the change "makes sense"
among the rest of the existing code (many ways of getting the same result,
some are pretty ugly though),
if it looks or not that it's introducing bugs and regressions, and so on.
A first pass from anybody looking at the easily verifiable bits is
certainly going to help a lot, many
pull requests are failing on the basics, a second check by someone that has
experience
on the module(s) being touched in question is normally a good idea for non
trivial changes.
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
n Tue, Sep 8, 2015 at 10:59 PM, Frank Gasdorf <fgdrf@anonymised.com>
wrote:
Hello everybody,
I just reviewed some pull requests and I'm a bit unsure how to handle
these.Is there a doc/description out there how to handle contributions (here
pull requests) created by others. Does the committer has to sign a CLA or
is it possible to accept requests with a few (e.g. up to 1000) line
changes.
The I believe unwritten agreement was that a patch touching at most one
file was ok to go without a contributor
agreement. That of course does not count the mandatory test, otherwise
there would be no pull request
that we can accept (since we accept basically none without a test)
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
On Tue, 8 Sep 2015 03:38:35 PM Jody Garnett wrote:
If you're looking for mine, they are 97 and 98.
Brad