[Geoserver-devel] Import Process

GeoServer GeoServer Developer
1

Hi all,

We were working with some WPS process chaining recently. While looking at the Import Process, we noticed that there was a TODO for a supporting store creation here: https://github.com/geoserver/geoserver/blob/master/src/extension/wps/wps-core/src/main/java/org/geoserver/wps/gs/ImportProcess.java#L142.

Anyhow, for our immediate need, we ended up wrapping and delegating to the GeoServer Import Process to cover the lack of store creation. I think satisfying the todo may require a few lines, and it likely really close to what we already did.

Any objections about a quick PR for that todo? Also, if there are any notes, feel free to pass those on.

Cheers,

Jim

2

PR always welcome, tricky part is of course the test case.

···

On 25 March 2015 at 15:22, Jim Hughes <jnh5y@anonymised.com> wrote:

Hi all,

We were working with some WPS process chaining recently. While looking
at the Import Process, we noticed that there was a TODO for a supporting
store creation here:
https://github.com/geoserver/geoserver/blob/master/src/extension/wps/wps-core/src/main/java/org/geoserver/wps/gs/ImportProcess.java#L142.

Anyhow, for our immediate need, we ended up wrapping and delegating to
the GeoServer Import Process to cover the lack of store creation. I
think satisfying the todo may require a few lines, and it likely really
close to what we already did.

Any objections about a quick PR for that todo? Also, if there are any
notes, feel free to pass those on.

Cheers,

Jim

Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Jody Garnett

3

On Wed, Mar 25, 2015 at 11:22 PM, Jim Hughes <jnh5y@anonymised.com> wrote:

Hi all,

We were working with some WPS process chaining recently. While looking
at the Import Process, we noticed that there was a TODO for a supporting
store creation here:

https://github.com/geoserver/geoserver/blob/master/src/extension/wps/wps-core/src/main/java/org/geoserver/wps/gs/ImportProcess.java#L142
.

Anyhow, for our immediate need, we ended up wrapping and delegating to
the GeoServer Import Process to cover the lack of store creation. I
think satisfying the todo may require a few lines, and it likely really
close to what we already did.

Any objections about a quick PR for that todo? Also, if there are any
notes, feel free to pass those on.

No objection, just wondering how you're going to structure the creation in
terms of input params,
you'll need to pass in a map of values (the connection parameters), do you
already know how it will
look java wise, and wps call wise?

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

4

Hello,

I’m basing the ImportRaster WPS process on the existing GeoServer ImportProcess. My code simply creates an empty CoverageStore using a CatalogBuilder and then passes the parameters to ImportProcess to actually import the coverage.
It looks like ImportProcess always imports the coverage as a GeoTIFF.

I have the WPS working, and it’s sufficient for our needs. I think it will be fairly simple to get into GeoServer, I’m currently working on the test.

Thank you,
Michael Matthews

···

On 03/26/2015 03:10 AM, Andrea Aime wrote:

On Wed, Mar 25, 2015 at 11:22 PM, Jim Hughes <jnh5y@anonymised.com> wrote:

Hi all,

We were working with some WPS process chaining recently. While looking
at the Import Process, we noticed that there was a TODO for a supporting
store creation here:
https://github.com/geoserver/geoserver/blob/master/src/extension/wps/wps-core/src/main/java/org/geoserver/wps/gs/ImportProcess.java#L142.

Anyhow, for our immediate need, we ended up wrapping and delegating to
the GeoServer Import Process to cover the lack of store creation. I
think satisfying the todo may require a few lines, and it likely really
close to what we already did.

Any objections about a quick PR for that todo? Also, if there are any
notes, feel free to pass those on.

No objection, just wondering how you’re going to structure the creation in terms of input params,
you’ll need to pass in a map of values (the connection parameters), do you already know how it will
look java wise, and wps call wise?

Cheers
Andrea

–

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

5

Hello,

I’ve submitted a PR for GEOS-6970.
I’ve written two tests for creating a vector layer and a raster layer.

Most of the code for creating a raster layer already existed, it just used a default name for the store. My code just handles the case when a store name is provided but the store doesn’t exist.
The raster store defaults to a GeoTiff store.

Let me know if there’s anything that could use polishing.

Thank you,
Michael Matthews

···

On 03/26/2015 03:10 AM, Andrea Aime wrote:

On Wed, Mar 25, 2015 at 11:22 PM, Jim Hughes <jnh5y@anonymised.com> wrote:

Hi all,

We were working with some WPS process chaining recently. While looking
at the Import Process, we noticed that there was a TODO for a supporting
store creation here:
https://github.com/geoserver/geoserver/blob/master/src/extension/wps/wps-core/src/main/java/org/geoserver/wps/gs/ImportProcess.java#L142.

Anyhow, for our immediate need, we ended up wrapping and delegating to
the GeoServer Import Process to cover the lack of store creation. I
think satisfying the todo may require a few lines, and it likely really
close to what we already did.

Any objections about a quick PR for that todo? Also, if there are any
notes, feel free to pass those on.

No objection, just wondering how you’re going to structure the creation in terms of input params,
you’ll need to pass in a map of values (the connection parameters), do you already know how it will
look java wise, and wps call wise?

Cheers
Andrea

–

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

6

Some feedback provided on https://github.com/geoserver/geoserver/pull/1006

I had some questions which we may need Andrea to answer, other than that please update the header for the modified files.

···

On 7 April 2015 at 09:48, Michael Matthews <mmatthews@anonymised.com> wrote:

Hello,

I’ve submitted a PR for GEOS-6970.
I’ve written two tests for creating a vector layer and a raster layer.

Most of the code for creating a raster layer already existed, it just used a default name for the store. My code just handles the case when a store name is provided but the store doesn’t exist.
The raster store defaults to a GeoTiff store.

Let me know if there’s anything that could use polishing.

Thank you,
Michael Matthews

On 03/26/2015 03:10 AM, Andrea Aime wrote:

BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Jody Garnett

On Wed, Mar 25, 2015 at 11:22 PM, Jim Hughes <jnh5y@anonymised.com> wrote:

Hi all,

We were working with some WPS process chaining recently. While looking
at the Import Process, we noticed that there was a TODO for a supporting
store creation here:
https://github.com/geoserver/geoserver/blob/master/src/extension/wps/wps-core/src/main/java/org/geoserver/wps/gs/ImportProcess.java#L142.

Anyhow, for our immediate need, we ended up wrapping and delegating to
the GeoServer Import Process to cover the lack of store creation. I
think satisfying the todo may require a few lines, and it likely really
close to what we already did.

Any objections about a quick PR for that todo? Also, if there are any
notes, feel free to pass those on.

No objection, just wondering how you’re going to structure the creation in terms of input params,
you’ll need to pass in a map of values (the connection parameters), do you already know how it will
look java wise, and wps call wise?

Cheers
Andrea

–

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.