[Geoserver-devel] Jalopy screwing up our sources (stop the commits!!!!!)

GeoServer GeoServer Developer
1

Hi all,
it seems doing a mvn install screws up completely our sources
after Justin last modifications to the build.

What happens is that mvn jalopy:format works fine, whilst
mvn install triggers jalopy with the following error:

java.io.IOException: Unable to find location 'geoserver/geoserverjalopy.xml' as URL, File or Resource.
         at org.codehaus.mojo.jalopy.Locator.resolveLocation(Locator.java:129)
         at org.codehaus.mojo.jalopy.JalopyMojo.createJalopy(JalopyMojo.java:224)
         at org.codehaus.mojo.jalopy.JalopyMojo.formatFiles(JalopyMojo.java:174)

When this happens, you can kiss your modifications goodbay, or
if you don't notice, like Alessio, commit a slew of modified files,
because Jalopy will use its built-in conventions, that are different
from ours...

People, please do not mvn install until we solve this one too
Cheers
Andrea

2

Andrea Aime ha scritto:

Hi all,
it seems doing a mvn install screws up completely our sources
after Justin last modifications to the build.

What happens is that mvn jalopy:format works fine, whilst
mvn install triggers jalopy with the following error:

Update... this is real funny, I can't reproduce the error
always, it just happens sometimes, and can't tell what's
triggering it...

Cheers
Andrea

3

Ugh, formatting is turning out to be more trouble than it is worth imho.
My apologies for committing the modifications without more rigorous
testing.

So the question is how do we proceed?

Andrea Aime wrote:

Hi all,
it seems doing a mvn install screws up completely our sources
after Justin last modifications to the build.

What happens is that mvn jalopy:format works fine, whilst
mvn install triggers jalopy with the following error:

java.io.IOException: Unable to find location
'geoserver/geoserverjalopy.xml' as URL, File or Resource.
         at
org.codehaus.mojo.jalopy.Locator.resolveLocation(Locator.java:129)
         at
org.codehaus.mojo.jalopy.JalopyMojo.createJalopy(JalopyMojo.java:224)
         at
org.codehaus.mojo.jalopy.JalopyMojo.formatFiles(JalopyMojo.java:174)

When this happens, you can kiss your modifications goodbay, or
if you don't notice, like Alessio, commit a slew of modified files,
because Jalopy will use its built-in conventions, that are different
from ours...

People, please do not mvn install until we solve this one too
Cheers
Andrea

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:1004,45db2394160681425493344!

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

4

Actually it appears i cannot replicate the problem on my machine. Ugh!!!
Very frustrating. But yeah, please proceed as you see fit since you and
Alessio are stuck at the moment.

Justin Deoliveira wrote:

Ugh, formatting is turning out to be more trouble than it is worth imho.
My apologies for committing the modifications without more rigorous
testing.

So the question is how do we proceed?

Andrea Aime wrote:

Hi all,
it seems doing a mvn install screws up completely our sources
after Justin last modifications to the build.

What happens is that mvn jalopy:format works fine, whilst
mvn install triggers jalopy with the following error:

java.io.IOException: Unable to find location
'geoserver/geoserverjalopy.xml' as URL, File or Resource.
         at
org.codehaus.mojo.jalopy.Locator.resolveLocation(Locator.java:129)
         at
org.codehaus.mojo.jalopy.JalopyMojo.createJalopy(JalopyMojo.java:224)
         at
org.codehaus.mojo.jalopy.JalopyMojo.formatFiles(JalopyMojo.java:174)

When this happens, you can kiss your modifications goodbay, or
if you don't notice, like Alessio, commit a slew of modified files,
because Jalopy will use its built-in conventions, that are different
from ours...

People, please do not mvn install until we solve this one too
Cheers
Andrea

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

5

Justin Deoliveira ha scritto:

Ugh, formatting is turning out to be more trouble than it is worth imho.
My apologies for committing the modifications without more rigorous
testing.

So the question is how do we proceed?

Chatting with Justing and testing, we discovered that the issue
is triggered only with a clean maven repo, and running mvn install
(that is, if you run mvn jalopy:format, or run mvn install with
build-configs already in, there are no issues).

I'm going to change back to the old situation, and enable jalopy
only on some modules, just like in gt2, since there is seems to
work fine. If it works, I'll commit.

Develoers, please be patient, we're working for you :slight_smile:
Cheers
Andrea