[Geoserver-devel] Jetty JNDI support

I just got embedded Jetty JNDI support working, to allow me to debug GeoServer JNDI data source configurations in Eclipse with an external jetty.xml to configure a connection pool. Yes, my recent exposure to JNDI has driven me mad with power.

I needed to add jetty-plus and jetty-naming, which draw in geronimo and derby, and a few lines to web-app Start.java. The dependencies are test-phase only, so should not increase bloat. I am not sure all this is needed; I will try to pare it back.

Jetty doesn't bother with requiring resource-ref in web.xml, so things are a bit easier than expected.

Any objections?

Who is responsible for maintaining web-app Start.jar?

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer, CSIRO Exploration and Mining
Australian Resources Research Centre
26 Dick Perry Ave, Kensington WA 6151, Australia

Hey Ben,

No big objections since they are test dependencies but I would say that if we can exclude geronimo and derby via maven dependency exclusions we should try to do so.

As for maintaining web-app Start.java, Andrea implemented it originally but I am not sure it has a designated maintainer. Although a patch for people to review and try out is always nice.

Nice work by the way :slight_smile:

-Justin

Ben Caradoc-Davies wrote:

I just got embedded Jetty JNDI support working, to allow me to debug GeoServer JNDI data source configurations in Eclipse with an external jetty.xml to configure a connection pool. Yes, my recent exposure to JNDI has driven me mad with power.

I needed to add jetty-plus and jetty-naming, which draw in geronimo and derby, and a few lines to web-app Start.java. The dependencies are test-phase only, so should not increase bloat. I am not sure all this is needed; I will try to pare it back.

Jetty doesn't bother with requiring resource-ref in web.xml, so things are a bit easier than expected.

Any objections?

Who is responsible for maintaining web-app Start.jar?

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Justin Deoliveira wrote:

No big objections since they are test dependencies but I would say that if we can exclude geronimo and derby via maven dependency exclusions we should try to do so.

OK, I will try.

As for maintaining web-app Start.java, Andrea implemented it originally but I am not sure it has a designated maintainer. Although a patch for people to review and try out is always nice.

Jira issue plus patch for review is in my view mandatory. I will try the exclusions, tidy up, and submit a patch.

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer, CSIRO Exploration and Mining
Australian Resources Research Centre
26 Dick Perry Ave, Kensington WA 6151, Australia

Justin Deoliveira wrote:

No big objections since they are test dependencies but I would say that if we can exclude geronimo and derby via maven dependency exclusions we should try to do so.

I checked and it is only pulling in geronimo-spec-jta (14 KB). I assume this is OK. I checked again and the Geronimo and Derby deps are "provided", so are not included (thoughtful pom maintainers saved me from myself).

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer, CSIRO Exploration and Mining
Australian Resources Research Centre
26 Dick Perry Ave, Kensington WA 6151, Australia