[Geoserver-devel] [jira] Created: (GEOS-1389) Editing shapefile results in locked layer

GeoServer GeoServer Developer
1

Editing shapefile results in locked layer
-----------------------------------------

                 Key: GEOS-1389
                 URL: http://jira.codehaus.org/browse/GEOS-1389
             Project: GeoServer
          Issue Type: Bug
          Components: WFS
    Affects Versions: 1.5.3, 1.5.2, 1.5.1, 1.5.0
            Reporter: Jody Garnett
            Assignee: Andrea Aime

Origional email from Jesse Eichar:
{panel}
Hi list,

Have you gotten any reports of Geoserver 1.5.3 getting locked on a dataset after a few edits take place? Here's what I'm doing:
1. Add a geoserver layer (say tasmania roads).
2. Edit it a bunch of times (with uDig, any version as far as I can tell)

Eventually it will lock up (not uDig but rendering that layer). I can close the map and try to the the layer with a WMS. That will also never return (until uDig times out). All other layers are fine.

I kill GeoServer and it looks like it is deadlocking on the Shapefile Lock... Sounds like my fault :frowning: or possibly a result of one of Andreas changes and I missed the mistake as well.

I think one of two things are happening:

1. The lock has an internal race condition and should be replaced with a Java 5 Read/Write lock
2. Some object is aquiring the lock (read or write I don't know right now) and forgetting to release it (or throwing an exception so that it doesn't get released).
{panel}

We tested every version of GeoServer; the latest version that works in GeoServer 1.4.1 (GeoServer 1.4.0 also works). To reproduce the problem we followed the uDig walkthrough 1 instructions:
# Add Tasmania lakes and Tasmania roads to a map in uDig
# Move a road
# Hit commit

After this first commit GeoServer is unable to draw the roads layer, if you shutdown GeoServer and restart the road will draw again (and you can see that the results of your edit were actually applied).

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

2

     [ http://jira.codehaus.org/browse/GEOS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrea Aime reopened GEOS-1389:
-------------------------------

Nope, this one is still alive, it's just showing up itself in a different way.
Index access code should reset its buffers each time the index is rewritten. At the moment this is not happening and this causes different problems depending on how threads doing reads and writes interact.

Editing shapefile results in locked layer
-----------------------------------------

                Key: GEOS-1389
                URL: http://jira.codehaus.org/browse/GEOS-1389
            Project: GeoServer
         Issue Type: Bug
         Components: WFS
   Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.5.3
           Reporter: Jody Garnett
           Assignee: Andrea Aime
            Fix For: 1.6.0-beta4

Origional email from Jesse Eichar:
{panel}
Hi list,
Have you gotten any reports of Geoserver 1.5.3 getting locked on a dataset after a few edits take place? Here's what I'm doing:
1. Add a geoserver layer (say tasmania roads).
2. Edit it a bunch of times (with uDig, any version as far as I can tell)
Eventually it will lock up (not uDig but rendering that layer). I can close the map and try to the the layer with a WMS. That will also never return (until uDig times out). All other layers are fine.
I kill GeoServer and it looks like it is deadlocking on the Shapefile Lock... Sounds like my fault :frowning: or possibly a result of one of Andreas changes and I missed the mistake as well.
I think one of two things are happening:
1. The lock has an internal race condition and should be replaced with a Java 5 Read/Write lock
2. Some object is aquiring the lock (read or write I don't know right now) and forgetting to release it (or throwing an exception so that it doesn't get released).
{panel}
We tested every version of GeoServer; the latest version that works in GeoServer 1.4.1 (GeoServer 1.4.0 also works). To reproduce the problem we followed the uDig walkthrough 1 instructions:
# Add Tasmania lakes and Tasmania roads to a map in uDig
# Move a road
# Hit commit
After this first commit GeoServer is unable to draw the roads layer, if you shutdown GeoServer and restart the road will draw again (and you can see that the results of your edit were actually applied).

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira