ResourcePool uses significant resources building renaming datastores
--------------------------------------------------------------------
Key: GEOS-2545
URL: http://jira.codehaus.org/browse/GEOS-2545
Project: GeoServer
Issue Type: Bug
Components: Global
Affects Versions: 1.7.1, 1.7.0
Reporter: Andrea Aime
Assignee: Justin Deoliveira
Fix For: 1.7.2
During benchmarks I noticed how renaming a feature type incurs in quite an overhead. Looking into it I discovered that a new RetypeingDataStore is created each time the renamed feature source is created. Due to the way the renaming datastore works, it requires to gather the full list of all type names from the original data store so that a getFeatureSource(name) request can be answered (the name transformation goes one way only, it's not meant to be necessarily invertible). When the wrapped datastore is postgis, this may require a lot of time (proportional to the number of layers available in the datastore).
It would be better to cache the renaming datastore as we cache the original ones. The alternative would require changing the retyping datastore so that it can do reverse name transformations... which I can do, thought it may not be trivial (and I would have to check the CITE tests pass on a fully renamed configuration).
Opinions? (btw, assigned to you just for the sake of discussion, I'll take it back when we have a decision)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.codehaus.org/browse/GEOS-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Aime reopened GEOS-2545:
-------------------------------
Yeah, confirmed. Bruce, please provide a patch, there are not enough developers doing and way too many users asking
ResourcePool uses significant resources building renaming datastores
--------------------------------------------------------------------
Key: GEOS-2545
URL: http://jira.codehaus.org/browse/GEOS-2545
Project: GeoServer
Issue Type: Bug
Components: Global
Affects Versions: 1.7.0 , 1.7.1
Reporter: Andrea Aime
Assignee: Andrea Aime
Fix For: 2.0.3
During benchmarks I noticed how renaming a feature type incurs in quite an overhead. Looking into it I discovered that a new RetypeingDataStore is created each time the renamed feature source is created. Due to the way the renaming datastore works, it requires to gather the full list of all type names from the original data store so that a getFeatureSource(name) request can be answered (the name transformation goes one way only, it's not meant to be necessarily invertible). When the wrapped datastore is postgis, this may require a lot of time (proportional to the number of layers available in the datastore).
It would be better to cache the renaming datastore as we cache the original ones. The alternative would require changing the retyping datastore so that it can do reverse name transformations... which I can do, thought it may not be trivial (and I would have to check the CITE tests pass on a fully renamed configuration).
Opinions? (btw, assigned to you just for the sake of discussion, I'll take it back when we have a decision)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira