[Geoserver-devel] [jira] Created: (GEOS-3532) Services report and/or disabled, or rather non reachable, resources by checking isEnabled() instead of enabled()

Services report and/or disabled, or rather non reachable, resources by checking isEnabled() instead of enabled()
----------------------------------------------------------------------------------------------------------------

                 Key: GEOS-3532
                 URL: http://jira.codehaus.org/browse/GEOS-3532
             Project: GeoServer
          Issue Type: Bug
    Affects Versions: 2.0-RC1
            Reporter: Gabriel Roldán
            Assignee: Gabriel Roldán
             Fix For: 2.0-RC2

Some operations that should only take place against available resources (aka, {{ResourceInfo}}) check whether the resource is available using {{ResourceInfo.isEnabled()}} instead of the derived property {{ResourceInfo.enabled()}}. Difference being the later also checks if it's parent {{StoreInfo}} is enabled.

The {{enabled()}} derived property was first introduced in order for the UI to report what layers are available, hence {{LayerInfo.enabled()}}} depends on it's enabled state as well as it's associated ResourceInfo and StoreInfo. But the use of enabled() in service code was missing so far. So update all service code that should take an action over a Resource depending on whether it is "available" to use enabled() instead of isEnabled(). They're mostly capabilities transformers and other bulk resource service code.

Side effects are:
- WFS/WCS capabilities report resources as available when they're not
- WFS schema builder tried to build the schema for non available FeatureTypeInfos, leading to attemps to lead disabled DataStores and potentially failing because of that

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira