URLMangler support in KML/GeoRSS
--------------------------------
Key: GEOS-4577
URL: http://jira.codehaus.org/browse/GEOS-4577
Project: GeoServer
Issue Type: Improvement
Components: Google Earth KML Output, WMS
Affects Versions: 2.1.0
Reporter: Robert Coup
Assignee: Andrea Aime
Attachments: gs21-kml-urlmangler.1.diff
[URLMangler support|http://geoserver.org/display/GEOS/GSIP+39+-+Centralized,+pluggable+URL+mangling\] [didn't make it|http://thread.gmane.org/gmane.comp.gis.geoserver.user/27828\] into KML Network Links (or GeoRSS, as it turns out).
I've attached a patch against 2.1.x that replaces all the manual URL-assembling that I can find in the KML code with calls to {{ResponseUtils.buildURL()}} (which uses URLMangler), and deprecates the use of {{WMSRequests.getBaseUrl()}}.
I also expanded buildURL() to handle null values in KVP parameters since they seemed to pop up in a number of places. Now, {{{"key1":null, "key2":"val"}}} resolves to {{"...&key1=&key2=val"}}.
In my limited testing the patch works as expected, and the test suite passes. If someone can have a quick once-over and suggest whether the approach is right, and whether new tests are required, that'd be great.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira