restconfig tests leave test db files in module root
---------------------------------------------------
Key: GEOS-4692
URL: https://jira.codehaus.org/browse/GEOS-4692
Project: GeoServer
Issue Type: Bug
Components: REST
Affects Versions: 2.2.x
Reporter: Ben Caradoc-Davies
Assignee: Andrea Aime
Priority: Minor
Fix For: 2.2.x
restconfig tests often leave one or both of these files in the module root:
foo.2.log.db
pds.2.log.db
This is not the correct location for test input, which should live in src/test/resources.
This is not the correct location for test output, which should live in target so it can be cleaned.
These files are not listed in svn:ignore. Before now I was able to place:
src/restconfig/foo.2.log.db
src/restconfig/pds.2.log.db
in my .gitignore and was able to ignore this minor mess, but in r16201 jdeolive inadvertently(?) committed foo.2.log.db . Now that this file has been committed, git will not ignore it. When tests run, foo.2.log.db is either modified or deleted, creating bogus local changes and preventing further "git svn rebase" or branch switching.
In a few minutes I am going to delete foo.2.log.db from svn and then add these two files to svn:ignore to protect svn users. All git users should add:
src/restconfig/foo.2.log.db
src/restconfig/pds.2.log.db
to their .gitignore so these files are not inadvertently captured by "git add --all".
I have created this issue to ask the module maintainer to consider fixing these tests so that their output is confined to target where it is not going to cause any VCS problems. Is the use of the module root an h2 limitation?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira