[Geoserver-devel] [jira] Created: (GEOS-570) The url from a wfs datastore is not properly encoded for xml

The url from a wfs datastore is not properly encoded for xml
------------------------------------------------------------

         Key: GEOS-570
         URL: http://jira.codehaus.org/browse/GEOS-570
     Project: GeoServer
        Type: Bug

  Components: Error Reporting
    Versions: 1.3.0
Environment: All
    Reporter: Magne Skjeret
Assigned to: Chris Holmes

When adding a new cascading wfs datastore the url is not properly encoded in catalog.xml

Adding the url: http://127.0.0.1/wfsconnector/com.esri.wfs.Esrimap?REQUEST=GetCapabilities&Service=WFS
The catalog.xml will contain this:

<connectionParams>
  <parameter value = "topp" name = "namespace" />
  <parameter value = "false" name = "WFSDataStoreFactory:PROTOCOL" />
  <parameter value = "http://127.0.0.1/wfsconnector/com.esri.wfs.Esrimap?REQUEST=GetCapabilities&Service=WFS&quot; name = "WFSDataStoreFactory:GET_CAPABILITIES_URL" />
  <parameter value = "" name = "WFSDataStoreFactory:PASSWORD" />
  <parameter value = "" name = "WFSDataStoreFactory:USERNAME" />
</connectionParams>

That is invalid xml.

It should be like this:
<connectionParams>
  <parameter value = "topp" name = "namespace" />
  <parameter value = "false" name = "WFSDataStoreFactory:PROTOCOL" />
  <parameter value = "http://127.0.0.1/wfsconnector/com.esri.wfs.Esrimap?REQUEST=GetCapabilities&amp;Service=WFS&quot; name = "WFSDataStoreFactory:GET_CAPABILITIES_URL" />
  <parameter value = "" name = "WFSDataStoreFactory:PASSWORD" />
  <parameter value = "" name = "WFSDataStoreFactory:USERNAME" />
</connectionParams>

Since the & is not encoded, even welcome.do fails.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira