Register GetMapProducers directly and remove the factories
----------------------------------------------------------
Key: GEOS-654
URL: http://jira.codehaus.org/browse/GEOS-654
Project: GeoServer
Type: Improvement
Components: WMS
Versions: 1.4.0-M0
Reporter: Andrea Aime
Assigned to: Gabriel Roldán
Priority: Minor
For the moment we do have GetMapProducerSpi and GetMapProducer, and we do register the factories onto the context.
I suggest to remove the factories and register directly the GetMapProducer, since it's simpler.
For producers that are not thread safe, just register them as prototypes.
For producers that do need external configuration to decide on a code path (like svg), just add a delegate producers that performs the decision.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[ http://jira.codehaus.org/browse/GEOS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Deoliveira reopened GEOS-654:
------------------------------------
The new code does a straight equals() match against the output format string. But this often does not suffice for cases like kml where the output format is specified with a "+" which gets stripped out, so a looser check is required.
I am surprised there are no unit tests that catch this one. I think before continuing with this improvement we should have a unit test for each output format.
Register GetMapProducers directly and remove the factories
----------------------------------------------------------
Key: GEOS-654
URL: http://jira.codehaus.org/browse/GEOS-654
Project: GeoServer
Issue Type: Improvement
Components: WMS
Affects Versions: 1.7.0-RC1
Reporter: Andrea Aime
Assignee: Gabriel Roldán
Priority: Minor
Fix For: 1.7.0
Original Estimate: 1 day
Remaining Estimate: 1 day
For the moment we do have GetMapProducerSpi and GetMapProducer, and we do register the factories onto the context.
I suggest to remove the factories and register directly the GetMapProducer, since it's simpler.
For producers that are not thread safe, just register them as prototypes.
For producers that do need external configuration to decide on a code path (like svg), just add a delegate producers that performs the decision.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira