Not sure how this happened, but the Geoserver Maven artifacts have been published with SNAPSHOT versions of Geotools (28-SNAPSHOT) and GWC (1.22-SNAPSHOT) versions.
Not sure how this is possible using Maven release procedures…
The zip download from Sourceforge has the same problem; it has SNAPSHOT versions of Geotools and GWC packaged.
This is problematic as we build our own war file using Maven for docker deployments using war overlay techniques and the behaviour concerning Geotools and GWC is now undetermined (also because Geotools 28-SNAPSHOT could be any 28 version prior or after the actual tag of 28.1…
Hi, I’ve spent some time investigating what happened, I believe it’s user error caused by confusing parameters and a bug in the release script…
The build has these two parameters, that I normally don’t touch, set to “skip”:
I normally don’t touch them due to lack of understanding, but the description seems to suggest “skip GT build”, which is indeed
something we don’t need during a release, the upstream builds are done already.
But looking at how they work in build_release.sh, they skip the build but also skip setting gt_tag and gwc_tag,
which then are used to update the version numbers in the pom files.
Seems like a bug in the logic of the release script IMHO, but for now, better not set those to “skip” and let them do the extra, unnecessary builds.
I am glad we have an answer.
Personally I understood those parameters only did a build when a revision was supplied; if an actual release tag is used no building is required?
I understand that these were used to issue an emergency hotfix in the past. Now we tend to just make another geotools release if a critical fix is required.
if an actual release tag is used no building is required?
In theory, yes, fully agree, no build needed. In practice the build script, as written today, bundles doing a build with
updating the pom file version numbers for gwc/gt (indirectly, see my explanation above and the code).
That’s a bug in my book, but I have no spare cycles to fix it.
I understand that these were used to issue an emergency hotfix in the past. Now we tend to just make another geotools release if a critical fix is required.
Perhaps these options could be removed?
That’s also a possibility. Or another alternative, explain the risks of using them.
Cheers
Andrea
···
==
GeoServer Professional Services from the experts!
Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail
Medium
