[Geoserver-devel] [jira] (GEOS-5004) Allow ":" in SQL view parameter values without escaping

Robert Coup created GEOS-5004:
---------------------------------

             Summary: Allow ":" in SQL view parameter values without escaping
                 Key: GEOS-5004
                 URL: https://jira.codehaus.org/browse/GEOS-5004
             Project: GeoServer
          Issue Type: Improvement
    Affects Versions: 2.1.x, 2.2.x
            Reporter: Robert Coup
            Assignee: Andrea Aime
            Priority: Minor
         Attachments: kvp-parser.2-1-x.patch, kvp-parser.trunk.patch

FormatOptionsKvpParser is used by SQL view parameters, among other things.

Currently to pass in (eg.) an ISO-style timestamp as a view parameter, you need to do:

{code}&viewparams=from:2012-01-01T12\:33\:18+0500;to:2012-02-01T12\:33\:18+0500{code}

Would be a lot nicer to avoid the escaping of subsequent ':' and just treat everything up to the next ';' as the value. You can escape ';' via '\;' as before.

{code}&viewparams=from:2012-01-01T12:33:18+0500;to:2012-02-01T12:33:18+0500{code}

Turns out this is pretty easy. Patches/Tests attached against 2.1.x and trunk.

If your key needs ':' you can escape it still via 'my\:key:my:value;' => 'my:key'='my:value'. And previous over-escaping keeps working fine as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira