[Geoserver-devel] [jira] (GEOS-5041) Broken File/URL conversions in security

Ben Caradoc-Davies created GEOS-5041:
----------------------------------------

             Summary: Broken File/URL conversions in security
                 Key: GEOS-5041
                 URL: https://jira.codehaus.org/browse/GEOS-5041
             Project: GeoServer
          Issue Type: Bug
          Components: Security
         Environment: Maven 3
            Reporter: Ben Caradoc-Davies
            Assignee: Andrea Aime
            Priority: Blocker

Th new security password provider is broken in any data directory that contains special characters such as spaces, causing the build to fail:

{noformat}
Tests in error:
  testEncryption(org.geoserver.security.password.URLMasterPasswordProviderTest): /home/car605/geoserver/src%20with%20spaces/geoserver-trunk/src/main/target/passwd1191987093163736111tmp (No such file or directory)
  testMasterPasswordChange(org.geoserver.security.password.MasterPasswordChangeTest): java.io.FileNotFoundException: /home/car605/geoserver/src%20with%20spaces/geoserver-trunk/src/main/./target/mock2049237527189537102data/security/mpw1.properties (No such file or directory)
{noformat}

Deployments will also be affected. The underlying problem is code like:

{noformat}
File f = new File(url.getFile());
{noformat}

in URLMasterpasswordProvider that does not use DataUtilities as required by the project conventions:

http://docs.geotools.org/latest/developer/conventions/code/url.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Ben Caradoc-Davies reopened BugGEOS-5041
Broken File/URL conversions in security

Change By:

Ben Caradoc-Davies (23/May/12 12:02 AM)

Assignee:

Justin Deoliveira Ben Caradoc-Davies

Status:

Closed Reopened

Resolution:

Fixed

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your [JIRA administrators](https://jira.codehaus.org/secure/ContactAdministrators!default.jspa). For more information on JIRA, see: [http://www.atlassian.com/software/jira](http://www.atlassian.com/software/jira)