[Geoserver-devel] [JIRA] (GEOS-7457) Bad System.out.println logging usage

GeoServer GeoServer Developer
1

Landry Breuil created an issue

GeoServer / BugGEOS-7457

Bad System.out.println logging usage

Issue Type:

BugBug

Affects Versions:

2.8.2

Assignee:

Unassigned

Components:

Global

Created:

14/Mar/16 10:51 AM

Environment:

Tomcat 8, debian jessie

Priority:

LowLow

Reporter:

Landry Breuil

The xslt extension uses System.out.println() to print debugging info instead of properly using geoserver logging, which can uselessly fill out catalina.out.

While i can understand system.out.println() being used in tests, it shouldn’t appear in production code…
https://github.com/geoserver/geoserver/blob/master/src/extension/xslt/src/main/java/org/geoserver/wfs/xslt/XSLTOutputFormat.java#L83 is trigerred quite often here, and https://github.com/geoserver/geoserver/blob/master/src/extension/xslt/src/main/java/org/geoserver/wfs/xslt/XSLTOutputFormat.java#L95 happens too.

https://github.com/geoserver/geoserver/search?utf8=%E2%9C%93&q=%22System.out.println%22&type=Code

Add Comment

Add Comment

This message was sent by Atlassian JIRA (v7.2.0-OD-03-014#72000-sha1:1e7aa97)

Atlassian logo