[Geoserver-devel] [Jsonp] Adding Json and JsonP support to response and exception handlers

GeoServer GeoServer Developer
1

Hi all,
my name is Carlo Cancellieri and I’m working for GeoSolutions S.A.S. on GeoServer to add some response and exceptions handlers to get responses and exceptions in json and jsonp format.

Here is the list of provided Improvements (some of the following are produced by Andrea A. or Simone G.):

The target branch is 2.2.x.

Is it possible to merge those improvements into geoserver?
Do you need some more info?
Cheers,
Carlo Cancellieri

–

==

Our support, Your Success! Visit [http://opensdi.geo-solutions.it](http://opensdi.geo-solutions.it/) for more information.
==

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
mobile: +39 3371094494
fax:   +39 0584 962313

[http://www.geo-solutions.it](http://www.geo-solutions.it/)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
2

On Wed, Aug 1, 2012 at 4:40 PM, carlo cancellieri <ccancellieri@anonymised.com> wrote:

Hi all,
my name is Carlo Cancellieri and I’m working for GeoSolutions S.A.S. on GeoServer to add some response and exceptions handlers to get responses and exceptions in json and jsonp format.

Here is the list of provided Improvements (some of the following are produced by Andrea A. or Simone G.):

The target branch is 2.2.x.

Is it possible to merge those improvements into geoserver?
Do you need some more info?

Carlo, most of the changes are purely additive and small, the question for those is whether
they can land directly on 2.2.x. Given the interest on json and jsonp I guess
that would be a good idea for 2.2.1, but you should explain how the requests are going to work,
make some example of the requests (params) and how the outputs will look like.

You should explain the changes for DescribeLayer, which now handles only
one output format and after will have two, with two new Response objects making
the output format actually pluggable: this one is a API change, needs some explanation
of how the API will look like

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

3

On Wed, Aug 1, 2012 at 12:27 PM, Andrea Aime
<andrea.aime@anonymised.com> wrote:

On Wed, Aug 1, 2012 at 4:40 PM, carlo cancellieri <ccancellieri@anonymised.com>
wrote:

Hi all,
my name is Carlo Cancellieri and I'm working for GeoSolutions S.A.S. on
GeoServer to add some response and exceptions handlers to get responses and
exceptions in json and jsonp format.

Here is the list of provided Improvements (some of the following are
produced by Andrea A. or Simone G.):
- Adding JsonP output format to the WFS Describe
- Adding JsonP output format to WMS GetFeatureInfo
[Ongoing]
- Add Json[P] support to WMS DescribeLayer [missing tests]
- Adding JsonP support to WMSServiceExceptionHandler [todo]

The target branch is 2.2.x.

Is it possible to merge those improvements into geoserver?
Do you need some more info?

Carlo, most of the changes are purely additive and small, the question for
those is whether
they can land directly on 2.2.x. Given the interest on json and jsonp I
guess
that would be a good idea for 2.2.1, but you should explain how the requests
are going to work,
make some example of the requests (params) and how the outputs will look
like.

Carlo, looks like a straight forward patch. I personally have no
objection for it to land on the 2.2.x branch. Agree with Andrea in
that a couple sample requests and some doc would be in place though.

You should explain the changes for DescribeLayer, which now handles only
one output format and after will have two, with two new Response objects
making
the output format actually pluggable: this one is a API change, needs some
explanation
of how the API will look like

After a cursory look at the patch, I don't think it even qualifies as
an API change. The only "API change" I can see is the change in the
return type of the WebMapService.describeLayer operation:
<https://github.com/ccancellieri/geoserver/commit/2a9709b219e1c730d85fb467747e5de2a57f159b#L4L47&gt;

But DefaultWebMapService was already narrowing the return type. The
API and workflow is the same, imposed by the Dispatcher framework, so
any Response found on the app context that can handle whatever it is
that the operation returns will work. That is to say, I don't think
the changes deserve much explanation, at least I'm missing something
obvious, which can well be as I made just a cursory look at the patch.

Cheers,
Gabriel

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

4

Thank you Andrea,
I will add examples and descriptions here:

https://jira.codehaus.org/browse/GEOS-5246
https://jira.codehaus.org/browse/GEOS-5247
Regards,
Carlo

Date: Wed, 1 Aug 2012 17:27:48 +0200
Subject: Re: [Geoserver-devel] [Jsonp] Adding Json and JsonP support to response and exception handlers
From: andrea.aime@anonymised.com
To: ccancellieri@anonymised.com
CC: geoserver-devel@lists.sourceforge.net

On Wed, Aug 1, 2012 at 4:40 PM, carlo cancellieri <ccancellieri@anonymised.com.21…> wrote:

Hi all,
my name is Carlo Cancellieri and I’m working for GeoSolutions S.A.S. on GeoServer to add some response and exceptions handlers to get responses and exceptions in json and jsonp format.

Here is the list of provided Improvements (some of the following are produced by Andrea A. or Simone G.):

The target branch is 2.2.x.

Is it possible to merge those improvements into geoserver?
Do you need some more info?

Carlo, most of the changes are purely additive and small, the question for those is whether
they can land directly on 2.2.x. Given the interest on json and jsonp I guess
that would be a good idea for 2.2.1, but you should explain how the requests are going to work,
make some example of the requests (params) and how the outputs will look like.

You should explain the changes for DescribeLayer, which now handles only
one output format and after will have two, with two new Response objects making
the output format actually pluggable: this one is a API change, needs some explanation
of how the API will look like

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

5

Hi Gabriel,
thank you for your reply, (following inline).

From: groldan@anonymised.com
Date: Wed, 1 Aug 2012 16:25:13 -0300
Subject: Re: [Geoserver-devel] [Jsonp] Adding Json and JsonP support to response and exception handlers
To: andrea.aime@anonymised.com
CC: ccancellieri@anonymised.com; geoserver-devel@lists.sourceforge.net

On Wed, Aug 1, 2012 at 12:27 PM, Andrea Aime
<andrea.aime@anonymised.com268…> wrote:

On Wed, Aug 1, 2012 at 4:40 PM, carlo cancellieri ccancellieri@anonymised.com
wrote:

Hi all,
my name is Carlo Cancellieri and I’m working for GeoSolutions S.A.S. on
GeoServer to add some response and exceptions handlers to get responses and
exceptions in json and jsonp format.

Here is the list of provided Improvements (some of the following are
produced by Andrea A. or Simone G.):

  • Adding JsonP output format to the WFS Describe
  • Adding JsonP output format to WMS GetFeatureInfo
    [Ongoing]
  • Add Json[P] support to WMS DescribeLayer [missing tests]
  • Adding JsonP support to WMSServiceExceptionHandler [todo]

The target branch is 2.2.x.

Is it possible to merge those improvements into geoserver?
Do you need some more info?

Carlo, most of the changes are purely additive and small, the question for
those is whether
they can land directly on 2.2.x. Given the interest on json and jsonp I
guess
that would be a good idea for 2.2.1, but you should explain how the requests
are going to work,
make some example of the requests (params) and how the outputs will look
like.

Carlo, looks like a straight forward patch. I personally have no
objection for it to land on the 2.2.x branch. Agree with Andrea in
that a couple sample requests and some doc would be in place though.

I’ll provide documentation and JUnit tests, ASAP.

You should explain the changes for DescribeLayer, which now handles only
one output format and after will have two, with two new Response objects
making
the output format actually pluggable: this one is a API change, needs some
explanation
of how the API will look like

After a cursory look at the patch, I don’t think it even qualifies as
an API change. The only “API change” I can see is the change in the
return type of the WebMapService.describeLayer operation:
https://github.com/ccancellieri/geoserver/commit/2a9709b219e1c730d85fb467747e5de2a57f159b#L4L47

But DefaultWebMapService was already narrowing the return type. The
API and workflow is the same, imposed by the Dispatcher framework, so
any Response found on the app context that can handle whatever it is
that the operation returns will work. That is to say, I don’t think
the changes deserve much explanation, at least I’m missing something
obvious, which can well be as I made just a cursory look at the patch.

Currently I’ve submitted the patched war to our test team to tests new features and their real needs (about additional vendor parameters and used versions).
I’m confident that those patches can be merged to the 2.3.x branch and backported to the 2.2.1 version once junit tests and docs will be completed.
Thank you,
Carlo

Cheers,
Gabriel

Cheers
Andrea

–

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.