On Monday 28 April 2008 06:36:23 pm Justin Deoliveira wrote:
Hi Gabriel,
(did you mean this for GeoServer-devel?)
I guess so.
created <http://jira.codehaus.org/browse/GEOS-1888> so we don't forget.
Cheers,
Gabriel
You bring up a good issue. One I have thought about. Andrea brought up
the same thing while implementing WCS as well. So what we did was
allowed a KvpParser to be bound to a particular service, or ... be bound
to all services.So we could go through and ensure that all wfs kvp readers only engage
for WFS, and re-register the ones that are being reused for wms. This
would remove the configuration dependency, still allow us to share the
code, and would be more explicit.Gabriel Roldán wrote:
> Hi,
>
> As you know, geoserver ows's may share kvp parsers, but I'm not sure if
> sharing both code and configuration is the best thing to do.
> Right now, to put an example, wms shares the maxFeatures kvp parser with
> wfs, which imposes a configuration dependency over the wfs module.
> This happens with more parsers I don't exactly remember of the top of my
> head, but imho its ok to share code but bad to share configuration.
>
> So I wanted to bring the topic and see what others think. I think it
> would be ideal to have per service specific kvp parser configurations
> regardless of whether they share the same parser implementation, though
> I'm not sure how we could do that. Justin?
>
> Cheers,
>
> Gabriel
>