[Geoserver-devel] Layer preview filtering capabilities activation

Hi,

I just made this PR [1] that fix this issue [2].

Currently when doing a layer preview of a coverage (or multiple coverages) filtering capabilities
(CQL, OGC and FeatureID) are deactivated, they are only active if a vector layer is present. My
PR changes that behavior to activate filtering capabilities if at least one of the used coverage
layers reader supports filtering (e.g. image mosaic).

I would like to backport this to GS 2.11.x right away, this issue is between a bug and an improvement.
The nature of the changes are additive and self contained to the Openlayers output format.

In the users point of view the only difference will be the possibility to use the filtering capabilities when
doing the preview of a coverage whose reader supports filtering.

Any objections to backporting right away ?

Cheers,

[1] https://github.com/geoserver/geoserver/pull/2494
[2] https://osgeo-org.atlassian.net/browse/GEOS-8263

--
Regards,
Nuno Oliveira

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
  The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

+0

Regards,
Simone Giannecchini

GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate.
Il loro utilizzo è consentito esclusivamente al destinatario del
messaggio, per le finalità indicate nel messaggio stesso. Qualora
riceviate questo messaggio senza esserne il destinatario, Vi preghiamo
cortesemente di darcene notizia via e-mail e di procedere alla
distruzione del messaggio stesso, cancellandolo dal Vostro sistema.
Conservare il messaggio stesso, divulgarlo anche in parte,
distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità
diverse, costituisce comportamento contrario ai principi dettati dal
D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely
for the attention and use of the named addressee(s) and may be
confidential or proprietary in nature or covered by the provisions of
privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New
Data Protection Code).Any use not in accord with its purpose, any
disclosure, reproduction, copying, distribution, or either
dissemination, either whole or partial, is strictly forbidden except
previous formal approval of the named addressee(s). If you are not the
intended recipient, please contact immediately the sender by
telephone, fax or e-mail and delete the information in this message
that has been received in error. The sender does not give any warranty
or accept liability as the content, accuracy or completeness of sent
messages and accepts no responsibility for changes made after they
were sent or for other risks which arise as a result of e-mail
transmission, viruses, etc.

On Thu, Aug 24, 2017 at 4:31 PM, Nuno Oliveira
<nuno.oliveira@anonymised.com> wrote:

Hi,

I just made this PR [1] that fix this issue [2].

Currently when doing a layer preview of a coverage (or multiple coverages)
filtering capabilities
(CQL, OGC and FeatureID) are deactivated, they are only active if a vector
layer is present. My
PR changes that behavior to activate filtering capabilities if at least one
of the used coverage
layers reader supports filtering (e.g. image mosaic).

I would like to backport this to GS 2.11.x right away, this issue is between
a bug and an improvement.
The nature of the changes are additive and self contained to the Openlayers
output format.

In the users point of view the only difference will be the possibility to
use the filtering capabilities when
doing the preview of a coverage whose reader supports filtering.

Any objections to backporting right away ?

Cheers,

[1] https://github.com/geoserver/geoserver/pull/2494
[2] https://osgeo-org.atlassian.net/browse/GEOS-8263

--
Regards,
Nuno Oliveira

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i
file/s allegato/i sono da considerarsi strettamente riservate. Il loro
utilizzo è consentito esclusivamente al destinatario del messaggio, per le
finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio
senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia
via e-mail e di procedere alla distruzione del messaggio stesso,
cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo
anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per
finalità diverse, costituisce comportamento contrario ai principi dettati
dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender does
not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Personally, while playing with image mosaic with attributes, this thing had bug-ged me repeatedly.
Glad to see it gone!

+1

Cheers
Andrea

···

On Thu, Aug 24, 2017 at 4:31 PM, Nuno Oliveira <nuno.oliveira@anonymised.com1268…> wrote:

Hi,

I just made this PR [1] that fix this issue [2].

Currently when doing a layer preview of a coverage (or multiple coverages) filtering capabilities
(CQL, OGC and FeatureID) are deactivated, they are only active if a vector layer is present. My
PR changes that behavior to activate filtering capabilities if at least one of the used coverage
layers reader supports filtering (e.g. image mosaic).

I would like to backport this to GS 2.11.x right away, this issue is between a bug and an improvement.
The nature of the changes are additive and self contained to the Openlayers output format.

In the users point of view the only difference will be the possibility to use the filtering capabilities when
doing the preview of a coverage whose reader supports filtering.

Any objections to backporting right away ?

Cheers,

[1] https://github.com/geoserver/geoserver/pull/2494
[2] https://osgeo-org.atlassian.net/browse/GEOS-8263


Regards,
Nuno Oliveira

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

+0. No objection here. While this is a slight behavioural change, it must be backwards compatible and I do not see how the new behaviour can cause any harm.

Kind regards,
Ben.

On 25/08/17 02:31, Nuno Oliveira wrote:

Hi,

I just made this PR [1] that fix this issue [2].

Currently when doing a layer preview of a coverage (or multiple coverages) filtering capabilities
(CQL, OGC and FeatureID) are deactivated, they are only active if a vector layer is present. My
PR changes that behavior to activate filtering capabilities if at least one of the used coverage
layers reader supports filtering (e.g. image mosaic).

I would like to backport this to GS 2.11.x right away, this issue is between a bug and an improvement.
The nature of the changes are additive and self contained to the Openlayers output format.

In the users point of view the only difference will be the possibility to use the filtering capabilities when
doing the preview of a coverage whose reader supports filtering.

Any objections to backporting right away ?

Cheers,

[1] https://github.com/geoserver/geoserver/pull/2494
[2] https://osgeo-org.atlassian.net/browse/GEOS-8263

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

I’d never noticed this but seems harmless +1

Ian

···

On 24 August 2017 at 23:29, Ben Caradoc-Davies <ben@anonymised.com> wrote:

+0. No objection here. While this is a slight behavioural change, it must be backwards compatible and I do not see how the new behaviour can cause any harm.

Kind regards,
Ben.

On 25/08/17 02:31, Nuno Oliveira wrote:

Hi,

I just made this PR [1] that fix this issue [2].

Currently when doing a layer preview of a coverage (or multiple coverages) filtering capabilities
(CQL, OGC and FeatureID) are deactivated, they are only active if a vector layer is present. My
PR changes that behavior to activate filtering capabilities if at least one of the used coverage
layers reader supports filtering (e.g. image mosaic).

I would like to backport this to GS 2.11.x right away, this issue is between a bug and an improvement.
The nature of the changes are additive and self contained to the Openlayers output format.

In the users point of view the only difference will be the possibility to use the filtering capabilities when
doing the preview of a coverage whose reader supports filtering.

Any objections to backporting right away ?

Cheers,

[1] https://github.com/geoserver/geoserver/pull/2494
[2] https://osgeo-org.atlassian.net/browse/GEOS-8263


Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Ian Turton