[Geoserver-devel] Little pet peeve: hiding tools/demo pages if there is nothing inside

Hi,
one little pet peeve I have with the 2.1 GUI is that there is that Tools links
pointing to a empty page.
One looks at it and wonders... why it's there in the first place if it leads
to nothing? :slight_smile:

So I cooked the attached little patch that will hide the Tools and Demos
page links in case there is nothing in the app context that would fill them.

What do you think?

Cheers
Andrea

--
Ing. Andrea Aime
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-----------------------------------------------------

(attachments)

hide.patch (2.86 KB)

+1, a link that goes to an empty page makes little sense. I might rename the authorizer class to something more indicative of what it does though. Something like “NoPageLinksAuthorizer” or “EmptyPageLinksAuthorizer”.

On Sun, Jan 16, 2011 at 3:57 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
one little pet peeve I have with the 2.1 GUI is that there is that Tools links
pointing to a empty page.
One looks at it and wonders… why it’s there in the first place if it leads
to nothing? :slight_smile:

So I cooked the attached little patch that will hide the Tools and Demos
page links in case there is nothing in the app context that would fill them.

What do you think?

Cheers
Andrea

–
Ing. Andrea Aime
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf



Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

+1 here, I had that annoyance a couple weeks ago.

On Mon, Jan 17, 2011 at 10:22 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

+1, a link that goes to an empty page makes little sense. I might rename the authorizer class to something more indicative of what it does though. Something like “NoPageLinksAuthorizer” or “EmptyPageLinksAuthorizer”.

On Sun, Jan 16, 2011 at 3:57 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
one little pet peeve I have with the 2.1 GUI is that there is that Tools links
pointing to a empty page.
One looks at it and wonders… why it’s there in the first place if it leads
to nothing? :slight_smile:

So I cooked the attached little patch that will hide the Tools and Demos
page links in case there is nothing in the app context that would fill them.

What do you think?

Cheers
Andrea

–
Ing. Andrea Aime
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf



Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.


Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Seems fine to me; there is however the danger of someone looking for the "Demos" page; as such it may be easier to have an empty page; and fill it in with some text indicating "no demos are currently installer". In the case of tools you could even link to some instructions on how to install tools.

Jody

On 16/01/2011, at 8:57 PM, Andrea Aime wrote:

Hi,
one little pet peeve I have with the 2.1 GUI is that there is that Tools links
pointing to a empty page.
One looks at it and wonders... why it's there in the first place if it leads
to nothing? :slight_smile:

So I cooked the attached little patch that will hide the Tools and Demos
page links in case there is nothing in the app context that would fill them.

What do you think?

Cheers
Andrea

--
Ing. Andrea Aime
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-----------------------------------------------------
<hide.patch>------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

On Mon, Jan 17, 2011 at 10:26 PM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Seems fine to me; there is however the danger of someone looking for the "Demos" page; as such it may be easier to have an empty page; and fill it in with some text indicating "no demos are currently installer". In the case of tools you could even link to some instructions on how to install tools.

Demos can be missing only if someone removes them forcefully from the
install, at that point
I guess the admin knows what he's dealing with.
Tools on the other side are available only if you install only
new/experimental modules.

That's why I want to go for hiding them

Cheers
Andrea

--
Ing. Andrea Aime
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-----------------------------------------------------