Hi guys,
I have performed a massive change on 1.7.x for switching from
StringBuffer to StringBuilder.
I have run the tests and everything seems fine. Now, should I commit?
I know aaime is not super happy about this type of change, but here
you have some backg info on why I did it:
http://littletutorials.com/2008/07/16/stringbuffer-vs-stringbuilder-performance-comparison/
http://java.sun.com/performance/reference/whitepapers/5.0_performance.html#2.3
Simone.
--
-------------------------------------------------------
Eng. Simone Giannecchini
GeoSolutions S.A.S.
Owner - Software Engineer
Via Carignoni 51
55041 Camaiore (LU)
Italy
phone: +39 0584983027
fax: +39 0584983027
mob: +39 333 8128928
http://www.geo-solutions.it
http://www.geo-solutions.it/simone.giannecchini
http://www.linkedin.com/in/simonegiannecchini
-------------------------------------------------------
So as far as I understand StringBuilder is a complete drop in replacement, just faster.
While I think the change is definitely beneficial (who does not like faster code ), i too have reservations along with andrea about doing this sort of change on a stable branch.
I know that the change is supposed to be seamless, and all tests are passing but if history has taught me anything, it is that there is *always* something that comes up with this sort of change.
Anyways, not against the change... Although I would prefer it done on trunk. However, if we think the performance gain is worth the risk then lets go for it.
My 2c.
-Justin
Simone Giannecchini wrote:
Hi guys,
I have performed a massive change on 1.7.x for switching from
StringBuffer to StringBuilder.
I have run the tests and everything seems fine. Now, should I commit?
I know aaime is not super happy about this type of change, but here
you have some backg info on why I did it:
http://littletutorials.com/2008/07/16/stringbuffer-vs-stringbuilder-performance-comparison/
http://java.sun.com/performance/reference/whitepapers/5.0_performance.html#2.3
Simone.
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
Well,
I would not die for not having this change committed, hence I am
willing to update the JIRA report to trunk only and I will commit it
there as I have time.
Ciao,
Simone
On Sun, Nov 2, 2008 at 10:24 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:
So as far as I understand StringBuilder is a complete drop in
replacement, just faster.
While I think the change is definitely beneficial (who does not like
faster code ), i too have reservations along with andrea about doing
this sort of change on a stable branch.
I know that the change is supposed to be seamless, and all tests are
passing but if history has taught me anything, it is that there is
*always* something that comes up with this sort of change.
Anyways, not against the change... Although I would prefer it done on
trunk. However, if we think the performance gain is worth the risk then
lets go for it.
My 2c.
-Justin
Simone Giannecchini wrote:
Hi guys,
I have performed a massive change on 1.7.x for switching from
StringBuffer to StringBuilder.
I have run the tests and everything seems fine. Now, should I commit?
I know aaime is not super happy about this type of change, but here
you have some backg info on why I did it:
http://littletutorials.com/2008/07/16/stringbuffer-vs-stringbuilder-performance-comparison/
http://java.sun.com/performance/reference/whitepapers/5.0_performance.html#2.3
Simone.
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
-------------------------------------------------------
Eng. Simone Giannecchini
GeoSolutions S.A.S.
Owner - Software Engineer
Via Carignoni 51
55041 Camaiore (LU)
Italy
phone: +39 0584983027
fax: +39 0584983027
mob: +39 333 8128928
http://www.geo-solutions.it
http://www.geo-solutions.it/simone.giannecchini
http://www.linkedin.com/in/simonegiannecchini
-------------------------------------------------------