[Geoserver-devel] may we remove @uml.property javadocs?

GeoServer GeoServer Developer
1

I have wandered into a dark corner of geoserver (contact information) and found that we do not have a user interface to define the onlineResource used by the welcome page.

Many of the ContactInformation javadocs have @anonymised.com annotations (which stackexchanges claims is from an old uml plugin. May these be safely removed - or are they still used by an xml or json mapper?

···

–
Jody Garnett

2

Hi Jody,
if it’s what I think, it’s still in the build files:

https://github.com/geoserver/geoserver/blob/main/src/pom.xml#L2136

Haven’t used it ages, don’t know if it’s still working. No objections to removing it.

Cheers
Andrea

···

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts!

Visit http://bit.ly/gs-services-us for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions Group
phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 339 8844549

https://www.geosolutionsgroup.com/

http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail

3

Okay if it is still in the build files then I will continue to maintain it where I see it.

I made the mistake of trying to understand some geoserver data model stuff and am confused about.

Handling of ContactInfo.getAddress() and ContactInfo.getAddressDeliveryPoint():

Handling of online resource:

  • settings online resource documented as a fallback URL for organization name
  • settings online resource actually used as a default for WFS online source in GetCapabilities generation (which some code assumes is service location)
  • Without a settings online ressource WFS GetCapabilities generates a different kind of online resource that references the web service end-point (not the organization name)

SettingsInfo.getOnlineResource()

  • no user interface but expected by welcome page, only modified by REST API, or on initial creation

  • javadoc: Provider web site used for default contact information, or service provider information if user has not filled in contact details.

  • aside: Workspace ServiceInfo user interface also does not allow this to be modified, only modified by REST API, or on initial creation

  • action: Add this to global settings page page so user can configure it

ContactInfo.getOnlineResource()

  • this should be used by the welcome page and is clearly the URL of the website for the organization providing the service
  • action: add to contact info page so user can supply a value

WFSInfo.getOnlineResource()

  • WFS 1.0.0 specification defines:

The element defines the top-level HTTP URL of this service. Typically the URL of a “home page” for the service.
example is:
http://www.someserver.com/wfs/cwwfs.cgi?

  • WFS 1.1.0 ServiceIdentification does not have this concept

  • WFS 2.0.0 does not have this concept, delegates to https://schemas.opengis.net/ows/1.1.0/owsServiceIdentification.xsd

  • While WFS 1.0.0 spec a plain URL for organiation name, the ESRI WFS examples tend to list the service endpoint (maybe they default to an html page)

  • GeoServer WFS 1.0.0 implementation returns ${base_url}/geoserver/wfs if SettingsInfo.getOnlineResource() is not available, it should return an html page as with the other services.

  • action: Change WFS 1.0.0 to default to ${base_url}/geoserver rather than ${base_url}/geoserver/wfs (if settings and wfsinfo online resources are empty)

  • https://osgeo-org.atlassian.net/browse/GEOS-10668

WMSInfo.getOnlineResource()

  • ServiceProvider/ProviderStite - should be from SerivceInfo.getOnlineResource()

  • WMS 1.3 documents online resource as the website of the service provider

  • WMS GetCapabilites example is inconclusive could be either organization url or service end-point URL.

  • GeoServer WMS 1.3.0 uses ${base_url}/geoserver to direct user to an html page (if settings online resource not available)

  • GeoServer WMS 1.1.1 uses ${base_url}/geoserver to direct user to an html page (if settings online resource not available)

  • action: Check WMSInfo.getOnlineResource() and Settings.getOnlineResource() before defaulting to ${base_url}/geoserver

WMTSInfo.getOnlineResource()

  • uses ows as above, does not have the concept of service identification online resource
  • it does have ServiceProvider/ProviderSite which performs the same role
  • however GWC was not getting the “providerSite” information correctly https://osgeo-org.atlassian.net/browse/GEOS-10664
  • action: Determine ProviderSite from WMTSInfo.getOnlineResource() with SettingsInfo.getOnlineResource() as fallback

WCSInfo.getOnlineResource()

  • uses ows as above, does not have the concept of service identification online resource

WPSInfo.getOnlineResource()

  • uses ows as above, does not have the concept of service identification online resource

–
Jody

On Wed, Sep 21, 2022 at 3:56 AM Andrea Aime <andrea.aime@…6887…> wrote:

Hi Jody,
if it’s what I think, it’s still in the build files:

https://github.com/geoserver/geoserver/blob/main/src/pom.xml#L2136

Haven’t used it ages, don’t know if it’s still working. No objections to removing it.

Cheers
Andrea

On Wed, Sep 21, 2022 at 2:52 AM Jody Garnett <jody.garnett@anonymised.com.403…> wrote:

I have wandered into a dark corner of geoserver (contact information) and found that we do not have a user interface to define the onlineResource used by the welcome page.

Many of the ContactInformation javadocs have @anonymised.com annotations (which stackexchanges claims is from an old uml plugin. May these be safely removed - or are they still used by an xml or json mapper?

–
Jody Garnett

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts!

Visit http://bit.ly/gs-services-us for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions Group
phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 339 8844549

https://www.geosolutionsgroup.com/

http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail

4

It’s there, but I don’t think is has been used in years.
As said “Haven’t used it ages, don’t know if it’s still working”.
Is anyone actually using it?

Cheers
Andrea

···

GeoServer Professional Services from the experts!

Visit http://bit.ly/gs-services-us for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions Group
phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 339 8844549

https://www.geosolutionsgroup.com/

http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail