Thanks Andrea.
So yeah, re managing the connections the current implementation I have allows you to specify the the connection params directly, ie the reader would manage it’s own connection pool. But also allow for grabbing the connection from JNDI. Basically what the JDBC datastores do. For the project I am going to deploy this in the JNDI option will be what we use to optimize the connection usage.
Passing in a connection pool via a hint would also work nicely, basically the same way it works when an ExecutorService is passed in. I am not sure what the GeoServer side of that looks like though…
It would also be nice to utilize the apis in coverage for serving up multiple coverages from a single reader. I went down that route but was a little confused as to how well this is supported. AbstractGridCoverage2DReader seems to be written to maintain state about multiple coverages which is good. But on the GeoServer side I am unsure if the relationship between coverage store and coverage has to be 1:1… has this changed at all recently? Or maybe it was always possible… not sure. Anyways, if it was possible to use a single reader instance for multiple coverages from the same coverage store storing a connection pool in that reader would also be a good way to share the connection pool.
Interested to hear your thoughts.
-Justin
On Thu, Nov 29, 2018 at 7:51 AM Andrea Aime <andrea.aime@anonymised.com> wrote:
Hi Justin,
makes sense to me, thanks for keeping up up to date. The code seems interesting, what about putting it in a community module?
Wondering how you’ll manage the connections and their eventual pooling, Gabriel pulled some trick with the SDE to make it share
with the store, could be interesting to have the same, e.g., the ability to pass a pool as parts of the reader hints maybe.
Cheers
Andrea
On Tue, Nov 27, 2018 at 11:44 PM Justin Deoliveira <jdeolive@anonymised.com> wrote:
Hey folks, just thought I would update on this. So after looking into the imagemosaic jdbc plugin we decided to go with a different approach. Once I started looking into what the effort of updating the imagemosaic jdbc stuff it seemed like much less effort to just implement reader dedicated to postgis rasters. Also much simpler in terms of configuration since it won’t require a bunch of manual mapping, etc… so I’ve embarked on that approach.
The project will be happy to donate all of that code to GeoTools if people find it useful.
Thanks again to Andrea and Christian for all the feedback.
On Mon, Nov 19, 2018 at 12:21 PM Justin Deoliveira <jdeolive@anonymised.com> wrote:
Ok cool, sorry I didn’t see that in the docs. Thanks Andrea, that’s very helpful.
On Mon, Nov 19, 2018 at 12:13 PM Andrea Aime <andrea.aime@anonymised.com> wrote:
On Mon, Nov 19, 2018 at 8:09 PM Justin Deoliveira <jdeolive@anonymised.com> wrote:
Thanks for the info Christian, I assume you replied directly to me by accident so re-including the list.
My initial thought was that there would be just one “time column” composed of discrete timestamps, or at least that is the use case I currently have. I am also kind of going off of what the core mosaic reader does and unless I am mistaken (which is very possible to someone please let me know 
) there is just a single time attribute for each entry of the mosaic and you can specify the time resolution to essentially create an interval.
That said a start/end date also makes sense to me. I haven’t started digging into the code yet but I will keep this in mind in the approach and perhaps add support for both modes if people think that makes sense?
The image mosaic works either off one timestamp column, for instant time support, or two time columns, begin and end, for time range support.
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
–
Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
