Hello,
Quite a while back I made security users/groups/roles REST endpoints using Spring Controllers and JAXB. They were put in the geofence-server module, rather than restconfig, even though they work for all user/group/role services. The reason was that they didn't use restlet and we didn't want to introduce additional dependencies to geoserver.
However, now that rest-config itself has moved to Spring, they could now finally be moved and become part of the official rest of geoserver that is accessible to everyone. They do use JAXB rather than XStream, but nevertheless apparently no added dependencies are necessary.
Before I make a PR for this, are there any objects/concerns/... ?
Kind Regards
Niels
Hi Niels,
in principle that sounds like a great idea, but core code needs to be maintained.
So, who’s going to do it? That involves:
- Answering user mails about it
- Looking after Jira (at least check reports validity and grab information) and eventually participate to the monthly code sprint to fix bugs for it
- Give directions to fellow developers that might be interested in hacking on it
For core code that normally involves the PSC, but none of us is familiar with the above code (see also the
parallel thread titled “help wit the user list”).
Graduation to core also requires a review to check everything is in place (documentation, tests, code conventions and the like).
···
–
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
Hello Andrea,
With regards to users and developers, I am definitely the person to answer questions and give directions. In general, I am always willing to communicate in detail about functionality/code I wrote. I hear you about the users list, for many questions there I am not the best person to answer, but I will do my best to pay more attention to it. If I do happen to miss something where I am needed/useful, please feel free to forward/cc or even just drop my name and then I will with absolute certainty respond to it very quickly. The same counts for jira really, but yes, I will repeatedly check stuff that applies to me more often.
Kind Regards
Niels
···
On 27-06-17 12:49, Andrea Aime wrote:
Hi Niels,
in principle that sounds like a great idea, but core code needs to be maintained.
So, who’s going to do it? That involves:
- Answering user mails about it
- Looking after Jira (at least check reports validity and grab information) and eventually participate to the monthly code sprint to fix bugs for it
- Give directions to fellow developers that might be interested in hacking on it
For core code that normally involves the PSC, but none of us is familiar with the above code (see also the
parallel thread titled “help wit the user list”).
Graduation to core also requires a review to check everything is in place (documentation, tests, code conventions and the like).
–
Regards,
Andrea Aime
== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.