[Geoserver-devel] Moving CSS style menu entry

Hi,
does anybody mind if we move the CSS styles menu entry right after styles,
just like the importer one is now in the data section?

Cheers
Andrea

== Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information ==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Nope, I would say that is a much more appropriate place for it.

···

On Tue, Jan 28, 2014 at 11:49 AM, Andrea Aime <andrea.aime@anonymised.com.> wrote:

Hi,
does anybody mind if we move the CSS styles menu entry right after styles,
just like the importer one is now in the data section?

Cheers
Andrea

== Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information ==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive

I think it should stay where it is.

···

On Tue, Jan 28, 2014 at 1:56 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Nope, I would say that is a much more appropriate place for it.


WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

David Winslow

Boundless - http://boundlessgeo.com/

On Tue, Jan 28, 2014 at 11:49 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
does anybody mind if we move the CSS styles menu entry right after styles,
just like the importer one is now in the data section?

Cheers
Andrea

== Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information ==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive

On Tue, Jan 28, 2014 at 10:10 PM, David Winslow
<dwinslow@anonymised.com>wrote:

I think it should stay where it is.

Want to share with us some reason why? :slight_smile:

Cheers
Andrea

--
== Our support, Your Success! Visit http://opensdi.geo-solutions.it for
more information ==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Currently the CSS style format is not truly recognized by geoserver and the extension is a hack with some rough edges. As long as you can modify the generated SLD by hand (or external tools such as OpenGeo Suite’s GeoExplorer) and have your changes blown away by the next edit made in CSS I think the CSS editing page should stay in the demo category.

On the other hand, if and when CSS is properly integrated I’d like to simply do away with the separate editor and use the same workflows for managing both types of style within GeoServer.

···

On Tue, Jan 28, 2014 at 10:10 PM, David Winslow <dwinslow@anonymised.com> wrote:

I think it should stay where it is.

Want to share with us some reason why? :slight_smile:

Cheers
Andrea

== Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information ==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


While I agree with David that the current integration leaves much to be desired I don’t see much harm in moving the menu item. If the intent of the current location is to warn that the module still has “rough edges” I don’t think the location in the menu really matters and perhaps something more explicit like a warning on the css page itself should be added.

Btw, a while back I started a branch dedicated to more deeply integrating the css module in the way David describes, but it still needs work. What is there is really just the building blocks of making styling language pluggable.

https://github.com/jdeolive/geoserver/tree/style-css

···

On Wed, Jan 29, 2014 at 6:52 AM, David Winslow <dwinslow@anonymised.com> wrote:

Currently the CSS style format is not truly recognized by geoserver and the extension is a hack with some rough edges. As long as you can modify the generated SLD by hand (or external tools such as OpenGeo Suite’s GeoExplorer) and have your changes blown away by the next edit made in CSS I think the CSS editing page should stay in the demo category.

On the other hand, if and when CSS is properly integrated I’d like to simply do away with the separate editor and use the same workflows for managing both types of style within GeoServer.

On Jan 29, 2014 2:18 AM, “Andrea Aime” <andrea.aime@anonymised.com> wrote:

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive

On Tue, Jan 28, 2014 at 10:10 PM, David Winslow <dwinslow@anonymised.com> wrote:

I think it should stay where it is.

Want to share with us some reason why? :slight_smile:

Cheers
Andrea

== Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information ==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


A warning on the CSS page wouldn’t help - the warning needs to be everywhere that SLD is manipulated instead.

···

On Wed, Jan 29, 2014 at 10:07 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

While I agree with David that the current integration leaves much to be desired I don’t see much harm in moving the menu item. If the intent of the current location is to warn that the module still has “rough edges” I don’t think the location in the menu really matters and perhaps something more explicit like a warning on the css page itself should be added.

Btw, a while back I started a branch dedicated to more deeply integrating the css module in the way David describes, but it still needs work. What is there is really just the building blocks of making styling language pluggable.

https://github.com/jdeolive/geoserver/tree/style-css

David Winslow

Boundless - http://boundlessgeo.com/

On Wed, Jan 29, 2014 at 6:52 AM, David Winslow <dwinslow@anonymised.com> wrote:

Currently the CSS style format is not truly recognized by geoserver and the extension is a hack with some rough edges. As long as you can modify the generated SLD by hand (or external tools such as OpenGeo Suite’s GeoExplorer) and have your changes blown away by the next edit made in CSS I think the CSS editing page should stay in the demo category.

On the other hand, if and when CSS is properly integrated I’d like to simply do away with the separate editor and use the same workflows for managing both types of style within GeoServer.

On Jan 29, 2014 2:18 AM, “Andrea Aime” <andrea.aime@anonymised.com> wrote:

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive

On Tue, Jan 28, 2014 at 10:10 PM, David Winslow <dwinslow@anonymised.com> wrote:

I think it should stay where it is.

Want to share with us some reason why? :slight_smile:

Cheers
Andrea

== Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information ==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Wed, Jan 29, 2014 at 5:06 PM, David Winslow <dwinslow@anonymised.com>wrote:

A warning on the CSS page wouldn't help - the warning needs to be
everywhere that SLD is manipulated instead.

True indeed. However... if we want it to be in the "demo section" it should
be in the same page as the
the wcs/wps request builders and demo requests.

The position it's now, I agree it's at the bottom, but it's also bigger
than the normal style link

Cheers
Andrea

--
== Our support, Your Success! Visit http://opensdi.geo-solutions.it for
more information ==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

To alleviate some of the integration concerns would it be possible to put a check in the style editor and make it read-only if a css style is present. This would prevent the causal replacement of a css style.

Jody

···

Jody Garnett

On Thu, Jan 30, 2014 at 3:30 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:


WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

On Wed, Jan 29, 2014 at 5:06 PM, David Winslow <dwinslow@anonymised.com…3839…> wrote:

A warning on the CSS page wouldn’t help - the warning needs to be everywhere that SLD is manipulated instead.

True indeed. However… if we want it to be in the “demo section” it should be in the same page as the
the wcs/wps request builders and demo requests.

The position it’s now, I agree it’s at the bottom, but it’s also bigger than the normal style link

Cheers

Andrea

== Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information ==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


I am sure we are well passed what Andrea had time to do as a quick fix.

As a short-term fix could we break out an extension for the styles listed. Core can link to the sld editor, the css module can link to the css editor. This would remove the need to have the CSS editor list as a separate page.

···

Jody Garnett

On Thu, Jan 30, 2014 at 3:34 PM, Jody Garnett <jody.garnett@anonymised.com> wrote:

To alleviate some of the integration concerns would it be possible to put a check in the style editor and make it read-only if a css style is present. This would prevent the causal replacement of a css style.

Jody

Jody Garnett

On Thu, Jan 30, 2014 at 3:30 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:


WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

On Wed, Jan 29, 2014 at 5:06 PM, David Winslow <dwinslow@anonymised.com> wrote:

A warning on the CSS page wouldn’t help - the warning needs to be everywhere that SLD is manipulated instead.

True indeed. However… if we want it to be in the “demo section” it should be in the same page as the
the wcs/wps request builders and demo requests.

The position it’s now, I agree it’s at the bottom, but it’s also bigger than the normal style link

Cheers

Andrea

== Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information ==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Thu, Jan 30, 2014 at 8:46 AM, Jody Garnett <jody.garnett@anonymised.com>wrote:

I am sure we are well passed what Andrea had time to do as a quick fix.

As a short-term fix could we break out an extension for the styles listed.
Core can link to the sld editor, the css module can link to the css editor.
This would remove the need to have the CSS editor list as a separate page.

It would still be a API change, we cannot do it while in feature freeze...
I'm going to drop this one, the discussion already used more time than
the change I was proposing would have

Cheers
Andrea

--
== Our support, Your Success! Visit http://opensdi.geo-solutions.it for
more information ==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------